Niek Otten
3abf8f7ccf
All checks were successful
## What & why
Finishes **S-12 · Behandel-portal — werkbak + beoordeling**. The backend sub-slices (S-12a/b/c-1/c-2) were merged, but the slice's stated outcome — a behandel *portal* with medewerker login, a werkbak, and decide — had no frontend. This adds it.
- **`libs/auth`**: `MedewerkerAuthService` + `provideMedewerkerAuth` (Keycloak `medewerker` realm), a `roles`/`hasRole` surface on the shared `AuthService`, and a realm-roles protocol mapper so the SPA can read `behandelaar`/`teamlead` from the token. The BFF remains the security boundary (ADR-0013).
- **`apps/behandel`**: a new Nx Angular app mirroring self-service — medewerker OIDC login and a **werkbak** page listing registrations awaiting beoordeling (`GET /behandel/werkbak`) with per-row **Goedkeuren/Afwijzen** actions (`POST /behandel/registrations/{id}/decide`) that refresh the list. NL DS/Utrecht, standalone + signals.
- **e2e**: the walking-skeleton happy path now approves through the real portal (behandelaar logs in, finds the row by reference, clicks Goedkeuren) instead of the temporary admin endpoint.
- **infra/docs**: behandel service in compose (`:8142`, depends on Keycloak); added to the smoke `WAIT_SVCS` + CI log dump; `frontend-decisions.md` and `demo-script.md` updated.
Closes #13
## Definition of Done
- [x] Linked Gitea issue (above).
- [x] Failing test committed before the implementation.
- [x] Implementation makes the test pass; refactor commit if structure improved.
- [x] Conventional Commits referencing the issue (`refs #13`).
- [ ] CI green — all Gitea Actions jobs.
- [x] `docker compose up` from a fresh clone reaches green health checks within 3 minutes. *(behandel image + container verified locally; full stack gated in CI.)*
- [x] Docs updated if behaviour, contracts, or operations changed.
- [x] ADR added — ADR-0013 (merged with the backend sub-slices) already covers the wiring; no new decision here.
- [x] Demo note in `docs/demo-script.md`.
## Notes for reviewers
- Verified locally: auth + behandel + all frontend projects pass lint & unit tests (incl. axe WCAG 2.1 AA); production build green; the behandel Docker image builds and serves with the correct baked `medewerker` config + SPA fallback.
- The full compose-up smoke, e2e, and mutation are CI-gated (known local full-stack verify limits).
- **Follow-ups (not in scope):** the `WerkbakItem` contract has no citizen name (werkbak shows the BSN) — adding one is a BFF+domain contract change; and the domain's temporary admin `approve` endpoint is now unused by the e2e and could be removed.
Reviewed-on: #87
34 lines
1.7 KiB
TypeScript
34 lines
1.7 KiB
TypeScript
import { defineConfig, devices } from '@playwright/test';
|
|
|
|
// The e2e runs inside the compose network (infra/run-e2e-check.sh); baseURL defaults to the
|
|
// self-service service. Keep timeouts generous — the first navigation triggers the DigiD flow.
|
|
const baseURL = process.env.SELF_SERVICE_URL ?? 'http://self-service';
|
|
// The behandel portal is a second origin the happy path visits (staff approve from the werkbak);
|
|
// it needs the same insecure-origin-as-secure treatment as self-service for the PKCE login (below).
|
|
const behandelURL = process.env.BEHANDEL_URL ?? 'http://behandel';
|
|
|
|
export default defineConfig({
|
|
testDir: '.',
|
|
timeout: 90_000,
|
|
expect: { timeout: 15_000 },
|
|
retries: 1,
|
|
reporter: [['list']],
|
|
use: {
|
|
baseURL,
|
|
trace: 'on-first-retry',
|
|
// The portal is served over plain HTTP on a non-localhost origin (http://self-service) inside the
|
|
// compose network, so it is NOT a secure context — and Web Crypto (`crypto.subtle`) is undefined
|
|
// there. angular-auth-oidc-client needs SubtleCrypto to build the PKCE code challenge, so
|
|
// `authorize()` throws and the login redirect never fires (the login form never appears). In
|
|
// production the portal runs behind HTTPS, where this works. Rather than terminate TLS in the
|
|
// throwaway e2e stack, tell Chromium to treat this origin as secure — which faithfully emulates
|
|
// the production HTTPS context. This flag is only honoured by the full Chromium build (new
|
|
// headless), not Playwright's default headless-shell, so pin `channel: 'chromium'`.
|
|
channel: 'chromium',
|
|
launchOptions: {
|
|
args: [`--unsafely-treat-insecure-origin-as-secure=${baseURL},${behandelURL}`],
|
|
},
|
|
},
|
|
projects: [{ name: 'chromium', use: { ...devices['Desktop Chrome'] } }],
|
|
});
|