All checks were successful
## What & why Second sub-slice of **S-11 · Withdrawal (Flow 3)** (#12). S-11a (#88) made a withdrawal advance the aggregate to INGETROKKEN; this sub-slice **cancels the running Flowable process** so the withdrawn case leaves the behandelaar's werkbak. - **BPMN** (`registratie.bpmn`): an interrupting message boundary event (`RegistratieIngetrokken`) on the `Beoordelen` task, routing to a dedicated "Registratie ingetrokken" end event. - **Workflow Client**: `WithdrawBeoordelingAsync(executionId)` delivers `messageEventReceived` to the task's execution (PUT); `BeoordelingTask` now carries its `executionId`. - **`WithdrawRegistration` handler**: after the domain transition, finds the open `Beoordelen` task for the registration and delivers the withdrawal message — best-effort, mirroring how the beoordeling completes its task. - **Werkbak**: also filters out registrations that are no longer open, so a withdrawn case never surfaces even in the brief window before cancellation lands. - **ADR-0014** records the decision (message event in BPMN vs. deleting the instance from code). - **verify (`run-domain-check.sh`)**: a second registration parks at `Beoordelen`, is withdrawn via the domain, and the check asserts its `Beoordelen` task disappears — so verify-stack validates the live Flowable message correlation. Refs #12 (S-11c — the BFF + self-service "trek aanvraag in" button + e2e — closes it). ## Definition of Done - [x] Linked Gitea issue (#12). - [x] Failing tests committed before the implementation (red → green per commit). - [x] Implementation makes the tests pass. - [x] Conventional Commits referencing the issue (`refs #12`). - [ ] CI green — all Gitea Actions jobs. - [x] `docker compose up` unaffected (BPMN redeploys on a fresh CI DB via flowable-init). - [x] ADR added (ADR-0014). - [x] Docs — the user-visible demo note lands with S-11c. ## Notes for reviewers - Verified locally: `Big.Tests` 94/94 pass; `Big.Api` builds; `registratie.bpmn` is well-formed. - The Flowable message-correlation REST shape is validated **live** by verify-stack (the Workflow Client unit tests stub the exchange and assert only the request shape, per ADR-0009) — the new `run-domain-check.sh` withdrawal step is that live check. - Known gap (ADR-0014): a withdrawal that races ahead of the process reaching `Beoordelen` finds no task to cancel; the aggregate is still INGETROKKEN and the werkbak filter hides it, but that instance parks unattended. A process-level event subprocess would close the gap — deferred. Reviewed-on: #89
65 lines
2.4 KiB
C#
65 lines
2.4 KiB
C#
using Big.Application;
|
|
using Big.Domain;
|
|
|
|
namespace Big.Tests;
|
|
|
|
/// <summary>
|
|
/// The werkbak query (S-12c): the behandelaar's list of registrations awaiting beoordeling. It reads
|
|
/// the open Beoordelen tasks from the workflow engine (§8.2) and enriches each with its registration
|
|
/// (bsn + status) from the store. A task whose registration is unknown is skipped defensively.
|
|
/// </summary>
|
|
public class WerkbakTests
|
|
{
|
|
[Fact]
|
|
public async Task Lists_an_item_per_open_beoordeling_enriched_from_the_registration()
|
|
{
|
|
var store = new FakeRegistrationStore();
|
|
var registration = Registration.Submit("123456782");
|
|
registration.AttachZaak(FakeAclClient.DefaultZaakUrl);
|
|
registration.TakeIntoBehandeling();
|
|
store.Seed(registration);
|
|
var tasks = new FakeUserTaskClient([new BeoordelingTask("task-1", registration.Id)]);
|
|
var werkbak = new Werkbak(tasks, store);
|
|
|
|
var items = await werkbak.GetAsync();
|
|
|
|
var item = Assert.Single(items);
|
|
Assert.Equal(registration.Id.ToString(), item.RegistrationId);
|
|
Assert.Equal("123456782", item.Bsn);
|
|
Assert.Equal("InBehandeling", item.Status);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Is_empty_when_no_beoordelingen_are_open()
|
|
{
|
|
var werkbak = new Werkbak(new FakeUserTaskClient([]), new FakeRegistrationStore());
|
|
|
|
Assert.Empty(await werkbak.GetAsync());
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Skips_a_task_whose_registration_is_unknown()
|
|
{
|
|
// Defensive: the werkbak never invents an item for a task the domain has no aggregate for.
|
|
var tasks = new FakeUserTaskClient([new BeoordelingTask("task-1", RegistrationId.New())]);
|
|
var werkbak = new Werkbak(tasks, new FakeRegistrationStore());
|
|
|
|
Assert.Empty(await werkbak.GetAsync());
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Skips_a_task_whose_registration_is_no_longer_open()
|
|
{
|
|
// A withdrawn registration (S-11) may still have a Beoordelen task lingering until the workflow
|
|
// cancels it; the werkbak lists only registrations still open for beoordeling, so it drops off.
|
|
var store = new FakeRegistrationStore();
|
|
var registration = Registration.Submit("123456782");
|
|
registration.Withdraw();
|
|
store.Seed(registration);
|
|
var tasks = new FakeUserTaskClient([new BeoordelingTask("task-1", registration.Id)]);
|
|
var werkbak = new Werkbak(tasks, store);
|
|
|
|
Assert.Empty(await werkbak.GetAsync());
|
|
}
|
|
}
|