eho/register-referentie
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat(domain): withdrawal cancels the registratie process (S-11b, refs #12) #89

Merged
not merged 9 commits from feat/12-withdrawal-workflow into main 2026-07-16 11:09:29 +00:00
Conversation 0 Commits 9 Files Changed 12 +342 -23
not commented 2026-07-16 09:30:37 +00:00
Contributor
Copy Link

What & why

Second sub-slice of S-11 · Withdrawal (Flow 3) (#12). S-11a (#88) made a withdrawal advance the aggregate to INGETROKKEN; this sub-slice cancels the running Flowable process so the withdrawn case leaves the behandelaar's werkbak.

  • BPMN (registratie.bpmn): an interrupting message boundary event (RegistratieIngetrokken) on the Beoordelen task, routing to a dedicated "Registratie ingetrokken" end event.
  • Workflow Client: WithdrawBeoordelingAsync(executionId) delivers messageEventReceived to the task's execution (PUT); BeoordelingTask now carries its executionId.
  • WithdrawRegistration handler: after the domain transition, finds the open Beoordelen task for the registration and delivers the withdrawal message — best-effort, mirroring how the beoordeling completes its task.
  • Werkbak: also filters out registrations that are no longer open, so a withdrawn case never surfaces even in the brief window before cancellation lands.
  • ADR-0014 records the decision (message event in BPMN vs. deleting the instance from code).
  • verify (run-domain-check.sh): a second registration parks at Beoordelen, is withdrawn via the domain, and the check asserts its Beoordelen task disappears — so verify-stack validates the live Flowable message correlation.

Refs #12 (S-11c — the BFF + self-service "trek aanvraag in" button + e2e — closes it).

Definition of Done

  • Linked Gitea issue (#12).
  • Failing tests committed before the implementation (red → green per commit).
  • Implementation makes the tests pass.
  • Conventional Commits referencing the issue (refs #12).
  • CI green — all Gitea Actions jobs.
  • docker compose up unaffected (BPMN redeploys on a fresh CI DB via flowable-init).
  • ADR added (ADR-0014).
  • Docs — the user-visible demo note lands with S-11c.

Notes for reviewers

  • Verified locally: Big.Tests 94/94 pass; Big.Api builds; registratie.bpmn is well-formed.
  • The Flowable message-correlation REST shape is validated live by verify-stack (the Workflow Client unit tests stub the exchange and assert only the request shape, per ADR-0009) — the new run-domain-check.sh withdrawal step is that live check.
  • Known gap (ADR-0014): a withdrawal that races ahead of the process reaching Beoordelen finds no task to cancel; the aggregate is still INGETROKKEN and the werkbak filter hides it, but that instance parks unattended. A process-level event subprocess would close the gap — deferred.
## What & why Second sub-slice of **S-11 · Withdrawal (Flow 3)** (#12). S-11a (#88) made a withdrawal advance the aggregate to INGETROKKEN; this sub-slice **cancels the running Flowable process** so the withdrawn case leaves the behandelaar's werkbak. - **BPMN** (`registratie.bpmn`): an interrupting message boundary event (`RegistratieIngetrokken`) on the `Beoordelen` task, routing to a dedicated "Registratie ingetrokken" end event. - **Workflow Client**: `WithdrawBeoordelingAsync(executionId)` delivers `messageEventReceived` to the task's execution (PUT); `BeoordelingTask` now carries its `executionId`. - **`WithdrawRegistration` handler**: after the domain transition, finds the open `Beoordelen` task for the registration and delivers the withdrawal message — best-effort, mirroring how the beoordeling completes its task. - **Werkbak**: also filters out registrations that are no longer open, so a withdrawn case never surfaces even in the brief window before cancellation lands. - **ADR-0014** records the decision (message event in BPMN vs. deleting the instance from code). - **verify (`run-domain-check.sh`)**: a second registration parks at `Beoordelen`, is withdrawn via the domain, and the check asserts its `Beoordelen` task disappears — so verify-stack validates the live Flowable message correlation. Refs #12 (S-11c — the BFF + self-service "trek aanvraag in" button + e2e — closes it). ## Definition of Done - [x] Linked Gitea issue (#12). - [x] Failing tests committed before the implementation (red → green per commit). - [x] Implementation makes the tests pass. - [x] Conventional Commits referencing the issue (`refs #12`). - [x] CI green — all Gitea Actions jobs. - [x] `docker compose up` unaffected (BPMN redeploys on a fresh CI DB via flowable-init). - [x] ADR added (ADR-0014). - [x] Docs — the user-visible demo note lands with S-11c. ## Notes for reviewers - Verified locally: `Big.Tests` 94/94 pass; `Big.Api` builds; `registratie.bpmn` is well-formed. - The Flowable message-correlation REST shape is validated **live** by verify-stack (the Workflow Client unit tests stub the exchange and assert only the request shape, per ADR-0009) — the new `run-domain-check.sh` withdrawal step is that live check. - Known gap (ADR-0014): a withdrawal that races ahead of the process reaching `Beoordelen` finds no task to cancel; the aggregate is still INGETROKKEN and the werkbak filter hides it, but that instance parks unattended. A process-level event subprocess would close the gap — deferred.
not added 6 commits 2026-07-16 09:30:38 +00:00
test(domain): the werkbak drops a registration that is no longer open (refs #12) 345191b1df 
A withdrawn registration may keep a lingering Beoordelen task until the workflow cancels it; the

werkbak must list only registrations still open for beoordeling, so it drops off.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(domain): the werkbak lists only registrations still open for beoordeling (refs #12) 435db81bdf 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
test(domain): withdrawal cancels the workflow via the Beoordelen task's execution (refs #12) 2a6874ef6d 
The WithdrawRegistration handler delivers the withdrawal message to the open Beoordelen task's

execution; the Workflow Client PUTs messageEventReceived (RegistratieIngetrokken). BeoordelingTask

now carries its executionId.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(domain): withdrawal cancels the registratie process via a BPMN message event (refs #12) edffbb4575 
Add an interrupting message boundary event (RegistratieIngetrokken) on the Beoordelen task that

ends the process; the Workflow Client delivers the message to the task's execution, and the

withdraw handler triggers it best-effort after the domain transition (ADR-0014).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
test(verify): the domain check exercises withdrawal cancelling the Beoordelen task (refs #12) 18ab868724 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
arch(workflow): ADR-0014 — withdrawal cancels the process via a message event (refs #12)
Some checks failed
CI / lint (pull_request) Failing after 1m16s
Details
CI / build (pull_request) Failing after 53s
Details
CI / unit (pull_request) Failing after 1m1s
Details
CI / mutation (pull_request) Has been cancelled
Details
CI / verify-stack (pull_request) Has been cancelled
Details
CI / frontend (pull_request) Has been cancelled
Details
92b19e5d7b 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
not added the type:slicearea:domainarea:workflow labels 2026-07-16 09:30:39 +00:00
not added 1 commit 2026-07-16 09:40:16 +00:00
fix(acceptance): implement WithdrawBeoordelingAsync on the in-memory user-task client (refs #12)
Some checks failed
CI / lint (pull_request) Failing after 1m11s
Details
CI / build (pull_request) Successful in 55s
Details
CI / unit (pull_request) Successful in 1m9s
Details
CI / mutation (pull_request) Has been cancelled
Details
CI / verify-stack (pull_request) Has been cancelled
Details
CI / frontend (pull_request) Has been cancelled
Details
b8ee6c6460 
The S-11b port change (WithdrawBeoordelingAsync + BeoordelingTask.ExecutionId) broke the solution

build: the acceptance in-memory IUserTaskClient still used the old signature. Implement the new

member and carry an executionId.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
not added 1 commit 2026-07-16 09:47:24 +00:00
style(domain): dotnet format — spacing in werkbak test task args (refs #12)
Some checks failed
CI / lint (pull_request) Successful in 1m11s
Details
CI / build (pull_request) Successful in 57s
Details
CI / unit (pull_request) Successful in 1m7s
Details
CI / frontend (pull_request) Successful in 2m42s
Details
CI / mutation (pull_request) Successful in 5m12s
Details
CI / verify-stack (pull_request) Failing after 6m51s
Details
66af21853f 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
not added 1 commit 2026-07-16 10:13:51 +00:00
fix(domain): correlate withdrawal by process instance to the subscribed execution (refs #12)
All checks were successful
CI / lint (pull_request) Successful in 1m15s
Details
CI / build (pull_request) Successful in 1m1s
Details
CI / unit (pull_request) Successful in 1m20s
Details
CI / frontend (pull_request) Successful in 2m50s
Details
CI / mutation (pull_request) Successful in 5m22s
Details
CI / verify-stack (pull_request) Successful in 7m18s
Details
ddfdedc302 
verify-stack surfaced a Flowable 500: delivering messageEventReceived to the Beoordelen task's

execution is wrong — a message boundary event's subscription lives on its own execution. Correlate

instead by the registration's process instance id (recorded at submit): query the execution

subscribed to RegistratieIngetrokken and deliver the message there. Withdrawal moves from

IUserTaskClient to IWorkflowClient.WithdrawProcessAsync; the handler no longer needs a task lookup.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
not merged commit a34caba9ea into main 2026-07-16 11:09:29 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area:acl
area:bff
area:docs
area:domain
area:event-subscriber
area:infra
area:portal-behandel
area:portal-beheer
area:portal-openbaar
area:portal-self-service
area:projection
area:workflow
type:adr-proposal
type:bug
type:chore
type:slice
No Label area:domain area:workflow type:slice
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
eho
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eho/register-referentie#89
Delete Branch "feat/12-withdrawal-workflow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?