Niek Otten
9997da8beb
All checks were successful
## What & why Before this change the self-service confirmation and the openbaar register showed **different** identifiers, so a citizen could not look their registration back up (#78). Now both surface the same **reference**: - **domain → ACL (write):** the domain `registrationId` is set as the zaak's `identificatie` on `POST /zaken`. - **event-subscriber → ACL (read):** the subscriber reads the zaak's `identificatie` back through the ACL (§8.1 — only the ACL talks to ZGW) via a new `POST /zaken/reference`, and stores it on the projection row **and** the `processed_notifications` replay log. - **BFF + openbaar:** the public view exposes `id/status/reference` (never bsn/naam) and searches by id or reference; the register's "Referentie" column shows the reference. Storing the reference in the replay log keeps ADR-0008's **rebuild-is-log-only** invariant intact — `/admin/rebuild` reproduces the reference without re-reading the ACL. Decision recorded in **ADR-0012**. ## Definition of Done - [x] Linked issue: #78 - [x] Tests written first; red → green per layer - [x] Unit + acceptance green (`make unit`): domain 49, acl 27, bff 20, event-subscriber 19, acceptance 7 - [x] Frontend lint + test green (`nx run-many -t lint test`) - [x] Mutation ≥ break(90): acl 100%, event-subscriber 100%, bff 100%, domain 98.41% (pre-existing FlowableWorkflowClient baseline, untouched) - [x] e2e extended: confirmation reference == register reference - [x] openapi.json + api-client regenerated (drift guard green) - [x] ADR-0012 added; demo-script note appended - [x] `Acl__BaseUrl` wired for the subscriber in compose closes #78 Reviewed-on: #79
66 lines
2.6 KiB
C#
66 lines
2.6 KiB
C#
using Acceptance.Support;
|
|
using Acl.Application;
|
|
using Reqnroll;
|
|
using Xunit;
|
|
|
|
namespace Acceptance.Steps;
|
|
|
|
/// <summary>Bindings for <c>EenZaakOpenen.feature</c>. Reqnroll creates one
|
|
/// instance per scenario, so instance fields hold scenario-scoped state.</summary>
|
|
[Binding]
|
|
public sealed class EenZaakOpenenSteps
|
|
{
|
|
private readonly InMemoryZaakGateway _gateway = new();
|
|
private DomainRegistration? _registration;
|
|
private AclDefaults? _defaults;
|
|
private DateOnly _today;
|
|
private Uri? _returnedUrl;
|
|
|
|
[Given("a domain registration for BSN \"(.*)\"")]
|
|
public void GivenADomainRegistrationForBsn(string bsn)
|
|
=> _registration = new DomainRegistration(bsn, "ACC-REF-1");
|
|
|
|
[Given("the ACL is configured with these defaults:")]
|
|
public void GivenTheAclIsConfiguredWithTheseDefaults(DataTable defaults)
|
|
{
|
|
var values = ToFieldMap(defaults);
|
|
_defaults = new AclDefaults
|
|
{
|
|
Bronorganisatie = values["bronorganisatie"],
|
|
VerantwoordelijkeOrganisatie = values["verantwoordelijkeOrganisatie"],
|
|
Vertrouwelijkheidaanduiding = values["vertrouwelijkheidaanduiding"],
|
|
ZaaktypeUrl = new Uri(values["zaaktype"]),
|
|
};
|
|
}
|
|
|
|
[Given("today is \"(.*)\"")]
|
|
public void GivenTodayIs(string date)
|
|
=> _today = DateOnly.Parse(date);
|
|
|
|
[When("the domain asks the ACL to open a zaak")]
|
|
public async Task WhenTheDomainAsksTheAclToOpenAZaak()
|
|
{
|
|
var service = new AclService(_gateway, _defaults!, new FixedClock(_today));
|
|
_returnedUrl = await service.OpenZaakAsync(_registration!);
|
|
}
|
|
|
|
[Then("a zaak is created with these default-filled fields")]
|
|
public void ThenAZaakIsCreatedWithTheseDefaultFilledFields(DataTable expected)
|
|
{
|
|
var request = Assert.IsType<ZaakRequest>(_gateway.Captured);
|
|
var fields = ToFieldMap(expected);
|
|
Assert.Equal(fields["bronorganisatie"], request.Bronorganisatie);
|
|
Assert.Equal(fields["verantwoordelijkeOrganisatie"], request.VerantwoordelijkeOrganisatie);
|
|
Assert.Equal(fields["vertrouwelijkheidaanduiding"], request.Vertrouwelijkheidaanduiding);
|
|
Assert.Equal(fields["zaaktype"], request.Zaaktype.ToString());
|
|
Assert.Equal(fields["startdatum"], request.Startdatum.ToString("yyyy-MM-dd"));
|
|
}
|
|
|
|
[Then("the ACL returns the URL of the created zaak")]
|
|
public void ThenTheAclReturnsTheUrlOfTheCreatedZaak()
|
|
=> Assert.Equal(InMemoryZaakGateway.CreatedZaakUrl, _returnedUrl);
|
|
|
|
private static Dictionary<string, string> ToFieldMap(DataTable table)
|
|
=> table.Rows.ToDictionary(r => r["field"], r => r["value"]);
|
|
}
|