## What & why S-10a, the **workflow/timeout spine** of the (split) document-upload slice: the registratie process now parks at a **`WachtOpDocumenten`** user task with an **interrupting `P30D` boundary timer**. When the documents arrive the task completes and the process continues into the diploma routing (S-13) → Beoordelen; if the 30 days lapse, the timer cancels the wait, runs a `RegistratieVerlopen` external-worker task, and the domain expires the aggregate to a new terminal status **`Verlopen`**. Backend only — the real upload trigger (portal → BFF → ACL → Documenten API) is S-10b (#103). Closes #102 Mechanism recorded in **ADR-0017**; opened as proposal #104. Mirrors the S-14 escalation (boundary-timer + external-worker) and S-11 withdrawal (interrupting cancel) patterns. ## Definition of Done - [x] Linked Gitea issue (above). - [x] Failing test committed before the implementation (red→green pairs per layer). - [x] Implementation makes the test pass. - [x] Conventional Commits referencing the issue (`refs #102`). - [ ] CI green — all Gitea Actions jobs (pending on this PR). - [x] `docker compose up` health unaffected (no new services; deploy path unchanged). - [x] Docs updated (ADR-0017, demo-script, BACKLOG split). - [x] ADR added (`docs/architecture/adr-0017-document-wait-timeout-cancellation.md`). - [x] Demo note in `docs/demo-script.md`. ## Notes for reviewers - **Domain** (`Registration.Expire()` + `Verlopen`), **application** (`ExpireRegistrationWorker`), **infra** (`RegistratieVerlopenProcessor`/`Pump`, `IRegistratieVerlopenClient`, Flowable acquire/complete + `CompleteDocumentWaitAsync`) — the timeout counterpart to the OpenZaak/escalation worker trios; idempotent per §8.6. - **BPMN** verified live against a `flowable-rest` probe: complete `WachtOpDocumenten` → routes to Beoordelen; fire the P30D timer → `RegistratieVerlopen` job (carrying `registrationId`) + the wait task cancelled. `verify-domain` exercises both branches in-stack (completes the wait in every existing block; fires the timer and asserts `Verlopen` in a new block). - **Scope boundary:** on expiry the aggregate goes `Verlopen` and the process ends, but the ZGW *zaak* is not yet set to a cancellation status — that needs a new ACL method + statustype seeding and is folded into S-10b (noted in ADR-0017). - `CompleteDocumentWaitAsync` is built and HTTP-tested here but not yet called from a domain endpoint; S-10b wires the upload trigger to it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Reviewed-on: #105
80 lines
3.4 KiB
C#
80 lines
3.4 KiB
C#
using Big.Application;
|
|
using Big.Infrastructure;
|
|
using Microsoft.Extensions.Logging;
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
|
|
|
namespace Big.Tests;
|
|
|
|
// S-10a (#102): the document-timeout drain loop. Mirrors BeoordelingEscalatieProcessor — acquire the
|
|
// parked RegistratieVerlopen jobs (the tokens the 30-day boundary timer on WachtOpDocumenten spawns),
|
|
// expire each correlated registration via the ExpireRegistrationWorker, then complete the job. A job
|
|
// whose expiry fails is logged and left un-completed for Flowable to redeliver (§8.6).
|
|
public class RegistratieVerlopenProcessorTests
|
|
{
|
|
/// <summary>A fake client scripting the jobs to acquire and recording completions.</summary>
|
|
private sealed class FakeVerlopenClient(params RegistratieVerlopenJob[] jobs) : IRegistratieVerlopenClient
|
|
{
|
|
public int AcquireCount { get; private set; }
|
|
public List<string> Completed { get; } = [];
|
|
|
|
public Task<IReadOnlyList<RegistratieVerlopenJob>> AcquireRegistratieVerlopenJobsAsync(int maxJobs, CancellationToken ct = default)
|
|
{
|
|
AcquireCount++;
|
|
return Task.FromResult<IReadOnlyList<RegistratieVerlopenJob>>(jobs.Take(maxJobs).ToList());
|
|
}
|
|
|
|
public Task CompleteRegistratieVerlopenJobAsync(string jobId, CancellationToken ct = default)
|
|
{
|
|
Completed.Add(jobId);
|
|
return Task.CompletedTask;
|
|
}
|
|
}
|
|
|
|
private static ExpireRegistrationWorker Worker(FakeRegistrationStore store) => new(store);
|
|
|
|
[Fact]
|
|
public async Task Acquires_a_job_expires_the_registration_and_completes_the_job()
|
|
{
|
|
var store = new FakeRegistrationStore();
|
|
var registration = Domain.Registration.Submit("123456782");
|
|
store.Seed(registration);
|
|
var client = new FakeVerlopenClient(new RegistratieVerlopenJob("job-9", registration.Id));
|
|
|
|
var acquired = await new RegistratieVerlopenProcessor(
|
|
client, Worker(store), NullLogger<RegistratieVerlopenProcessor>.Instance).PumpOnceAsync(5);
|
|
|
|
Assert.Equal(1, acquired);
|
|
Assert.Equal(Domain.RegistrationStatus.Verlopen, (await store.GetAsync(registration.Id))!.Status);
|
|
Assert.Equal("job-9", Assert.Single(client.Completed));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task A_failing_expiry_is_left_uncompleted_for_flowable_to_redeliver()
|
|
{
|
|
// Unknown registration → the worker throws → the job is left for redelivery, error logged.
|
|
var store = new FakeRegistrationStore();
|
|
var client = new FakeVerlopenClient(new RegistratieVerlopenJob("job-9", Domain.RegistrationId.New()));
|
|
var logger = new CapturingLogger<RegistratieVerlopenProcessor>();
|
|
|
|
var acquired = await new RegistratieVerlopenProcessor(client, Worker(store), logger).PumpOnceAsync(5);
|
|
|
|
Assert.Equal(1, acquired);
|
|
Assert.Empty(client.Completed);
|
|
var error = Assert.Single(logger.Entries, e => e.Level == LogLevel.Error);
|
|
Assert.Contains("job-9", error.Message);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Does_nothing_but_poll_when_there_are_no_jobs()
|
|
{
|
|
var client = new FakeVerlopenClient();
|
|
|
|
var acquired = await new RegistratieVerlopenProcessor(
|
|
client, Worker(new FakeRegistrationStore()), NullLogger<RegistratieVerlopenProcessor>.Instance).PumpOnceAsync(5);
|
|
|
|
Assert.Equal(0, acquired);
|
|
Assert.Equal(1, client.AcquireCount);
|
|
Assert.Empty(client.Completed);
|
|
}
|
|
}
|