not
0494730223
## What & why S-15b, second of the S-15 (#16) split, on top of S-15a (#133). A beheerder edits the ACL's ZGW **default-fill** values from the beheer portal, and the next zaak is stamped with the new values — no restart. Closes #131 ### The vertical portal → BFF `GET/PUT /beheer/default-fill` (medewerker realm + `beheerder` role) → ACL `GET/PUT /default-fill` → a runtime-mutable in-memory store the ACL reads **per zaak**. - **ACL**: `IDefaultFillStore` / `InMemoryDefaultFillStore` (thread-safe, seeded from `Acl:Defaults`); `AclService` reads `fill.Current` per zaak (not cached at construction); `GET`/`PUT /default-fill` with required-field validation. - **BFF**: `IAclClient` gains `GetDefaultFillAsync`/`UpdateDefaultFillAsync`; `GET`/`PUT /beheer/default-fill` behind the `beheerder` policy. OpenAPI + generated client regenerated. - **Frontend**: a *Default-fill* editor page in the beheer app (load → edit → save, with saved/failure states) + nav between Catalogus and Default-fill. ### Scope decision → ADR-0026 Only the **three ZGW fill fields** (bronorganisatie, verantwoordelijke organisatie, vertrouwelijkheidaanduiding) are editable. The S-27 catalog-resolution keys stay **static config** — editing them would desync the zaaktype-URL cache (ADR-0021), and they're catalogus wiring, not "default fill". The store is **in-memory** (seeded from config): an edit reverts on restart. That's the reference-app-appropriate ceiling (no DB added to the stateless ACL); upgrade path documented. Recorded in **ADR-0026**. ## Verified locally lint (`dotnet format`) ✓ · .NET unit — acl 60 / bff 45 / domain 152 / event-subscriber 19 / acceptance 17 ✓ · frontend lint+test (8 projects) ✓ · beheer build ✓. Clean full-solution build (caught + fixed the acceptance `AclService` ctor drift). TDD red→green per layer (ACL store, ACL endpoints, BFF, frontend). ## Definition of Done - [x] Failing test committed before each implementation (red→green per layer). - [x] Conventional Commits referencing #131. - [ ] CI green — see note below. - [x] Docs: ADR-0026 + S-15b demo note. - [x] Demo note in `docs/demo-script.md`. ## Note on CI The bulk validates in the fast jobs (lint/build/unit/frontend/mutation). The **verify-stack e2e** (incl. the new `default-fill.spec.ts`) can't go green until the pre-existing **verify-stack bring-up failure on the 1.27/2.0.0 runner** is resolved (that fails on plain `main` too — unrelated to this PR). Additive change; no existing e2e touched. 🤖 Generated with [Claude Code](https://claude.com/claude-code)Reviewed-on: #138
72 lines
3.1 KiB
C#
72 lines
3.1 KiB
C#
using Acceptance.Support;
|
|
using Acl.Application;
|
|
using Reqnroll;
|
|
using Xunit;
|
|
|
|
namespace Acceptance.Steps;
|
|
|
|
/// <summary>Bindings for <c>EenZaakOpenen.feature</c>. Reqnroll creates one
|
|
/// instance per scenario, so instance fields hold scenario-scoped state.</summary>
|
|
[Binding]
|
|
public sealed class EenZaakOpenenSteps
|
|
{
|
|
private readonly InMemoryZaakGateway _gateway = new();
|
|
private DomainRegistration? _registration;
|
|
private AclDefaults? _defaults;
|
|
private DateOnly _today;
|
|
private Uri? _returnedUrl;
|
|
|
|
[Given("a domain registration for BSN \"(.*)\"")]
|
|
public void GivenADomainRegistrationForBsn(string bsn)
|
|
=> _registration = new DomainRegistration(bsn, "ACC-REF-1");
|
|
|
|
[Given("the ACL is configured with these defaults:")]
|
|
public void GivenTheAclIsConfiguredWithTheseDefaults(DataTable defaults)
|
|
{
|
|
var values = ToFieldMap(defaults);
|
|
_defaults = new AclDefaults
|
|
{
|
|
Bronorganisatie = values["bronorganisatie"],
|
|
VerantwoordelijkeOrganisatie = values["verantwoordelijkeOrganisatie"],
|
|
Vertrouwelijkheidaanduiding = values["vertrouwelijkheidaanduiding"],
|
|
ZaaktypeIdentificatie = "BIG-REGISTRATIE",
|
|
InformatieobjecttypeOmschrijving = "Diploma",
|
|
};
|
|
// The ACL resolves the zaaktype by identificatie (S-27); the scenario's zaaktype URL is what
|
|
// the catalogus resolves it to, so the created zaak still carries that URL.
|
|
_gateway.ResolvedZaaktypeUrl = new Uri(values["zaaktype"]);
|
|
}
|
|
|
|
[Given("today is \"(.*)\"")]
|
|
public void GivenTodayIs(string date)
|
|
=> _today = DateOnly.Parse(date);
|
|
|
|
[When("the domain asks the ACL to open a zaak")]
|
|
public async Task WhenTheDomainAsksTheAclToOpenAZaak()
|
|
{
|
|
var fill = new InMemoryDefaultFillStore(new DefaultFillSettings(
|
|
_defaults!.Bronorganisatie, _defaults.VerantwoordelijkeOrganisatie, _defaults.Vertrouwelijkheidaanduiding));
|
|
var service = new AclService(_gateway, fill, new CachedZaaktypeCatalog(_gateway, _defaults!), new FixedClock(_today));
|
|
_returnedUrl = await service.OpenZaakAsync(_registration!);
|
|
}
|
|
|
|
[Then("a zaak is created with these default-filled fields")]
|
|
public void ThenAZaakIsCreatedWithTheseDefaultFilledFields(DataTable expected)
|
|
{
|
|
var request = Assert.IsType<ZaakRequest>(_gateway.Captured);
|
|
var fields = ToFieldMap(expected);
|
|
Assert.Equal(fields["bronorganisatie"], request.Bronorganisatie);
|
|
Assert.Equal(fields["verantwoordelijkeOrganisatie"], request.VerantwoordelijkeOrganisatie);
|
|
Assert.Equal(fields["vertrouwelijkheidaanduiding"], request.Vertrouwelijkheidaanduiding);
|
|
Assert.Equal(fields["zaaktype"], request.Zaaktype.ToString());
|
|
Assert.Equal(fields["startdatum"], request.Startdatum.ToString("yyyy-MM-dd"));
|
|
}
|
|
|
|
[Then("the ACL returns the URL of the created zaak")]
|
|
public void ThenTheAclReturnsTheUrlOfTheCreatedZaak()
|
|
=> Assert.Equal(InMemoryZaakGateway.CreatedZaakUrl, _returnedUrl);
|
|
|
|
private static Dictionary<string, string> ToFieldMap(DataTable table)
|
|
=> table.Rows.ToDictionary(r => r["field"], r => r["value"]);
|
|
}
|