Niek Otten
9997da8beb
All checks were successful
## What & why Before this change the self-service confirmation and the openbaar register showed **different** identifiers, so a citizen could not look their registration back up (#78). Now both surface the same **reference**: - **domain → ACL (write):** the domain `registrationId` is set as the zaak's `identificatie` on `POST /zaken`. - **event-subscriber → ACL (read):** the subscriber reads the zaak's `identificatie` back through the ACL (§8.1 — only the ACL talks to ZGW) via a new `POST /zaken/reference`, and stores it on the projection row **and** the `processed_notifications` replay log. - **BFF + openbaar:** the public view exposes `id/status/reference` (never bsn/naam) and searches by id or reference; the register's "Referentie" column shows the reference. Storing the reference in the replay log keeps ADR-0008's **rebuild-is-log-only** invariant intact — `/admin/rebuild` reproduces the reference without re-reading the ACL. Decision recorded in **ADR-0012**. ## Definition of Done - [x] Linked issue: #78 - [x] Tests written first; red → green per layer - [x] Unit + acceptance green (`make unit`): domain 49, acl 27, bff 20, event-subscriber 19, acceptance 7 - [x] Frontend lint + test green (`nx run-many -t lint test`) - [x] Mutation ≥ break(90): acl 100%, event-subscriber 100%, bff 100%, domain 98.41% (pre-existing FlowableWorkflowClient baseline, untouched) - [x] e2e extended: confirmation reference == register reference - [x] openapi.json + api-client regenerated (drift guard green) - [x] ADR-0012 added; demo-script note appended - [x] `Acl__BaseUrl` wired for the subscriber in compose closes #78 Reviewed-on: #79
51 lines
2.6 KiB
C#
51 lines
2.6 KiB
C#
namespace EventSubscriber.Application;
|
|
|
|
/// <summary>
|
|
/// The durable log of notifications the subscriber has accepted. It is both the idempotency
|
|
/// guard (a replayed notification is recognised and dropped) and the rebuild source: the
|
|
/// projection is a derived artefact (PRD §8.4) regenerated by replaying this log, so a rebuild
|
|
/// needs no access to OpenZaak (CLAUDE.md §8.1). Implemented in Infrastructure over Postgres.
|
|
/// </summary>
|
|
public interface INotificationLog
|
|
{
|
|
/// <summary>
|
|
/// Record a notification. Returns <c>true</c> if it was newly recorded, <c>false</c> if an
|
|
/// entry with the same key already existed (a duplicate delivery). Must be atomic so that
|
|
/// concurrent duplicate deliveries cannot both observe <c>true</c>.
|
|
/// </summary>
|
|
Task<bool> TryRecordAsync(RecordedNotification notification, CancellationToken ct = default);
|
|
|
|
/// <summary>Every accepted notification, for rebuilding the projection.</summary>
|
|
Task<IReadOnlyList<RecordedNotification>> AllAsync(CancellationToken ct = default);
|
|
}
|
|
|
|
/// <summary>A notification that has been accepted, retaining what a rebuild needs to recompute its
|
|
/// projection row — the ZGW <c>resource</c> (zaak-create → INGEDIEND vs status-set → INGESCHREVEN) and
|
|
/// the zaak <c>reference</c> (identificatie), so a rebuild reproduces the row without re-reading ZGW (#78).</summary>
|
|
public sealed record RecordedNotification(string Key, string Actie, string ZaakId, string Resource, string? Reference);
|
|
|
|
/// <summary>
|
|
/// Port to the Anti-Corruption Layer. The subscriber enriches the projection with the zaak's
|
|
/// public-safe reference (its identificatie) by asking the ACL — the only code that may read ZGW
|
|
/// (§8.1) — rather than reading OpenZaak itself (adr-proposal #78).
|
|
/// </summary>
|
|
public interface IAclClient
|
|
{
|
|
/// <summary>The zaak's reference (identificatie) for the read projection.</summary>
|
|
Task<string> GetZaakReferenceAsync(Uri zaakUrl, CancellationToken ct = default);
|
|
}
|
|
|
|
/// <summary>The read projection store. Owned by the projection bounded context (ADR-0008); the
|
|
/// subscriber writes to it and the projection-api reads it.</summary>
|
|
public interface IProjectionStore
|
|
{
|
|
/// <summary>Insert or update the row for <see cref="RegisterEntry.Id"/>. Idempotent on the id.</summary>
|
|
Task UpsertAsync(RegisterEntry entry, CancellationToken ct = default);
|
|
|
|
/// <summary>Remove every row — the first step of a rebuild.</summary>
|
|
Task ClearAsync(CancellationToken ct = default);
|
|
|
|
/// <summary>Every projection row (used by tests and the rebuild verification).</summary>
|
|
Task<IReadOnlyList<RegisterEntry>> AllAsync(CancellationToken ct = default);
|
|
}
|