test(acl): ACL mutation-score baseline with Stryker.NET (closes #47) #52

Merged

not merged 7 commits from feat/47-acl-mutation-baseline into main 2026-06-29 09:00:30 +00:00

Conversation 0 Commits 7 Files Changed 11

+313 -27

7 Commits

Author	SHA1	Message	Date
notandClaude Opus 4.8	5f3dd31925	fix(ci): pin upload-artifact to @v3 — @v4 refuses to run on Gitea (refs #47) ... The artifact step failed the mutation job: upload-artifact@v4 bundles @actions/artifact v2, which hard-aborts on any non-github.com server ("not supported on GHES"), even though Gitea 1.25 stores artifacts fine. @v3 uses the older protocol Gitea speaks and has no GHES guard — a drop-in swap (same inputs). Document it as gotcha §4 and correct the CI runbook note. Refs #47. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-25 15:28:07 +02:00
notandClaude Opus 4.8	347713766e	ci(acl): publish the Stryker HTML report as a CI artifact (refs #47) ... Add an upload-artifact step to the mutation job so the ACL mutation report is downloadable from the run summary. `if: always()` uploads it even when the ratchet fails — exactly when the survivors matter. A glob handles Stryker's timestamped output directory. First use of actions/upload-artifact (@v4, pinned); Gitea 1.25.x supports it. Document it in the CI runbook. Refs #47. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-25 15:21:26 +02:00
notandClaude Opus 4.8	7ecc184111	arch(acl): ADR-0005 adopt Stryker.NET for mutation testing (refs #47) ... Record the decision to adopt Stryker.NET (pinned local tool, solution mode on Acl.slnx) and to set the first repo-wide mutation baseline on the ACL: observed 95%, enforced break threshold 90%. Document the ratchet, local run, and report location in the CI runbook; add the ADR to the docs nav. Proposed in #51 (adr-proposal). Refs #47. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-25 14:59:41 +02:00
notandClaude Opus 4.8	e8510bf9c3	ci(acl): run the mutation ratchet as a parallel CI job (refs #47) ... Add a `mutation` job mirroring the unit job (checkout + pinned setup-dotnet, then `make mutation`). It runs in parallel with lint/build/unit/compose-smoke and gates merges on the ACL mutation baseline (CLAUDE.md §5/§15). The job calls the same make target developers run, so the pipeline stays a mirror of `make ci`. Refs #47. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-25 14:58:22 +02:00
notandClaude Opus 4.8	6ac2fca384	test(acl): add Stryker config + mutation make target recording the 95% baseline (refs #47) ... Configure Stryker.NET for the ACL in solution mode (Acl.slnx), so both Acl.Application and Acl.Infrastructure — the two projects under test — are mutated while Acl.Api (untested) is skipped. Record the repo-wide mutation baseline as the ratchet (CLAUDE.md §5): observed score 95%, enforced break threshold 90% (one-mutant headroom over the ~20-mutant surface). The ACL is the first service with branching logic, so it sets the baseline; later slices ratchet it up deliberately, never down. Add a `mutation` make target (`dotnet tool restore` + `dotnet stryker`) and wire it into the `make ci` aggregate, keeping `make ci` an exact mirror of the pipeline. Refs #47. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-25 14:58:00 +02:00
notandClaude Opus 4.8	10816f5303	test(acl): kill surviving mutants — assert CRS headers, guards, error paths, JWT claims (refs #47) ... Stryker exposed thin ACL tests (35% mutation score): the suite never asserted the geo CRS headers, the ArgumentNullException guards, the non-success and empty-body error paths, or the structure of the minted ZGW JWT — so mutating any of those survived. Strengthen the unit tests to kill those mutants: - assert Accept-Crs / Content-Crs are EPSG:4326, - assert OpenZaakAsync rejects a null request/registration without calling out, - assert a non-2xx response throws and an empty body throws InvalidOperationException, - decode the Bearer token and assert the HS256 header + acl identity claims. Raises the ACL mutation score to 95%. The one remaining survivor mutates only the exception *message* text (an equivalent mutant — message strings are not worth a brittle assertion). Refs #47. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-25 14:57:51 +02:00
notandClaude Opus 4.8	89b097d015	build(acl): pin Stryker.NET as a local dotnet tool (refs #47) ... Add a tool manifest pinning dotnet-stryker 4.15.0 so `make mutation` runs the same mutation tester locally and in CI from a fresh clone (`dotnet tool restore`), with no global install. Ignore the generated StrykerOutput/ report directory. Refs #47. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-25 14:57:38 +02:00