ci: unstick verify-stack on Gitea 1.27 + act_runner 2.0.0 (closes #134) #135

Merged
not merged 1 commits from fix/134-verify-stack-scheduling into main 2026-07-24 11:59:29 +00:00
Contributor

What & why

After the Gitea 1.27 + act_runner 2.0.0 upgrade, verify-stack never starts: the run sits in waiting forever with no logs for that job, while the other five jobs pass — so main stays pending/red (P0). See #134.

Closes #134

Root cause

verify-stack was the only job gated by a status-function if on top of needs:

verify-stack:
  needs: [mutation]
  if: ${{ !cancelled() }}

Gitea 1.27 reworked cancellation/aggregation so that always()/cancelled()-gated needs jobs route through a new transitional Cancelling state + server↔runner capability negotiation ("Requires Gitea Runner 2.0.0"). On this 1.27 + 2.0.0 pairing that handshake doesn't resolve, so the job is never dispatched and never leaves waiting. Plain jobs (no if/needs) are unaffected — exactly the observed pattern. It worked pre-upgrade (old runner).

Fix

Drop the if: ${{ !cancelled() }}; keep needs: [mutation]. Default if: success() dispatches normally and still serialises the two memory-heavy jobs (OOM avoidance, #126).

Trade-off: the !cancelled() (added in #127) let verify-stack run even when the mutation ratchet fails. Now a failing mutation skips verify-stack; the fix-and-re-push re-run exercises it, so the signal isn't lost — just deferred to the green-mutation run. If we later want both signals on one run, serialise via a concurrency group rather than needs + always().

Documented as §7 in docs/runbooks/gitea-actions-gotchas.md.

Note on the stuck run

Run 582 (the #133 merge) will not clear itself and must be force-cancelled from the Actions UI (plain cancel can also stall on this version, gitea#35782). This PR's own run is the first real test of the fix — if verify-stack dispatches and runs here, the fix holds.

Definition of Done

  • Linked issue (#134).
  • Conventional Commit referencing the issue.
  • CI green — this PR's run is the verification (verify-stack must dispatch).
  • Runbook updated (gotchas §7).
  • Closed by the merging PR.

🤖 Generated with Claude Code

## What & why After the Gitea 1.27 + act_runner 2.0.0 upgrade, `verify-stack` never starts: the run sits in `waiting` forever with no logs for that job, while the other five jobs pass — so `main` stays pending/red (P0). See #134. Closes #134 ### Root cause `verify-stack` was the only job gated by a status-function `if` on top of `needs`: ```yaml verify-stack: needs: [mutation] if: ${{ !cancelled() }} ``` Gitea 1.27 reworked cancellation/aggregation so that `always()`/`cancelled()`-gated `needs` jobs route through a new transitional **`Cancelling`** state + server↔runner **capability negotiation** ("Requires Gitea Runner 2.0.0"). On this 1.27 + 2.0.0 pairing that handshake doesn't resolve, so the job is never dispatched and never leaves `waiting`. Plain jobs (no `if`/`needs`) are unaffected — exactly the observed pattern. It worked pre-upgrade (old runner). ### Fix Drop the `if: ${{ !cancelled() }}`; keep `needs: [mutation]`. Default `if: success()` dispatches normally and still serialises the two memory-heavy jobs (OOM avoidance, #126). **Trade-off:** the `!cancelled()` (added in #127) let verify-stack run even when the mutation ratchet fails. Now a failing mutation skips verify-stack; the fix-and-re-push re-run exercises it, so the signal isn't lost — just deferred to the green-mutation run. If we later want both signals on one run, serialise via a `concurrency` group rather than `needs` + `always()`. Documented as §7 in `docs/runbooks/gitea-actions-gotchas.md`. ## Note on the stuck run Run 582 (the #133 merge) will **not** clear itself and must be force-cancelled from the Actions UI (plain cancel can also stall on this version, gitea#35782). This PR's own run is the first real test of the fix — if `verify-stack` dispatches and runs here, the fix holds. ## Definition of Done - [x] Linked issue (#134). - [x] Conventional Commit referencing the issue. - [x] CI green — this PR's run is the verification (verify-stack must dispatch). - [x] Runbook updated (gotchas §7). - [x] Closed by the merging PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
not added 1 commit 2026-07-24 11:31:38 +00:00
ci: unstick verify-stack on Gitea 1.27 + runner 2.0.0 — drop status-function if on a needs job (refs #134)
CI / build (pull_request) Successful in 1m30s
CI / lint (pull_request) Successful in 1m40s
CI / unit (pull_request) Successful in 1m44s
CI / frontend (pull_request) Successful in 3m45s
CI / mutation (pull_request) Successful in 7m5s
CI / verify-stack (pull_request) Successful in 8m52s
a150369fef
not added the type:bugarea:infra labels 2026-07-24 11:31:46 +00:00
not merged commit 849bf4723b into main 2026-07-24 11:59:29 +00:00
Sign in to join this conversation.