register-referentie

Author	SHA1	Message	Date
not	2d783448b7	fix(e2e): assert the register record where a real approval happens (refs #149 ) CI / build (pull_request) Successful in 1m6s Details CI / lint (pull_request) Successful in 1m19s Details CI / unit (pull_request) Successful in 1m24s Details CI / verify-stack (pull_request) Successful in 7m49s Details CI / frontend (pull_request) Successful in 2m57s Details CI / mutation (pull_request) Successful in 6m7s Details verify-domain was the wrong home for the assertion, and CI was right to fail it. That check completes the Beoordelen task straight through Flowable REST — on purpose, it exists to exercise the Workflow Client's REST contract — which bypasses the domain `decide` path that calls the ACL. No approval reached the ACL there, so no record was ever written. The Playwright happy path is the only check that drives a real approval (behandel portal → BFF → domain → ACL), and it already knows its own reference. Assert there instead: exactly one RegisterRecord for that reference, INGESCHREVEN, carrying nothing outside the public-safe schema. Drops register-record-check.py and the verify-domain block. The helper was run under real Playwright against a live Objecten before committing — one record found, none for an unknown reference.	2026-08-14 10:43:34 +02:00
not	10b784cc05	fix(infra): reach Objecten by service name in the register-record check (refs #149 ) CI / build (pull_request) Successful in 1m8s Details CI / lint (pull_request) Successful in 1m23s Details CI / unit (pull_request) Successful in 1m23s Details CI / frontend (pull_request) Successful in 2m59s Details CI / mutation (pull_request) Successful in 6m8s Details CI / verify-stack (pull_request) Failing after 7m24s Details CI caught my own check falling into the constraint ADR-0028 documents: it looked Objecttypen up by container IP, so the objecttype URL came back IP-addressed and Objecten rejected it as "not one of the available choices". Reach both by service name — compose DNS resolves them, and neither request has OpenZaak's URL-validity constraint that made IPs necessary elsewhere in this script. The 400 also spent the full 60s timeout disguised as "transport:" because HTTPError is a URLError subclass. Handle it separately: a 4xx now fails immediately with the response body, which is where the real reason was. Verified both ways against a live Objecten: absent record → exit 1 with the reason, present record → exit 0.	2026-08-14 10:20:26 +02:00
not	2bb7d9c165	test(acl): ObjectenGateway integration test against live Objecten (refs #149 ) CI / build (pull_request) Successful in 4m20s Details CI / lint (pull_request) Successful in 4m38s Details CI / unit (pull_request) Successful in 1m27s Details CI / frontend (pull_request) Successful in 4m1s Details CI / mutation (pull_request) Successful in 6m52s Details CI / verify-stack (pull_request) Failing after 18m4s Details Drives the real gateway against a running Objecten + Objecttypen pair: two writes for the same id leave exactly one object carrying the second write's status, and nothing outside the public-safe schema. Runs under verify-acl, inside the compose network — which it must, because Objecttypen echoes the request Host into the objecttype `url` and Objecten only accepts the one matching its configured api_root. ADR-0028 records that constraint.	2026-08-14 09:44:15 +02:00
not	4a047c618c	fix(infra): let Objecten actually accept the register record (refs #149 ) Replaying the gateway's calls against a live Objecten + Objecttypen pair turned up two blockers CI would only have found after the fact: - Objecten rejects an objecttype it has not been configured with, and it identifies one by uuid — assigned at seed time by a one-shot that runs after Objecten's static setup_configuration. Pin the uuid on both sides instead. - Objecten notifies on every write and notifications_api_common raises when that config is absent, so every POST 500'd after rolling the object back. Objecten → NRC has no broker, worker, kanaal or abonnement yet, so disable notifications rather than wire a client that drops every message; S-19b turns them on for real. With both in place the full exchange verifies end to end: lookup → version → search → create → update (still one object), and a record carrying a bsn is rejected by the schema. ADR-0028 records both.	2026-08-14 09:41:00 +02:00
not	43b45ad756	fix(acl): read each objecttype version instead of the versions collection (refs #149 ) The version resolve assumed `GET {objecttype}/versions` returns a bare list. Every other collection in the Objecttypen API returns a paginated envelope, and nothing in the repo exercises that endpoint, so the shape was a guess. Follow the path infra/registerrecord-check.py already proves against the real API instead: read the `versions` URLs off the objecttype and fetch each for its status. Costs a request per version, once per gateway instance. ACL mutation score 92.23% (baseline 91.37%).	2026-08-14 09:33:15 +02:00
not	5502e4c099	test(acl): raise the Objecten gateway above the mutation ratchet (refs #149 ) The new gateway landed at 77.6%, dragging the ACL score under its 90 break threshold. The gaps were all real behaviour nobody was asserting: a failed or empty read being mistaken for "nothing there yet" and followed by a blind write, a `results`-less response taking down the resolve with an ArgumentNullException, the CRS headers going to Objecttypen (which is not a geo API), and the write body being sent chunked. ACL score 86.63% → 92.08%.	2026-08-14 09:29:03 +02:00
not	3705a18e18	docs: ADR-0028 + demo note — Objecten holds the register (refs #149 ) ADR-0028 records why the register record lives in Objecten rather than as zaak eigenschappen, why the ACL owns the hop, and how two non-atomic writes are made to converge instead. Also retires the PRD §15 out-of-scope line the slice supersedes.	2026-08-14 09:23:41 +02:00
not	400bdcafc4	test(infra): assert the approval wrote the register record to Objecten (refs #149 ) verify-domain already drives a full approval; it now also asserts Objecten holds exactly one RegisterRecord for that registration — matched on its own reference, because the shared verify stack carries records from earlier runs. The check covers the three things that can silently go wrong: the record is missing (the ACL's Objecten hop never ran), duplicated (the upsert is not idempotent), or carries a field outside the public-safe schema.	2026-08-14 09:22:09 +02:00
not	c67ee7d3f5	refactor(acl): resolve the objecttype's highest published version (refs #149 ) Counting the `versions` URLs assumed a contiguous, all-published list. Read the objecttype's versions collection instead and take the highest one whose status is `published`, so a draft version — whose schema is still being shaped — is never written against.	2026-08-14 09:19:50 +02:00
not	d14f379358	feat(acl): write the RegisterRecord to Objecten on approval (refs #149 ) ApproveZaakAsync now does two writes: the ZGW eindstatus (the process) and the register record in Objecten (the register). The record is keyed on the zaak UUID — the same key the read projection rows carry — and its reference is the zaak's identificatie, so nothing personal crosses into the world-readable register (ADR-0027). ObjectenGateway resolves the objecttype by name (its URL and version are assigned at seed time, as with ADR-0021), searches for an existing object by data attribute, then POSTs or PATCHes. Resolution is lazy, so the ACL needs no depends_on on Objecten and does not crash-loop when it boots first.	2026-08-14 09:18:34 +02:00
not	66f8322580	test(acl): approval writes the RegisterRecord to Objecten (refs #149 ) Ports and failing tests for the Objecten hop, ahead of the implementation: - IRegisterRecordGateway + RegisterRecord — the Application-side port; the record mirrors the objecttype schema registered in S-18c (ADR-0027). - AclService takes the port but does not yet call it, so the approval test fails on an empty upsert list. - ObjectenGateway is a shell throwing NotImplementedException; its tests pin the contract: resolve the objecttype by name, search by data attribute, POST when absent / PATCH when present, static Token auth per API, the CRS headers the geo API requires, and a surfaced error body. Also splits S-19 (#20) into #149/#150 in BACKLOG.md — the approval-side write and the projection re-sourcing are independently deployable (CLAUDE.md §13).	2026-08-14 09:16:23 +02:00

Compare commits

Diff Content Not Available