- Domain/Documents: server-owned category config per wizard + authoritative
type/size validation (DocumentRules).
- Data/DocumentStore: in-memory metadata store (no file bytes/PII) + audit log;
user delete (owner-scoped, 409 once linked), admin delete (role seam via
X-Admin header), link-on-submit, poll-by-localId status.
- Program.cs: GET /uploads/categories, POST /uploads (multipart, excluded from
OpenAPI — hand-written on FE), GET /uploads/status, DELETE /uploads/{id},
DELETE /admin/uploads/{id}. Submit links digital docs + records post-delivery.
- Contracts extended (DocumentRefDto on registratie/herregistratie submit);
regenerated NSwag client + swagger.json (drift check stays green).
- Tests: 16 new (endpoints + DocumentRules); dotnet test 44/44.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
154 lines
5.1 KiB
C#
154 lines
5.1 KiB
C#
using BigRegister.Domain.Diplomas;
|
|
using BigRegister.Domain.Documents;
|
|
using BigRegister.Domain.Registrations;
|
|
using BigRegister.Domain.Submissions;
|
|
|
|
namespace BigRegister.Tests;
|
|
|
|
public class DocumentRuleTests
|
|
{
|
|
[Fact]
|
|
public void Rejects_unknown_category() =>
|
|
Assert.NotNull(DocumentRules.RejectUpload(null, "application/pdf", 1));
|
|
|
|
[Fact]
|
|
public void Rejects_disallowed_type()
|
|
{
|
|
var c = DocumentRules.Find("registratie", "diploma");
|
|
Assert.NotNull(DocumentRules.RejectUpload(c, "text/plain", 1));
|
|
}
|
|
|
|
[Fact]
|
|
public void Rejects_oversized_file()
|
|
{
|
|
var c = DocumentRules.Find("registratie", "diploma");
|
|
Assert.NotNull(DocumentRules.RejectUpload(c, "application/pdf", 11L * 1024 * 1024));
|
|
}
|
|
|
|
[Fact]
|
|
public void Accepts_valid_file()
|
|
{
|
|
var c = DocumentRules.Find("registratie", "diploma");
|
|
Assert.Null(DocumentRules.RejectUpload(c, "application/pdf", 5L * 1024 * 1024));
|
|
}
|
|
}
|
|
|
|
public class HerregistratieRuleTests
|
|
{
|
|
private static Registration Active(DateOnly deadline) => new(
|
|
"19012345601", "Test", "Arts",
|
|
new DateOnly(2012, 9, 1), new DateOnly(1985, 3, 14),
|
|
new RegistrationStatus(StatusTag.Geregistreerd, HerregistratieDatum: deadline));
|
|
|
|
[Fact]
|
|
public void Eligible_within_window()
|
|
{
|
|
var (eligible, reason) = HerregistratieRule.Evaluate(
|
|
Active(new DateOnly(2027, 3, 1)), today: new DateOnly(2026, 6, 26));
|
|
Assert.True(eligible);
|
|
Assert.Contains("12 maanden", reason);
|
|
}
|
|
|
|
[Fact]
|
|
public void Not_eligible_before_window()
|
|
{
|
|
var (eligible, _) = HerregistratieRule.Evaluate(
|
|
Active(new DateOnly(2027, 3, 1)), today: new DateOnly(2025, 1, 1));
|
|
Assert.False(eligible);
|
|
}
|
|
|
|
[Fact]
|
|
public void Eligible_on_window_boundary()
|
|
{
|
|
// window opens exactly 12 months before the deadline
|
|
var (eligible, _) = HerregistratieRule.Evaluate(
|
|
Active(new DateOnly(2027, 3, 1)), today: new DateOnly(2026, 3, 1));
|
|
Assert.True(eligible);
|
|
}
|
|
|
|
[Fact]
|
|
public void Suspended_is_not_eligible()
|
|
{
|
|
var reg = Active(new DateOnly(2027, 3, 1)) with
|
|
{
|
|
Status = new RegistrationStatus(StatusTag.Geschorst, GeschorstTot: new DateOnly(2027, 1, 1), Reden: "x"),
|
|
};
|
|
var (eligible, _) = HerregistratieRule.Evaluate(reg, today: new DateOnly(2026, 6, 26));
|
|
Assert.False(eligible);
|
|
}
|
|
|
|
[Fact]
|
|
public void Status_consistency_invariant()
|
|
{
|
|
Assert.True(HerregistratieRule.IsStatusConsistent(
|
|
new RegistrationStatus(StatusTag.Geregistreerd, HerregistratieDatum: new DateOnly(2027, 3, 1))));
|
|
Assert.False(HerregistratieRule.IsStatusConsistent(
|
|
new RegistrationStatus(StatusTag.Geregistreerd)));
|
|
}
|
|
}
|
|
|
|
public class DiplomaRuleTests
|
|
{
|
|
private static Diploma Diploma(string opleiding, bool engelstalig) =>
|
|
new("x", "naam", "instelling", 2011, opleiding, engelstalig);
|
|
|
|
[Theory]
|
|
[InlineData("geneeskunde", "Arts")]
|
|
[InlineData("verpleegkunde", "Verpleegkundige")]
|
|
[InlineData("onbekend-programma", "Onbekend")]
|
|
public void Profession_is_derived_from_program(string opleiding, string expected) =>
|
|
Assert.Equal(expected, DiplomaRules.ProfessionFor(Diploma(opleiding, false)));
|
|
|
|
[Fact]
|
|
public void English_diploma_requires_dutch_proficiency()
|
|
{
|
|
var questions = DiplomaRules.QuestionsFor(Diploma("geneeskunde", engelstalig: true));
|
|
Assert.Single(questions);
|
|
Assert.Equal("nl-taalvaardigheid", questions[0].Id);
|
|
}
|
|
|
|
[Fact]
|
|
public void Dutch_diploma_has_no_policy_questions() =>
|
|
Assert.Empty(DiplomaRules.QuestionsFor(Diploma("geneeskunde", engelstalig: false)));
|
|
|
|
[Fact]
|
|
public void Manual_diploma_gets_maximal_set()
|
|
{
|
|
var questions = DiplomaRules.ManualQuestions();
|
|
Assert.Equal(3, questions.Count);
|
|
Assert.Equal(new[] { "nl-taalvaardigheid", "diploma-erkend", "toelichting" },
|
|
questions.Select(q => q.Id));
|
|
}
|
|
|
|
[Fact]
|
|
public void Manual_professions_match_known_programs() =>
|
|
Assert.Equal(new[] { "Arts", "Verpleegkundige", "Fysiotherapeut", "Apotheker", "Tandarts" },
|
|
DiplomaRules.ManualProfessions());
|
|
}
|
|
|
|
public class SubmissionRuleTests
|
|
{
|
|
[Fact]
|
|
public void Manual_diploma_is_rejected() =>
|
|
Assert.NotNull(SubmissionRules.RejectRegistratie("handmatig"));
|
|
|
|
[Fact]
|
|
public void Duo_diploma_is_accepted() =>
|
|
Assert.Null(SubmissionRules.RejectRegistratie("duo"));
|
|
|
|
[Fact]
|
|
public void Zero_hours_is_rejected() =>
|
|
Assert.NotNull(SubmissionRules.RejectZeroUren(0));
|
|
|
|
[Fact]
|
|
public void Worked_hours_are_accepted() =>
|
|
Assert.Null(SubmissionRules.RejectZeroUren(40));
|
|
|
|
[Theory]
|
|
[InlineData("Lange Voorhout 9", "2514 EA", null)] // valid
|
|
[InlineData("", "2514 EA", "Vul straat en huisnummer in.")]
|
|
[InlineData("Straat 1", "nope", "Voer een geldige postcode in, bijv. 1234 AB.")]
|
|
public void Change_request_is_validated(string straat, string postcode, string? expected) =>
|
|
Assert.Equal(expected, SubmissionRules.RejectChangeRequest(straat, postcode));
|
|
}
|