Niek Otten
9997da8beb
All checks were successful
## What & why Before this change the self-service confirmation and the openbaar register showed **different** identifiers, so a citizen could not look their registration back up (#78). Now both surface the same **reference**: - **domain → ACL (write):** the domain `registrationId` is set as the zaak's `identificatie` on `POST /zaken`. - **event-subscriber → ACL (read):** the subscriber reads the zaak's `identificatie` back through the ACL (§8.1 — only the ACL talks to ZGW) via a new `POST /zaken/reference`, and stores it on the projection row **and** the `processed_notifications` replay log. - **BFF + openbaar:** the public view exposes `id/status/reference` (never bsn/naam) and searches by id or reference; the register's "Referentie" column shows the reference. Storing the reference in the replay log keeps ADR-0008's **rebuild-is-log-only** invariant intact — `/admin/rebuild` reproduces the reference without re-reading the ACL. Decision recorded in **ADR-0012**. ## Definition of Done - [x] Linked issue: #78 - [x] Tests written first; red → green per layer - [x] Unit + acceptance green (`make unit`): domain 49, acl 27, bff 20, event-subscriber 19, acceptance 7 - [x] Frontend lint + test green (`nx run-many -t lint test`) - [x] Mutation ≥ break(90): acl 100%, event-subscriber 100%, bff 100%, domain 98.41% (pre-existing FlowableWorkflowClient baseline, untouched) - [x] e2e extended: confirmation reference == register reference - [x] openapi.json + api-client regenerated (drift guard green) - [x] ADR-0012 added; demo-script note appended - [x] `Acl__BaseUrl` wired for the subscriber in compose closes #78 Reviewed-on: #79
65 lines
2.6 KiB
C#
65 lines
2.6 KiB
C#
using Bff.Api;
|
|
|
|
namespace Bff.Tests;
|
|
|
|
public class OpenbaarProjectionTests
|
|
{
|
|
private static readonly ProjectionEntry[] Sample =
|
|
[
|
|
new("abc-111", "INGEDIEND", Reference: "REG-A", Bsn: "123456782", NaamPlaceholder: "Jan"),
|
|
new("def-222", "INGESCHREVEN", Reference: "REG-B", Bsn: "987654321", NaamPlaceholder: "Piet"),
|
|
];
|
|
|
|
[Fact]
|
|
public void Maps_every_row_to_public_safe_fields_when_no_query()
|
|
{
|
|
var view = OpenbaarProjection.PublicView(Sample, null);
|
|
|
|
Assert.Equal(2, view.Count);
|
|
Assert.Equal("abc-111", view[0].Id);
|
|
Assert.Equal("INGEDIEND", view[0].Status);
|
|
// The public reference (zaak identificatie) is surfaced so it matches the submit confirmation (#78).
|
|
Assert.Equal("REG-A", view[0].Reference);
|
|
}
|
|
|
|
[Fact]
|
|
public void Public_view_exposes_only_id_status_and_reference()
|
|
{
|
|
// OpenbaarEntry structurally carries only public-safe fields — bsn/naam can never leak.
|
|
var props = typeof(OpenbaarEntry).GetProperties().Select(p => p.Name).ToArray();
|
|
Assert.Equal(["Id", "Status", "Reference"], props);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("abc", 1)] // by id
|
|
[InlineData("ABC", 1)] // by id, case-insensitive
|
|
[InlineData("def", 1)] // by id
|
|
[InlineData("zzz", 0)] // no match
|
|
public void Filters_by_id_containing_the_query_case_insensitively(string q, int expected)
|
|
=> Assert.Equal(expected, OpenbaarProjection.PublicView(Sample, q).Count);
|
|
|
|
[Theory]
|
|
[InlineData("REG-A", 1)] // by reference — the citizen's confirmation reference
|
|
[InlineData("reg-a", 1)] // by reference, case-insensitive
|
|
[InlineData("REG", 2)] // both share the prefix
|
|
public void Filters_by_reference_containing_the_query_case_insensitively(string q, int expected)
|
|
=> Assert.Equal(expected, OpenbaarProjection.PublicView(Sample, q).Count);
|
|
|
|
[Fact]
|
|
public void Blank_query_is_treated_as_no_filter()
|
|
{
|
|
Assert.Equal(2, OpenbaarProjection.PublicView(Sample, " ").Count);
|
|
}
|
|
|
|
[Fact]
|
|
public void A_row_without_a_reference_never_matches_a_query()
|
|
{
|
|
// Older rows can have a null reference (the column is additive, #78/ADR-0012). A search must
|
|
// simply not match them — it must not throw and must not treat "no reference" as a match.
|
|
var entries = new[] { new ProjectionEntry("xyz-999", "INGEDIEND", Reference: null, Bsn: null, NaamPlaceholder: null) };
|
|
|
|
Assert.Empty(OpenbaarProjection.PublicView(entries, "REG"));
|
|
Assert.Equal("xyz-999", Assert.Single(OpenbaarProjection.PublicView(entries, "xyz")).Id);
|
|
}
|
|
}
|