not
d5e5fa254c
## What & why `verify-stack` was failing intermittently on the Playwright e2e with `Page crashed` mid-action (`locator.fill`) and 90s timeouts — the run logged **"2 workers"**, i.e. two full `channel: 'chromium'` browsers running alongside the entire compose stack on the 8 GB self-hosted runner. The renderer gets OOM-killed. Tests passed only when a retry happened to run alone. Fix: pin `workers: 1` in `tests/e2e/playwright.config.ts` (there are only two long-running happy-path specs, so serial costs little) and add `--disable-dev-shm-usage`. This removes the memory contention at the source rather than leaning on `retries` (CLAUDE.md §15 — flaky tests are fixed, not retried). Closes #115 ## Definition of Done - [x] Linked Gitea issue (#115). - [ ] Failing test committed first — N/A: the "red" is the observed `verify-stack` e2e crash (`Page crashed`, 2 workers); this changes test-harness config to fix it. Verified green by re-running the e2e (see notes). - [x] Conventional Commit referencing the issue (`refs #115`). - [ ] CI green — the point of the change; `verify-stack` e2e should stop OOM-crashing. - [x] Docs — none needed (test-config only; rationale in an inline comment). - [ ] ADR — N/A. ## Notes for reviewers - One-line-of-behaviour change: `workers: 1` + `--disable-dev-shm-usage`; no product or spec changes. - `Page crashed` is a renderer OOM, not a product defect — the happy path passes when a browser runs alone (the flaky retries already showed this). Single-worker makes that the normal case. - Independent of #110 (that PR fixes `docker-compose.local.yml`; this fixes the CI `verify-stack` e2e). Landing this first unblocks #110's `verify-stack`. Reviewed-on: #116
46 lines
2.5 KiB
TypeScript
46 lines
2.5 KiB
TypeScript
import { defineConfig, devices } from '@playwright/test';
|
||
|
||
// The e2e runs inside the compose network (infra/run-e2e-check.sh); baseURL defaults to the
|
||
// self-service service. Keep timeouts generous — the first navigation triggers the DigiD flow.
|
||
const baseURL = process.env.SELF_SERVICE_URL ?? 'http://self-service';
|
||
// The behandel portal is a second origin the happy path visits (staff approve from the werkbak);
|
||
// it needs the same insecure-origin-as-secure treatment as self-service for the PKCE login (below).
|
||
const behandelURL = process.env.BEHANDEL_URL ?? 'http://behandel';
|
||
|
||
export default defineConfig({
|
||
testDir: '.',
|
||
timeout: 90_000,
|
||
expect: { timeout: 15_000 },
|
||
retries: 1,
|
||
// Run the specs serially. Each spec drives a full `channel: 'chromium'` browser, and the e2e
|
||
// shares an 8 GB runner with the entire compose stack (OpenZaak, NRC, Keycloak, Flowable, 4×
|
||
// Postgres, every service + 3 portals). Two parallel browsers exhaust memory and the renderer is
|
||
// OOM-killed mid-action ("Page crashed") — fixing the flakiness at its source rather than leaning
|
||
// on `retries` (CLAUDE.md §15). Only two long-running happy-path specs, so serial costs little.
|
||
workers: 1,
|
||
reporter: [['list']],
|
||
use: {
|
||
baseURL,
|
||
trace: 'on-first-retry',
|
||
// The portal is served over plain HTTP on a non-localhost origin (http://self-service) inside the
|
||
// compose network, so it is NOT a secure context — and Web Crypto (`crypto.subtle`) is undefined
|
||
// there. angular-auth-oidc-client needs SubtleCrypto to build the PKCE code challenge, so
|
||
// `authorize()` throws and the login redirect never fires (the login form never appears). In
|
||
// production the portal runs behind HTTPS, where this works. Rather than terminate TLS in the
|
||
// throwaway e2e stack, tell Chromium to treat this origin as secure — which faithfully emulates
|
||
// the production HTTPS context. This flag is only honoured by the full Chromium build (new
|
||
// headless), not Playwright's default headless-shell, so pin `channel: 'chromium'`.
|
||
channel: 'chromium',
|
||
launchOptions: {
|
||
args: [
|
||
`--unsafely-treat-insecure-origin-as-secure=${baseURL},${behandelURL}`,
|
||
// Write Chromium's shared memory to /tmp instead of the container's small /dev/shm, so a
|
||
// large DOM/heap can't crash the renderer on the memory-constrained runner (belt-and-braces
|
||
// alongside the single worker above).
|
||
'--disable-dev-shm-usage',
|
||
],
|
||
},
|
||
},
|
||
projects: [{ name: 'chromium', use: { ...devices['Desktop Chrome'] } }],
|
||
});
|