not
d0fb2b3e8c
Closes #132.
Staff logins (behandel + beheer portals) now need a second factor; the citizen realms are unchanged.
**How:** every seeded medewerker carries a TOTP credential, which activates Keycloak's stock *conditional OTP* step in both the browser flow and the direct grant — no custom browser-flow JSON in the export. `CONFIGURE_TOTP` is a default required action so a medewerker added later must enrol first. ADR-0031 records the choice and, explicitly, that the shared fixture secret is a demo posture only.
**Tests (red first, 30c5279):**
- `check_realms.py` asserts the medewerker password-only grant is **refused**, then that password + TOTP succeeds and still carries the `behandelaar` role. It failed with `[MFA NOT ENFORCED]` against the old export.
- The three medewerker e2e logins move to `loginMedewerker()` (`tests/e2e/medewerker-login.ts`), which submits Keycloak's OTP prompt. Both TOTP implementations (Python `hmac`, Node `crypto`) are ~6 lines of RFC 6238 — no new dependency.
Verified locally against Keycloak 26.1: password-only → `invalid_grant`, password + code → 200, and the browser flow's `#otp` prompt accepts a computed code and issues an auth code.
## Definition of Done
- [x] Failing test/verify committed first; implementation makes it pass.
- [x] Conventional Commits referencing the issue (`refs #132`).
- [ ] CI green (verify-stack compose smoke + relevant checks).
- [x] `docker compose up` reaches green health within 3 minutes (Keycloak change is import-time only).
- [x] Docs touched (runbook, synthetic-data, demo-script) + ADR-0031 + demo note.
- [x] Closed by the merging PR (`closes #132`).
🤖 Generated with [Claude Code](https://claude.com/claude-code)Reviewed-on: #158
15 lines
955 B
TypeScript
15 lines
955 B
TypeScript
import { expect, test } from '@playwright/test';
|
|
import { OTP_PERIOD_MS, nextUnusedCounter } from './medewerker-login';
|
|
|
|
// Pure check of the TOTP counter guard in loginMedewerker — no browser, no stack. Keycloak refuses
|
|
// a code it has already accepted (its otpPolicyCodeReusable defaults to false), so two logins as
|
|
// the same medewerker inside one 30-second window must not spend the same counter twice (#132).
|
|
test('a login never spends a TOTP counter this medewerker already used', () => {
|
|
const now = 3 * OTP_PERIOD_MS + 1_000; // 1 second into counter 3
|
|
|
|
expect(nextUnusedCounter(now, -1)).toBe(3); // nothing spent yet → the current counter
|
|
expect(nextUnusedCounter(now, 3)).toBe(4); // the current counter is spent → the next one
|
|
expect(nextUnusedCounter(now, 4)).toBe(5); // two logins already in this window → the one after
|
|
expect(nextUnusedCounter(now + OTP_PERIOD_MS, 3)).toBe(4); // window moved on → current again
|
|
});
|