All checks were successful
## What & why S-14: a beoordeling a behandelaar does not pick up within **14 days** escalates to the **teamlead**. A non-interrupting `P14D` boundary timer on the `Beoordelen` user task fires an external-worker task (`BeoordelingEscaleren`); the domain's escalation worker reassigns the still-open task's candidate group from `behandelaar` to `teamlead`. The task keeps its identity — only who may claim it changes. The escalation-via-external-worker decision is recorded in **ADR-0015** (proposal #98); it upholds §8.2 (the Workflow Client stays the only code that talks to Flowable) and keeps Flowable a stock image. Closes #15 ## Definition of Done - [x] Linked Gitea issue (above). - [x] Failing test committed before the implementation. - [x] Implementation makes the test pass; refactor commit if structure improved. - [x] Conventional Commits referencing the issue (`refs #NN`). - [x] CI green — all Gitea Actions jobs. - [x] `docker compose up` from a fresh clone reaches green health checks within 3 minutes (no new services; escalation is additive to the domain worker). - [x] Docs updated (ADR-0015, demo note). - [x] ADR added (`docs/architecture/adr-0015-beoordeling-escalation.md`). - [x] Demo note in `docs/demo-script.md`. ## How it was built (TDD) - **Workflow Client** (`IBeoordelingEscalatieClient`): acquire `BeoordelingEscaleren` jobs → find the open `Beoordelen` task in the instance → add `teamlead`/remove `behandelaar` candidate group → complete the job. Red → green. - **Escalation drain loop** (`BeoordelingEscalatieProcessor`) + hosted `BeoordelingEscalatiePump`, mirroring the OpenZaak worker. Red → green. - **BPMN**: non-interrupting `P14D` boundary timer on `Beoordelen` → external task → escalation end. - **Both branches** (escalate after timeout; no-op when completed in time) covered by the `Een beoordeling escaleren` acceptance scenarios + Workflow Client unit tests. - **Live integration**: `verify-domain` fires the timer early via Flowable's management API and asserts the reassignment to teamlead. ## Notes for reviewers - Interface segregation: escalation is on `IBeoordelingEscalatieClient`, separate from the OpenZaak worker's `IExternalWorkerClient`. - Reassignment is two REST hops (add teamlead, remove behandelaar); idempotent on redelivery — see ADR-0015 consequences. - Local checks green: domain unit tests (104), acceptance (13), `dotnet format --verify-no-changes`, Release build (0 errors), **domain mutation 96.69%** (break 90). The `run-domain-check.sh` escalation path is CI-verified on verify-stack (local full-stack run is constrained here). - `BeoordelingEscalatiePump` excluded from mutation, mirroring the existing `OpenZaakJobPump` exclusion. Reviewed-on: #99
83 lines
3.3 KiB
C#
83 lines
3.3 KiB
C#
using Big.Application;
|
|
using Big.Infrastructure;
|
|
using Microsoft.Extensions.Logging;
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
|
|
|
namespace Big.Tests;
|
|
|
|
// S-14 (#15): the escalation drain loop. Mirrors OpenZaakJobProcessor — acquire the parked
|
|
// BeoordelingEscaleren jobs, reassign each instance's Beoordelen task to teamlead, then complete the
|
|
// job. A job whose reassignment fails is logged and left un-completed for Flowable to redeliver (§8.6).
|
|
public class BeoordelingEscalatieProcessorTests
|
|
{
|
|
/// <summary>A fake escalation client: scripts the jobs to acquire, records reassignments and
|
|
/// completions, and can be told to throw on reassigning a given instance.</summary>
|
|
private sealed class FakeEscalatieClient(params EscalatieJob[] jobs) : IBeoordelingEscalatieClient
|
|
{
|
|
public int AcquireCount { get; private set; }
|
|
public List<string> Reassigned { get; } = [];
|
|
public List<string> Completed { get; } = [];
|
|
public string? ThrowOnInstance { get; set; }
|
|
|
|
public Task<IReadOnlyList<EscalatieJob>> AcquireBeoordelingEscalatieJobsAsync(int maxJobs, CancellationToken ct = default)
|
|
{
|
|
AcquireCount++;
|
|
return Task.FromResult<IReadOnlyList<EscalatieJob>>(jobs.Take(maxJobs).ToList());
|
|
}
|
|
|
|
public Task ReassignBeoordelingToTeamleadAsync(string processInstanceId, CancellationToken ct = default)
|
|
{
|
|
if (processInstanceId == ThrowOnInstance)
|
|
throw new InvalidOperationException("reassign failed");
|
|
Reassigned.Add(processInstanceId);
|
|
return Task.CompletedTask;
|
|
}
|
|
|
|
public Task CompleteBeoordelingEscalatieJobAsync(string jobId, CancellationToken ct = default)
|
|
{
|
|
Completed.Add(jobId);
|
|
return Task.CompletedTask;
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Acquires_an_escalation_reassigns_to_teamlead_and_completes_the_job()
|
|
{
|
|
var client = new FakeEscalatieClient(new EscalatieJob("job-9", "pi-1"));
|
|
|
|
var acquired = await new BeoordelingEscalatieProcessor(
|
|
client, NullLogger<BeoordelingEscalatieProcessor>.Instance).PumpOnceAsync(5);
|
|
|
|
Assert.Equal(1, acquired);
|
|
Assert.Equal("pi-1", Assert.Single(client.Reassigned));
|
|
Assert.Equal("job-9", Assert.Single(client.Completed));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task A_failing_reassign_is_left_uncompleted_for_flowable_to_redeliver()
|
|
{
|
|
var client = new FakeEscalatieClient(new EscalatieJob("job-9", "pi-1")) { ThrowOnInstance = "pi-1" };
|
|
var logger = new CapturingLogger<BeoordelingEscalatieProcessor>();
|
|
|
|
var acquired = await new BeoordelingEscalatieProcessor(client, logger).PumpOnceAsync(5);
|
|
|
|
Assert.Equal(1, acquired);
|
|
Assert.Empty(client.Completed);
|
|
var error = Assert.Single(logger.Entries, e => e.Level == LogLevel.Error);
|
|
Assert.Contains("job-9", error.Message);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Does_nothing_but_poll_when_there_are_no_escalations()
|
|
{
|
|
var client = new FakeEscalatieClient();
|
|
|
|
var acquired = await new BeoordelingEscalatieProcessor(
|
|
client, NullLogger<BeoordelingEscalatieProcessor>.Instance).PumpOnceAsync(5);
|
|
|
|
Assert.Equal(0, acquired);
|
|
Assert.Equal(1, client.AcquireCount);
|
|
Assert.Empty(client.Completed);
|
|
}
|
|
}
|