Ports and failing tests for the Objecten hop, ahead of the implementation: - IRegisterRecordGateway + RegisterRecord — the Application-side port; the record mirrors the objecttype schema registered in S-18c (ADR-0027). - AclService takes the port but does not yet call it, so the approval test fails on an empty upsert list. - ObjectenGateway is a shell throwing NotImplementedException; its tests pin the contract: resolve the objecttype by name, search by data attribute, POST when absent / PATCH when present, static Token auth per API, the CRS headers the geo API requires, and a surfaced error body. Also splits S-19 (#20) into #149/#150 in BACKLOG.md — the approval-side write and the projection re-sourcing are independently deployable (CLAUDE.md §13).
185 lines
7.9 KiB
C#
185 lines
7.9 KiB
C#
using System.Net;
|
|
using System.Net.Http.Json;
|
|
using Acl.Application;
|
|
using Acl.Infrastructure;
|
|
|
|
namespace Acl.Tests;
|
|
|
|
public class ObjectenGatewayTests
|
|
{
|
|
private sealed class StubHandler(Func<HttpRequestMessage, Task<HttpResponseMessage>> onSend)
|
|
: HttpMessageHandler
|
|
{
|
|
protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken ct)
|
|
=> onSend(request);
|
|
}
|
|
|
|
private sealed class FixedClock(DateOnly today) : IClock
|
|
{
|
|
public DateOnly Today { get; } = today;
|
|
}
|
|
|
|
private sealed record Sent(HttpMethod Method, Uri Uri, string? Body, string? Auth, string? ContentCrs, string? AcceptCrs);
|
|
|
|
private const string ObjecttypeUrl = "http://objecttypen:8000/api/v2/objecttypes/ot-1";
|
|
|
|
private static ObjectenGateway Gateway(List<Sent> sent, Func<HttpRequestMessage, HttpResponseMessage> respond) =>
|
|
new(
|
|
new HttpClient(new StubHandler(async req =>
|
|
{
|
|
sent.Add(new Sent(
|
|
req.Method,
|
|
req.RequestUri!,
|
|
req.Content is null ? null : await req.Content.ReadAsStringAsync(),
|
|
req.Headers.Authorization?.ToString(),
|
|
req.Content?.Headers.TryGetValues("Content-Crs", out var c) == true ? string.Join(",", c!) : null,
|
|
req.Headers.TryGetValues("Accept-Crs", out var a) ? string.Join(",", a) : null));
|
|
return respond(req);
|
|
})),
|
|
new ObjectenOptions
|
|
{
|
|
BaseUrl = new("http://objecten:8000"),
|
|
Token = "objecten-token",
|
|
ObjecttypenBaseUrl = new("http://objecttypen:8000"),
|
|
ObjecttypenToken = "objecttypen-token",
|
|
ObjecttypeName = "RegisterRecord",
|
|
},
|
|
new FixedClock(new DateOnly(2026, 6, 4)));
|
|
|
|
// The Objecttypen lookup (by name) and the Objecten search (by data attribute) that precede every
|
|
// write. `respondToWrite` decides what the POST/PATCH returns.
|
|
private static HttpResponseMessage Route(HttpRequestMessage req, object[] existingObjects) =>
|
|
req.RequestUri!.AbsolutePath.StartsWith("/api/v2/objecttypes", StringComparison.Ordinal)
|
|
? new HttpResponseMessage(HttpStatusCode.OK)
|
|
{
|
|
Content = JsonContent.Create(new
|
|
{
|
|
results = new[]
|
|
{
|
|
new { url = "http://objecttypen:8000/api/v2/objecttypes/other", name = "SomethingElse", versions = new[] { "…/versions/1" } },
|
|
new { url = ObjecttypeUrl, name = "RegisterRecord", versions = new[] { "…/versions/1", "…/versions/2" } },
|
|
},
|
|
}),
|
|
}
|
|
: req.Method == HttpMethod.Get
|
|
? new HttpResponseMessage(HttpStatusCode.OK) { Content = JsonContent.Create(new { results = existingObjects }) }
|
|
: new HttpResponseMessage(HttpStatusCode.Created) { Content = JsonContent.Create(new { url = "http://objecten:8000/api/v2/objects/obj-1" }) };
|
|
|
|
private static RegisterRecord Record() => new("zaak-uuid-1", RegisterRecordStatus.Ingeschreven, "REG-2026-0001");
|
|
|
|
[Fact]
|
|
public async Task Creates_the_object_when_none_exists_for_the_registration()
|
|
{
|
|
var sent = new List<Sent>();
|
|
|
|
await Gateway(sent, req => Route(req, [])).UpsertAsync(Record());
|
|
|
|
var write = sent.Single(s => s.Method == HttpMethod.Post && s.Uri.AbsolutePath == "/api/v2/objects");
|
|
Assert.Contains($"\"type\":\"{ObjecttypeUrl}\"", write.Body);
|
|
Assert.Contains("\"typeVersion\":2", write.Body);
|
|
Assert.Contains("\"id\":\"zaak-uuid-1\"", write.Body);
|
|
Assert.Contains("\"status\":\"INGESCHREVEN\"", write.Body);
|
|
Assert.Contains("\"reference\":\"REG-2026-0001\"", write.Body);
|
|
Assert.Contains("\"startAt\":\"2026-06-04\"", write.Body);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Updates_the_existing_object_instead_of_creating_a_second_one()
|
|
{
|
|
var sent = new List<Sent>();
|
|
object[] existing = [new { uuid = "obj-9", url = "http://objecten:8000/api/v2/objects/obj-9" }];
|
|
|
|
await Gateway(sent, req => Route(req, existing)).UpsertAsync(Record());
|
|
|
|
Assert.DoesNotContain(sent, s => s.Method == HttpMethod.Post && s.Uri.AbsolutePath == "/api/v2/objects");
|
|
var write = sent.Single(s => s.Method == HttpMethod.Patch);
|
|
Assert.Equal("http://objecten:8000/api/v2/objects/obj-9", write.Uri.ToString());
|
|
Assert.Contains("\"status\":\"INGESCHREVEN\"", write.Body);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Searches_objecten_for_the_registration_id_within_the_objecttype()
|
|
{
|
|
var sent = new List<Sent>();
|
|
|
|
await Gateway(sent, req => Route(req, [])).UpsertAsync(Record());
|
|
|
|
var search = sent.Single(s => s.Method == HttpMethod.Get && s.Uri.AbsolutePath == "/api/v2/objects");
|
|
Assert.Contains("type=" + Uri.EscapeDataString(ObjecttypeUrl), search.Uri.Query);
|
|
Assert.Contains("data_attrs=id__exact__zaak-uuid-1", search.Uri.Query);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Authenticates_with_the_static_token_of_each_api()
|
|
{
|
|
var sent = new List<Sent>();
|
|
|
|
await Gateway(sent, req => Route(req, [])).UpsertAsync(Record());
|
|
|
|
Assert.All(
|
|
sent.Where(s => s.Uri.AbsolutePath.StartsWith("/api/v2/objecttypes", StringComparison.Ordinal)),
|
|
s => Assert.Equal("Token objecttypen-token", s.Auth));
|
|
Assert.All(
|
|
sent.Where(s => s.Uri.AbsolutePath.StartsWith("/api/v2/objects", StringComparison.Ordinal)),
|
|
s => Assert.Equal("Token objecten-token", s.Auth));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Sends_the_geo_crs_headers_the_objecten_api_requires()
|
|
{
|
|
var sent = new List<Sent>();
|
|
|
|
await Gateway(sent, req => Route(req, [])).UpsertAsync(Record());
|
|
|
|
var objects = sent.Where(s => s.Uri.AbsolutePath.StartsWith("/api/v2/objects", StringComparison.Ordinal)).ToList();
|
|
Assert.All(objects, s => Assert.Equal("EPSG:4326", s.AcceptCrs));
|
|
Assert.All(objects.Where(s => s.Body is not null), s => Assert.Equal("EPSG:4326", s.ContentCrs));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Resolves_the_objecttype_once_and_reuses_it_across_writes()
|
|
{
|
|
var sent = new List<Sent>();
|
|
var gateway = Gateway(sent, req => Route(req, []));
|
|
|
|
await gateway.UpsertAsync(Record());
|
|
await gateway.UpsertAsync(Record() with { Id = "zaak-uuid-2" });
|
|
|
|
Assert.Single(sent, s => s.Uri.AbsolutePath.StartsWith("/api/v2/objecttypes", StringComparison.Ordinal));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Fails_loudly_when_the_objecttype_is_not_registered()
|
|
{
|
|
var sent = new List<Sent>();
|
|
var gateway = Gateway(sent, _ => new HttpResponseMessage(HttpStatusCode.OK)
|
|
{
|
|
Content = JsonContent.Create(new { results = Array.Empty<object>() }),
|
|
});
|
|
|
|
var error = await Assert.ThrowsAsync<InvalidOperationException>(() => gateway.UpsertAsync(Record()));
|
|
Assert.Contains("RegisterRecord", error.Message);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Surfaces_the_objecten_error_body_when_a_write_is_rejected()
|
|
{
|
|
var sent = new List<Sent>();
|
|
var gateway = Gateway(sent, req => req.Method == HttpMethod.Post && req.RequestUri!.AbsolutePath == "/api/v2/objects"
|
|
? new HttpResponseMessage(HttpStatusCode.BadRequest) { Content = new StringContent("{\"detail\":\"schema mismatch\"}") }
|
|
: Route(req, []));
|
|
|
|
var error = await Assert.ThrowsAsync<HttpRequestException>(() => gateway.UpsertAsync(Record()));
|
|
Assert.Contains("schema mismatch", error.Message);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Rejects_a_null_record_without_calling_objecten()
|
|
{
|
|
var sent = new List<Sent>();
|
|
|
|
await Assert.ThrowsAsync<ArgumentNullException>(() => Gateway(sent, req => Route(req, [])).UpsertAsync(null!));
|
|
Assert.Empty(sent);
|
|
}
|
|
}
|