not
4fe9915816
## What & why
S-17: a BIG inscription is valid for a fixed term; before it lapses the zorgprofessional must herregistreren. This adds a **daily herregistratie reminder sweep**.
- **Domain:** `Approve(ingeschrevenOp)` now stamps the inscription moment; `HerregistratieVoor` derives the deadline (inscription + 5-year validity); `HerregistratieReminderDue(asOf)` is the single rule (inside the 90-day window, inscribed, not yet reminded); `MarkHerregistratieReminderVerstuurd()` is idempotent.
- **Store:** `FindDueForHerregistratieReminderAsync(asOf)` — the sweep's candidate set, filtered on the aggregate's own rule (no duplicated policy).
- **Application:** `HerregistratieReminderSweep` — pure over the store + an injected `TimeProvider`; flags + persists each due inscription, returns the reminded ids.
- **Infra/API:** `HerregistratieReminderJob` (Quartz `IJob`) fires the sweep on a daily cron (03:00, overridable via `Quartz__Cron`) and logs the count. `GET /registrations/{id}` surfaces `herregistratieVoor` + `herregistratieReminderVerstuurd`.
**Decisions (both raised with you before coding):** use Quartz.NET as the PRD names it — a genuine cron concern, distinct from the queue-draining pumps, which stay as-is (**ADR-0022**, proposal #120); and the reminder's observable effect is a flag on the aggregate + a log line (no outbound notification infra in v1). No coupling rule (§8) is touched — Quartz is internal to the Domain Service.
Closes #18
Closes #120
## Definition of Done
- [x] Linked Gitea issue (above).
- [x] Failing test committed before the implementation (red→green per layer: domain rule, store query, sweep).
- [x] Implementation makes the test pass; refactor commit for the 90-day knob.
- [x] Conventional Commits referencing the issue (`refs #18`).
- [ ] CI green — awaiting Gitea Actions.
- [ ] `docker compose up` reaches green health checks within 3 minutes — API boots locally with Quartz initialised; verified in CI compose smoke.
- [x] Docs updated — ADR-0022, demo-script, BACKLOG.
- [x] ADR added — `docs/architecture/adr-0022-quartz-scheduler.md`.
- [x] Demo note in `docs/demo-script.md`.
## Notes for reviewers
- **Ripple:** `Approve()` gained the inscription moment, so the two approving handlers (`ApproveRegistration`, `BeoordeelRegistratie`) now take an injected `TimeProvider`; existing tests pass a fixed clock. All three `IRegistrationStore` implementers (prod, unit fake, acceptance) got the new query.
- **Calibration knobs:** validity (5y) and reminder lead time (90d) are domain constants marked with `ponytail:` comments; promotion path to beheer config (S-15) noted in the ADR.
- **Mutation:** the Quartz job shell is excluded from Stryker, mirroring the pumps; all rule/sweep/query logic is covered.
- Local: 152 domain unit tests green; API boots with the Quartz scheduler and `/health` green.
Reviewed-on: #121
72 lines
3.4 KiB
C#
72 lines
3.4 KiB
C#
using Big.Domain;
|
|
|
|
namespace Big.Application;
|
|
|
|
/// <summary>A behandelaar's beoordeling outcome, in domain language.</summary>
|
|
public enum BeoordelingsBesluit
|
|
{
|
|
/// <summary>Approve — enter the registration in the register.</summary>
|
|
Goedkeuren,
|
|
|
|
/// <summary>Reject — turn the registration down.</summary>
|
|
Afwijzen,
|
|
}
|
|
|
|
/// <summary>A behandelaar's decision on a registration.</summary>
|
|
public sealed record BeoordeelRegistratieCommand(RegistrationId RegistrationId, BeoordelingsBesluit Besluit);
|
|
|
|
/// <summary>
|
|
/// The beoordeling use case (S-12): apply a behandelaar's decision to a registration.
|
|
/// <see cref="BeoordelingsBesluit.Goedkeuren"/> sets the zaak's final status via the ACL (§8.1) and
|
|
/// advances the aggregate to INGESCHREVEN; <see cref="BeoordelingsBesluit.Afwijzen"/> advances it to
|
|
/// AFGEWEZEN in the domain (propagating a rejection to the zaak, so the openbaar projection reflects
|
|
/// it, is a later sub-slice of S-12). After applying the decision it completes the Flowable
|
|
/// <c>Beoordelen</c> task (found by registrationId) so the workflow advances (ADR-0013). Both
|
|
/// decisions are idempotent — a repeated or redelivered decision that matches the current terminal
|
|
/// state is a no-op, so the ACL is not called and the task not completed twice.
|
|
/// </summary>
|
|
public sealed class BeoordeelRegistratie(IRegistrationStore store, IAclClient acl, IUserTaskClient tasks, TimeProvider clock)
|
|
{
|
|
public async Task HandleAsync(BeoordeelRegistratieCommand command, CancellationToken ct = default)
|
|
{
|
|
ArgumentNullException.ThrowIfNull(command);
|
|
|
|
var registration = await store.GetAsync(command.RegistrationId, ct)
|
|
?? throw new InvalidOperationException($"No registration {command.RegistrationId} to decide.");
|
|
|
|
switch (command.Besluit)
|
|
{
|
|
case BeoordelingsBesluit.Goedkeuren:
|
|
// A repeated approval is a no-op: don't set the zaak status a second time.
|
|
if (registration.Status == RegistrationStatus.Ingeschreven)
|
|
return;
|
|
if (registration.ZaakUrl is null)
|
|
throw new InvalidOperationException(
|
|
$"Registration {command.RegistrationId} has no zaak yet; it cannot be approved.");
|
|
await acl.ApproveZaakAsync(registration.ZaakUrl, ct);
|
|
registration.Approve(clock.GetUtcNow());
|
|
break;
|
|
|
|
case BeoordelingsBesluit.Afwijzen:
|
|
if (registration.Status == RegistrationStatus.Afgewezen)
|
|
return;
|
|
registration.Reject();
|
|
break;
|
|
}
|
|
|
|
await store.SaveAsync(registration, ct);
|
|
await CompleteWorkflowTaskAsync(command.RegistrationId, command.Besluit, ct);
|
|
}
|
|
|
|
// Advance the workflow: complete the open Beoordelen task for this registration. If none is open
|
|
// (already completed, or the process hasn't parked yet) the decision still stands — we complete
|
|
// nothing rather than fail.
|
|
private async Task CompleteWorkflowTaskAsync(RegistrationId registrationId, BeoordelingsBesluit besluit, CancellationToken ct)
|
|
{
|
|
var open = await tasks.GetOpenBeoordelingenAsync(ct);
|
|
var task = open.FirstOrDefault(t => t.RegistrationId == registrationId);
|
|
if (task is not null)
|
|
await tasks.CompleteBeoordelingAsync(task.TaskId, besluit, ct);
|
|
}
|
|
}
|