## What & why S-10a, the **workflow/timeout spine** of the (split) document-upload slice: the registratie process now parks at a **`WachtOpDocumenten`** user task with an **interrupting `P30D` boundary timer**. When the documents arrive the task completes and the process continues into the diploma routing (S-13) → Beoordelen; if the 30 days lapse, the timer cancels the wait, runs a `RegistratieVerlopen` external-worker task, and the domain expires the aggregate to a new terminal status **`Verlopen`**. Backend only — the real upload trigger (portal → BFF → ACL → Documenten API) is S-10b (#103). Closes #102 Mechanism recorded in **ADR-0017**; opened as proposal #104. Mirrors the S-14 escalation (boundary-timer + external-worker) and S-11 withdrawal (interrupting cancel) patterns. ## Definition of Done - [x] Linked Gitea issue (above). - [x] Failing test committed before the implementation (red→green pairs per layer). - [x] Implementation makes the test pass. - [x] Conventional Commits referencing the issue (`refs #102`). - [ ] CI green — all Gitea Actions jobs (pending on this PR). - [x] `docker compose up` health unaffected (no new services; deploy path unchanged). - [x] Docs updated (ADR-0017, demo-script, BACKLOG split). - [x] ADR added (`docs/architecture/adr-0017-document-wait-timeout-cancellation.md`). - [x] Demo note in `docs/demo-script.md`. ## Notes for reviewers - **Domain** (`Registration.Expire()` + `Verlopen`), **application** (`ExpireRegistrationWorker`), **infra** (`RegistratieVerlopenProcessor`/`Pump`, `IRegistratieVerlopenClient`, Flowable acquire/complete + `CompleteDocumentWaitAsync`) — the timeout counterpart to the OpenZaak/escalation worker trios; idempotent per §8.6. - **BPMN** verified live against a `flowable-rest` probe: complete `WachtOpDocumenten` → routes to Beoordelen; fire the P30D timer → `RegistratieVerlopen` job (carrying `registrationId`) + the wait task cancelled. `verify-domain` exercises both branches in-stack (completes the wait in every existing block; fires the timer and asserts `Verlopen` in a new block). - **Scope boundary:** on expiry the aggregate goes `Verlopen` and the process ends, but the ZGW *zaak* is not yet set to a cancellation status — that needs a new ACL method + statustype seeding and is folded into S-10b (noted in ADR-0017). - `CompleteDocumentWaitAsync` is built and HTTP-tested here but not yet called from a domain endpoint; S-10b wires the upload trigger to it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Reviewed-on: #105
86 lines
3.4 KiB
C#
86 lines
3.4 KiB
C#
using Big.Application;
|
|
using Big.Domain;
|
|
|
|
namespace Big.Tests;
|
|
|
|
// S-10a (#102): the "documents received" use case. A zorgprofessional supplies the documents their
|
|
// registration is waiting for; the handler completes the WachtOpDocumenten task via the Workflow Client
|
|
// so the process leaves the 30-day wait and continues to beoordeling. Owner-scoped by the caller's bsn,
|
|
// like WithdrawRegistration. (The real file upload + ZGW storage is S-10b; this is the trigger path.)
|
|
public class ProvideDocumentsTests
|
|
{
|
|
private const string Bsn = "123456782";
|
|
|
|
private static Registration Submitted(string processInstanceId = "proc-1")
|
|
{
|
|
var registration = Registration.Submit(Bsn);
|
|
registration.RecordProcessStarted(processInstanceId);
|
|
return registration;
|
|
}
|
|
|
|
private static ProvideDocumentsCommand Command(RegistrationId id, string bsn = Bsn) => new(id, bsn);
|
|
|
|
[Fact]
|
|
public async Task Providing_documents_completes_the_document_wait()
|
|
{
|
|
var store = new FakeRegistrationStore();
|
|
var registration = Submitted("proc-42");
|
|
store.Seed(registration);
|
|
var workflow = new FakeWorkflowClient();
|
|
var handler = new ProvideDocuments(store, workflow);
|
|
|
|
var outcome = await handler.HandleAsync(Command(registration.Id));
|
|
|
|
Assert.Equal(ProvideDocumentsOutcome.Accepted, outcome);
|
|
Assert.Equal("proc-42", workflow.CompletedDocumentWaitFor);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task A_different_bsn_cannot_provide_documents()
|
|
{
|
|
// Owner-scoping: only the registration's own bsn may supply its documents. Another bsn is told
|
|
// NotFound (existence not revealed) and the wait is not completed.
|
|
var store = new FakeRegistrationStore();
|
|
var registration = Submitted();
|
|
store.Seed(registration);
|
|
var workflow = new FakeWorkflowClient();
|
|
var handler = new ProvideDocuments(store, workflow);
|
|
|
|
var outcome = await handler.HandleAsync(Command(registration.Id, bsn: "999999990"));
|
|
|
|
Assert.Equal(ProvideDocumentsOutcome.NotFound, outcome);
|
|
Assert.Null(workflow.CompletedDocumentWaitFor);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Providing_for_an_unknown_registration_is_not_found()
|
|
{
|
|
var store = new FakeRegistrationStore();
|
|
var handler = new ProvideDocuments(store, new FakeWorkflowClient());
|
|
|
|
Assert.Equal(ProvideDocumentsOutcome.NotFound, await handler.HandleAsync(Command(RegistrationId.New())));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Providing_before_a_process_started_is_accepted_without_calling_the_workflow()
|
|
{
|
|
// No process yet → no wait task to complete; the request still stands (best-effort, mirroring
|
|
// WithdrawRegistration) and the Workflow Client is not called.
|
|
var store = new FakeRegistrationStore();
|
|
var registration = Registration.Submit(Bsn); // no RecordProcessStarted
|
|
store.Seed(registration);
|
|
var workflow = new FakeWorkflowClient();
|
|
var handler = new ProvideDocuments(store, workflow);
|
|
|
|
var outcome = await handler.HandleAsync(Command(registration.Id));
|
|
|
|
Assert.Equal(ProvideDocumentsOutcome.Accepted, outcome);
|
|
Assert.Null(workflow.CompletedDocumentWaitFor);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Rejects_a_null_command()
|
|
=> await Assert.ThrowsAsync<ArgumentNullException>(() =>
|
|
new ProvideDocuments(new FakeRegistrationStore(), new FakeWorkflowClient()).HandleAsync(null!));
|
|
}
|