## What & why S-10a, the **workflow/timeout spine** of the (split) document-upload slice: the registratie process now parks at a **`WachtOpDocumenten`** user task with an **interrupting `P30D` boundary timer**. When the documents arrive the task completes and the process continues into the diploma routing (S-13) → Beoordelen; if the 30 days lapse, the timer cancels the wait, runs a `RegistratieVerlopen` external-worker task, and the domain expires the aggregate to a new terminal status **`Verlopen`**. Backend only — the real upload trigger (portal → BFF → ACL → Documenten API) is S-10b (#103). Closes #102 Mechanism recorded in **ADR-0017**; opened as proposal #104. Mirrors the S-14 escalation (boundary-timer + external-worker) and S-11 withdrawal (interrupting cancel) patterns. ## Definition of Done - [x] Linked Gitea issue (above). - [x] Failing test committed before the implementation (red→green pairs per layer). - [x] Implementation makes the test pass. - [x] Conventional Commits referencing the issue (`refs #102`). - [ ] CI green — all Gitea Actions jobs (pending on this PR). - [x] `docker compose up` health unaffected (no new services; deploy path unchanged). - [x] Docs updated (ADR-0017, demo-script, BACKLOG split). - [x] ADR added (`docs/architecture/adr-0017-document-wait-timeout-cancellation.md`). - [x] Demo note in `docs/demo-script.md`. ## Notes for reviewers - **Domain** (`Registration.Expire()` + `Verlopen`), **application** (`ExpireRegistrationWorker`), **infra** (`RegistratieVerlopenProcessor`/`Pump`, `IRegistratieVerlopenClient`, Flowable acquire/complete + `CompleteDocumentWaitAsync`) — the timeout counterpart to the OpenZaak/escalation worker trios; idempotent per §8.6. - **BPMN** verified live against a `flowable-rest` probe: complete `WachtOpDocumenten` → routes to Beoordelen; fire the P30D timer → `RegistratieVerlopen` job (carrying `registrationId`) + the wait task cancelled. `verify-domain` exercises both branches in-stack (completes the wait in every existing block; fires the timer and asserts `Verlopen` in a new block). - **Scope boundary:** on expiry the aggregate goes `Verlopen` and the process ends, but the ZGW *zaak* is not yet set to a cancellation status — that needs a new ACL method + statustype seeding and is folded into S-10b (noted in ADR-0017). - `CompleteDocumentWaitAsync` is built and HTTP-tested here but not yet called from a domain endpoint; S-10b wires the upload trigger to it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Reviewed-on: #105
85 lines
3.2 KiB
C#
85 lines
3.2 KiB
C#
using Big.Application;
|
|
using Big.Domain;
|
|
|
|
namespace Big.Tests;
|
|
|
|
// S-10a (#102): the application handler behind the RegistratieVerlopen external-worker job. The 30-day
|
|
// document-wait timer fired, so the correlated registration is expired to VERLOPEN. Mirrors
|
|
// OpenZaakWorker — pure application logic over ports, idempotent under at-least-once delivery (§8.6).
|
|
public class ExpireRegistrationWorkerTests
|
|
{
|
|
private const string Bsn = "123456782";
|
|
|
|
private static Registration Submitted(string processInstanceId = "proc-1")
|
|
{
|
|
var registration = Registration.Submit(Bsn);
|
|
registration.RecordProcessStarted(processInstanceId);
|
|
return registration;
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Expires_the_registration_the_job_correlates_to()
|
|
{
|
|
var store = new FakeRegistrationStore();
|
|
var registration = Submitted();
|
|
store.Seed(registration);
|
|
|
|
await new ExpireRegistrationWorker(store).HandleAsync(
|
|
new RegistratieVerlopenJob("job-7", registration.Id));
|
|
|
|
var saved = await store.GetAsync(registration.Id);
|
|
Assert.Equal(RegistrationStatus.Verlopen, saved!.Status);
|
|
Assert.Equal(1, store.SaveCount);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task An_already_verlopen_registration_is_not_persisted_again()
|
|
{
|
|
// A redelivered job (§8.6) finds the aggregate already VERLOPEN: a no-op, not saved again.
|
|
var store = new FakeRegistrationStore();
|
|
var registration = Submitted();
|
|
registration.Expire();
|
|
store.Seed(registration);
|
|
|
|
await new ExpireRegistrationWorker(store).HandleAsync(
|
|
new RegistratieVerlopenJob("job-7", registration.Id));
|
|
|
|
Assert.Equal(0, store.SaveCount);
|
|
Assert.Equal(RegistrationStatus.Verlopen, (await store.GetAsync(registration.Id))!.Status);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task An_already_resolved_registration_is_left_alone_and_the_job_completes()
|
|
{
|
|
// Race with S-11: the citizen withdrew while parked at WachtOpDocumenten, so the aggregate is
|
|
// already terminal (INGETROKKEN) when the timer's job arrives. Expiring it would violate the
|
|
// aggregate's invariant; the worker must instead no-op (and let the job complete), not throw
|
|
// into a redelivery loop.
|
|
var store = new FakeRegistrationStore();
|
|
var registration = Submitted();
|
|
registration.Withdraw();
|
|
store.Seed(registration);
|
|
|
|
await new ExpireRegistrationWorker(store).HandleAsync(
|
|
new RegistratieVerlopenJob("job-7", registration.Id));
|
|
|
|
Assert.Equal(0, store.SaveCount);
|
|
Assert.Equal(RegistrationStatus.Ingetrokken, (await store.GetAsync(registration.Id))!.Status);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task An_unknown_registration_throws_so_the_job_is_redelivered()
|
|
{
|
|
var store = new FakeRegistrationStore();
|
|
|
|
await Assert.ThrowsAsync<InvalidOperationException>(() =>
|
|
new ExpireRegistrationWorker(store).HandleAsync(
|
|
new RegistratieVerlopenJob("job-7", RegistrationId.New())));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Rejects_a_null_job()
|
|
=> await Assert.ThrowsAsync<ArgumentNullException>(() =>
|
|
new ExpireRegistrationWorker(new FakeRegistrationStore()).HandleAsync(null!));
|
|
}
|