not
4777ff2b1d
## What & why S-10a, the **workflow/timeout spine** of the (split) document-upload slice: the registratie process now parks at a **`WachtOpDocumenten`** user task with an **interrupting `P30D` boundary timer**. When the documents arrive the task completes and the process continues into the diploma routing (S-13) → Beoordelen; if the 30 days lapse, the timer cancels the wait, runs a `RegistratieVerlopen` external-worker task, and the domain expires the aggregate to a new terminal status **`Verlopen`**. Backend only — the real upload trigger (portal → BFF → ACL → Documenten API) is S-10b (#103). Closes #102 Mechanism recorded in **ADR-0017**; opened as proposal #104. Mirrors the S-14 escalation (boundary-timer + external-worker) and S-11 withdrawal (interrupting cancel) patterns. ## Definition of Done - [x] Linked Gitea issue (above). - [x] Failing test committed before the implementation (red→green pairs per layer). - [x] Implementation makes the test pass. - [x] Conventional Commits referencing the issue (`refs #102`). - [ ] CI green — all Gitea Actions jobs (pending on this PR). - [x] `docker compose up` health unaffected (no new services; deploy path unchanged). - [x] Docs updated (ADR-0017, demo-script, BACKLOG split). - [x] ADR added (`docs/architecture/adr-0017-document-wait-timeout-cancellation.md`). - [x] Demo note in `docs/demo-script.md`. ## Notes for reviewers - **Domain** (`Registration.Expire()` + `Verlopen`), **application** (`ExpireRegistrationWorker`), **infra** (`RegistratieVerlopenProcessor`/`Pump`, `IRegistratieVerlopenClient`, Flowable acquire/complete + `CompleteDocumentWaitAsync`) — the timeout counterpart to the OpenZaak/escalation worker trios; idempotent per §8.6. - **BPMN** verified live against a `flowable-rest` probe: complete `WachtOpDocumenten` → routes to Beoordelen; fire the P30D timer → `RegistratieVerlopen` job (carrying `registrationId`) + the wait task cancelled. `verify-domain` exercises both branches in-stack (completes the wait in every existing block; fires the timer and asserts `Verlopen` in a new block). - **Scope boundary:** on expiry the aggregate goes `Verlopen` and the process ends, but the ZGW *zaak* is not yet set to a cancellation status — that needs a new ACL method + statustype seeding and is folded into S-10b (noted in ADR-0017). - `CompleteDocumentWaitAsync` is built and HTTP-tested here but not yet called from a domain endpoint; S-10b wires the upload trigger to it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Reviewed-on: #105
42 lines
1.7 KiB
C#
42 lines
1.7 KiB
C#
using Big.Application;
|
|
using Microsoft.Extensions.Logging;
|
|
|
|
namespace Big.Infrastructure;
|
|
|
|
/// <summary>
|
|
/// One poll tick of the document-timeout worker (S-10a, ADR-0017): acquire the parked
|
|
/// <c>RegistratieVerlopen</c> jobs — the tokens the 30-day boundary timer on <c>WachtOpDocumenten</c>
|
|
/// spawns — expire each correlated registration via the <see cref="ExpireRegistrationWorker"/>, and
|
|
/// complete the job so its token reaches <c>endVerlopen</c>. A job that fails is logged and left
|
|
/// un-completed so Flowable redelivers it (§8.6). Split out from the hosted pump so the
|
|
/// acquire→expire→complete logic is unit-testable without a running host. Mirrors
|
|
/// <see cref="OpenZaakJobProcessor"/> and <see cref="BeoordelingEscalatieProcessor"/>.
|
|
/// </summary>
|
|
public sealed class RegistratieVerlopenProcessor(
|
|
IRegistratieVerlopenClient client,
|
|
ExpireRegistrationWorker worker,
|
|
ILogger<RegistratieVerlopenProcessor> logger)
|
|
{
|
|
/// <summary>Acquire and process up to <paramref name="maxJobs"/> jobs. Returns the number acquired.</summary>
|
|
public async Task<int> PumpOnceAsync(int maxJobs, CancellationToken ct = default)
|
|
{
|
|
var jobs = await client.AcquireRegistratieVerlopenJobsAsync(maxJobs, ct);
|
|
|
|
foreach (var job in jobs)
|
|
{
|
|
try
|
|
{
|
|
await worker.HandleAsync(job, ct);
|
|
await client.CompleteRegistratieVerlopenJobAsync(job.JobId, ct);
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
// Leave the job un-completed: its lock expires and Flowable redelivers it (§8.6).
|
|
logger.LogError(ex, "RegistratieVerlopen job {JobId} failed; leaving it for redelivery.", job.JobId);
|
|
}
|
|
}
|
|
|
|
return jobs.Count;
|
|
}
|
|
}
|