not
4777ff2b1d
## What & why S-10a, the **workflow/timeout spine** of the (split) document-upload slice: the registratie process now parks at a **`WachtOpDocumenten`** user task with an **interrupting `P30D` boundary timer**. When the documents arrive the task completes and the process continues into the diploma routing (S-13) → Beoordelen; if the 30 days lapse, the timer cancels the wait, runs a `RegistratieVerlopen` external-worker task, and the domain expires the aggregate to a new terminal status **`Verlopen`**. Backend only — the real upload trigger (portal → BFF → ACL → Documenten API) is S-10b (#103). Closes #102 Mechanism recorded in **ADR-0017**; opened as proposal #104. Mirrors the S-14 escalation (boundary-timer + external-worker) and S-11 withdrawal (interrupting cancel) patterns. ## Definition of Done - [x] Linked Gitea issue (above). - [x] Failing test committed before the implementation (red→green pairs per layer). - [x] Implementation makes the test pass. - [x] Conventional Commits referencing the issue (`refs #102`). - [ ] CI green — all Gitea Actions jobs (pending on this PR). - [x] `docker compose up` health unaffected (no new services; deploy path unchanged). - [x] Docs updated (ADR-0017, demo-script, BACKLOG split). - [x] ADR added (`docs/architecture/adr-0017-document-wait-timeout-cancellation.md`). - [x] Demo note in `docs/demo-script.md`. ## Notes for reviewers - **Domain** (`Registration.Expire()` + `Verlopen`), **application** (`ExpireRegistrationWorker`), **infra** (`RegistratieVerlopenProcessor`/`Pump`, `IRegistratieVerlopenClient`, Flowable acquire/complete + `CompleteDocumentWaitAsync`) — the timeout counterpart to the OpenZaak/escalation worker trios; idempotent per §8.6. - **BPMN** verified live against a `flowable-rest` probe: complete `WachtOpDocumenten` → routes to Beoordelen; fire the P30D timer → `RegistratieVerlopen` job (carrying `registrationId`) + the wait task cancelled. `verify-domain` exercises both branches in-stack (completes the wait in every existing block; fires the timer and asserts `Verlopen` in a new block). - **Scope boundary:** on expiry the aggregate goes `Verlopen` and the process ends, but the ZGW *zaak* is not yet set to a cancellation status — that needs a new ACL method + statustype seeding and is folded into S-10b (noted in ADR-0017). - `CompleteDocumentWaitAsync` is built and HTTP-tested here but not yet called from a domain endpoint; S-10b wires the upload trigger to it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Reviewed-on: #105
48 lines
2.4 KiB
C#
48 lines
2.4 KiB
C#
using Big.Domain;
|
|
|
|
namespace Big.Application;
|
|
|
|
/// <summary>A zorgprofessional's signal that they have supplied the documents their registration is
|
|
/// waiting for ("documenten aanleveren"). <paramref name="Bsn"/> is the authenticated caller (from the
|
|
/// DigiD token, forwarded by the BFF): only the registration's own bsn may provide its documents.</summary>
|
|
public sealed record ProvideDocumentsCommand(RegistrationId RegistrationId, string Bsn);
|
|
|
|
/// <summary>The outcome of a provide-documents request.</summary>
|
|
public enum ProvideDocumentsOutcome
|
|
{
|
|
/// <summary>The documents were accepted; the process's document wait was completed (if any).</summary>
|
|
Accepted,
|
|
|
|
/// <summary>No registration with that id belongs to the caller — unknown, or owned by someone else
|
|
/// (the two are deliberately indistinguishable, so the endpoint reveals neither).</summary>
|
|
NotFound,
|
|
}
|
|
|
|
/// <summary>
|
|
/// The provide-documents use case (S-10a): a zorgprofessional supplies the documents their registration
|
|
/// is parked waiting for, completing the WachtOpDocumenten task so the registratie process leaves the
|
|
/// 30-day wait and continues to beoordeling (ADR-0017). Owner-scoped by bsn. Completing the wait is
|
|
/// best-effort: if the registration never started a process (or already left the wait), the request
|
|
/// still stands, mirroring how <see cref="WithdrawRegistration"/> cancels best-effort. The actual file
|
|
/// upload and its ZGW storage via the ACL is S-10b; this is the trigger that unblocks the process.
|
|
/// </summary>
|
|
public sealed class ProvideDocuments(IRegistrationStore store, IWorkflowClient workflow)
|
|
{
|
|
public async Task<ProvideDocumentsOutcome> HandleAsync(ProvideDocumentsCommand command, CancellationToken ct = default)
|
|
{
|
|
ArgumentNullException.ThrowIfNull(command);
|
|
|
|
var registration = await store.GetAsync(command.RegistrationId, ct);
|
|
|
|
// Unknown, or not the caller's registration: report NotFound either way (don't reveal which).
|
|
if (registration is null || registration.Bsn != command.Bsn)
|
|
return ProvideDocumentsOutcome.NotFound;
|
|
|
|
// Complete the document wait (if a process is running) so beoordeling can proceed.
|
|
if (registration.ProcessInstanceId is not null)
|
|
await workflow.CompleteDocumentWaitAsync(registration.ProcessInstanceId, ct);
|
|
|
|
return ProvideDocumentsOutcome.Accepted;
|
|
}
|
|
}
|