## What & why After submitting, the self-service portal held the registration only in in-memory signals, so a **page refresh stranded an in-flight registration** — the reference and its "Documenten aanleveren" / "Trek aanvraag in" actions were lost, with no way back (the reference wasn't in the URL and there was no read endpoint). This is the gap a citizen hit in testing. Now the portal **resumes on load**: - **Domain:** `IRegistrationStore.FindOpenByBsnAsync` (the citizen's non-terminal INGEDIEND/IN_BEHANDELING registration) + `GET /registrations/current?bsn=`. - **BFF:** owner-scoped `GET /self-service/registrations` (bsn from the DigiD token) → the current registration, or **204** when none. Regenerated `services/bff/openapi.json`. - **Frontend:** `registration-page` calls it on init and restores the submitted view (reference + actions); 204 shows the submit form as before. api-client regenerated (orval). Closes #111 ## Definition of Done - [x] Linked issue (#111). - [x] TDD — store `FindOpenByBsnAsync` tests, BFF endpoint tests, an Angular component test (resume-on-load), a Playwright e2e (submit → reload → restored). - [x] Conventional Commits referencing #111. - [ ] CI green — validated locally (below); runner CI running. - [x] `docker compose up` reaches green health — fresh stack + full e2e (3 specs) green. - [x] Docs — `docs/synthetic-data.md` (new e2e users). - [ ] ADR — N/A (follows existing BFF/domain patterns; no boundary change). - [ ] Demo note — the flow is unchanged for the demo; no new demo-script section (happy to add one if wanted). ## Verified locally - Unit: Big 141 (+7 store tests), Bff 36 (+3 endpoint tests), all suites green. - Frontend: 12 self-service component tests (incl. resume-on-load); lint + build green. - **e2e (fresh CI stack): all 3 specs pass** — `registration`, `resume`, `withdrawal` (29.5s, single worker). - Mutation: domain **91.04%**, bff **100%** (break 90%). `make lint` clean. ## Notes for reviewers - **Shared-stack isolation:** resume-on-load restores any open registration for the logged-in bsn, so the self-service e2e specs can no longer share `jan-burger` (the verify-* API checks submit as `jan-burger`/`123456782` before the e2e). Each spec now has its own DigiD citizen (`emma`/`sanne`/`lars`-burger); `jan-burger` stays the documented citizen for the verify checks. This is the fix for the two intermittent e2e failures seen during development. - **Scope:** resumes the current **in-flight** registration only (terminal ones aren't resumed), per the issue's out-of-scope note. Reviewed-on: #119
174 lines
7.1 KiB
TypeScript
174 lines
7.1 KiB
TypeScript
import { signal } from '@angular/core';
|
|
import { fireEvent, render, screen } from '@testing-library/angular';
|
|
import { of, throwError } from 'rxjs';
|
|
import { AuthService } from 'auth';
|
|
import { BffApiV1Service } from 'api-client';
|
|
import { axe } from 'vitest-axe';
|
|
import { RegistrationPage } from './registration-page';
|
|
|
|
class FakeAuth extends AuthService {
|
|
readonly isAuthenticated = signal(true);
|
|
readonly bsn = signal<string | undefined>('123456782');
|
|
login(): void {
|
|
/* noop */
|
|
}
|
|
logout(): void {
|
|
/* noop */
|
|
}
|
|
}
|
|
|
|
function providers(
|
|
post = vi.fn().mockReturnValue(of({ registrationId: 'reg-9', status: 'Ingediend' })),
|
|
withdraw = vi.fn().mockReturnValue(of(undefined)),
|
|
provideDocuments = vi.fn().mockReturnValue(of(undefined)),
|
|
// Resume lookup (S-26): default to 204/empty — no in-flight registration, so the submit form shows.
|
|
getCurrent = vi.fn().mockReturnValue(of(undefined)),
|
|
) {
|
|
return {
|
|
post,
|
|
withdraw,
|
|
provideDocuments,
|
|
getCurrent,
|
|
providers: [
|
|
{ provide: AuthService, useClass: FakeAuth },
|
|
{
|
|
provide: BffApiV1Service,
|
|
useValue: {
|
|
getSelfServiceRegistrations: getCurrent,
|
|
postSelfServiceRegistrations: post,
|
|
postSelfServiceRegistrationsIdWithdraw: withdraw,
|
|
postSelfServiceRegistrationsIdDocuments: provideDocuments,
|
|
},
|
|
},
|
|
],
|
|
};
|
|
}
|
|
|
|
describe('RegistrationPage', () => {
|
|
it('shows the signed-in BSN', async () => {
|
|
await render(RegistrationPage, { providers: providers().providers });
|
|
expect(screen.getByText(/123456782/)).toBeTruthy();
|
|
});
|
|
|
|
it('submits the registration and confirms', async () => {
|
|
const { post, providers: p } = providers();
|
|
await render(RegistrationPage, { providers: p });
|
|
|
|
fireEvent.click(screen.getByRole('button', { name: /indienen/i }));
|
|
|
|
expect(post).toHaveBeenCalledTimes(1);
|
|
expect(await screen.findByText(/ontvangen/i)).toBeTruthy();
|
|
});
|
|
|
|
it('resumes an existing registration on load, without submitting again (S-26)', async () => {
|
|
const { post, providers: p } = providers(
|
|
undefined,
|
|
undefined,
|
|
undefined,
|
|
vi.fn().mockReturnValue(of({ registrationId: 'reg-77', status: 'Ingediend' })),
|
|
);
|
|
await render(RegistrationPage, { providers: p });
|
|
|
|
// The confirmation view is restored from the in-flight registration — no submit click.
|
|
expect(await screen.findByText(/ontvangen/i)).toBeTruthy();
|
|
expect(screen.getByText(/reg-77/)).toBeTruthy();
|
|
expect(post).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('shows an error and keeps the submit available when the BFF call fails', async () => {
|
|
const { post, providers: p } = providers(vi.fn().mockReturnValue(throwError(() => new Error('BFF rejected'))));
|
|
await render(RegistrationPage, { providers: p });
|
|
|
|
fireEvent.click(screen.getByRole('button', { name: /indienen/i }));
|
|
|
|
expect(post).toHaveBeenCalledTimes(1);
|
|
// The failure is surfaced (not swallowed), the confirmation is not shown, and the user can retry.
|
|
expect(await screen.findByRole('alert')).toBeTruthy();
|
|
expect(screen.queryByText(/ontvangen/i)).toBeNull();
|
|
expect(screen.getByRole('button', { name: /indienen/i })).toBeTruthy();
|
|
});
|
|
|
|
it('offers to withdraw after submitting, and withdrawing confirms', async () => {
|
|
const { withdraw, providers: p } = providers();
|
|
await render(RegistrationPage, { providers: p });
|
|
|
|
fireEvent.click(screen.getByRole('button', { name: /indienen/i }));
|
|
await screen.findByText(/ontvangen/i);
|
|
|
|
fireEvent.click(await screen.findByRole('button', { name: /trek aanvraag in/i }));
|
|
|
|
// The withdrawal is keyed by the reference the submit returned, and the page confirms it.
|
|
expect(withdraw).toHaveBeenCalledWith('reg-9');
|
|
expect(await screen.findByText(/ingetrokken/i)).toBeTruthy();
|
|
});
|
|
|
|
// A small PDF file the citizen "uploads"; the component base64-encodes it client-side.
|
|
const diploma = () => new File([new Uint8Array([1, 2, 3])], 'diploma.pdf', { type: 'application/pdf' });
|
|
|
|
it('uploads a chosen diploma after submitting, and doing so confirms', async () => {
|
|
const { provideDocuments, providers: p } = providers();
|
|
await render(RegistrationPage, { providers: p });
|
|
|
|
fireEvent.click(screen.getByRole('button', { name: /indienen/i }));
|
|
await screen.findByText(/ontvangen/i);
|
|
|
|
// Choose the file, then upload it.
|
|
fireEvent.change(screen.getByLabelText(/diploma/i), { target: { files: [diploma()] } });
|
|
fireEvent.click(await screen.findByRole('button', { name: /documenten aanleveren/i }));
|
|
|
|
// The upload is keyed by the reference and carries the base64 file + its name; the page confirms.
|
|
expect(await screen.findByText(/documenten.*aangeleverd/i)).toBeTruthy();
|
|
expect(provideDocuments).toHaveBeenCalledWith(
|
|
'reg-9',
|
|
expect.objectContaining({ fileName: 'diploma.pdf', contentType: 'application/pdf', contentBase64: expect.any(String) }),
|
|
);
|
|
});
|
|
|
|
it('surfaces a diploma-upload failure and keeps the action available', async () => {
|
|
const { providers: p } = providers(
|
|
vi.fn().mockReturnValue(of({ registrationId: 'reg-9', status: 'Ingediend' })),
|
|
vi.fn().mockReturnValue(of(undefined)),
|
|
vi.fn().mockReturnValue(throwError(() => new Error('documents rejected'))),
|
|
);
|
|
await render(RegistrationPage, { providers: p });
|
|
|
|
fireEvent.click(screen.getByRole('button', { name: /indienen/i }));
|
|
await screen.findByText(/ontvangen/i);
|
|
fireEvent.change(screen.getByLabelText(/diploma/i), { target: { files: [diploma()] } });
|
|
fireEvent.click(await screen.findByRole('button', { name: /documenten aanleveren/i }));
|
|
|
|
expect(await screen.findByRole('alert')).toBeTruthy();
|
|
expect(screen.queryByText(/aangeleverd/i)).toBeNull();
|
|
expect(screen.getByRole('button', { name: /documenten aanleveren/i })).toBeTruthy();
|
|
});
|
|
|
|
it('surfaces a withdraw failure and keeps the action available', async () => {
|
|
const { providers: p } = providers(
|
|
vi.fn().mockReturnValue(of({ registrationId: 'reg-9', status: 'Ingediend' })),
|
|
vi.fn().mockReturnValue(throwError(() => new Error('withdraw rejected'))),
|
|
);
|
|
await render(RegistrationPage, { providers: p });
|
|
|
|
fireEvent.click(screen.getByRole('button', { name: /indienen/i }));
|
|
await screen.findByText(/ontvangen/i);
|
|
fireEvent.click(await screen.findByRole('button', { name: /trek aanvraag in/i }));
|
|
|
|
expect(await screen.findByRole('alert')).toBeTruthy();
|
|
expect(screen.queryByText(/is ingetrokken/i)).toBeNull();
|
|
expect(screen.getByRole('button', { name: /trek aanvraag in/i })).toBeTruthy();
|
|
});
|
|
|
|
it('has no WCAG 2.1 AA violations on the submit page', async () => {
|
|
// The portal is Dutch; the real index.html sets lang. Set it here so the document-level
|
|
// html-has-lang rule reflects the app, not the bare jsdom document.
|
|
document.documentElement.lang = 'nl';
|
|
const { container } = await render(RegistrationPage, { providers: providers().providers });
|
|
|
|
const results = await axe(container, {
|
|
runOnly: { type: 'tag', values: ['wcag2a', 'wcag2aa', 'wcag21a', 'wcag21aa'] },
|
|
});
|
|
|
|
expect(results.violations).toEqual([]);
|
|
});
|
|
});
|