Niek Otten
1c185e6686
All checks were successful
## What & why S-09b (#75, split from #10) — the **approval flow** that completes the walking skeleton. A behandelaar can now approve a submitted registration; the entry flips from `INGEDIEND` to `INGESCHREVEN` in the public register. Flow: `POST /registrations/{id}/approve` (domain) → ACL sets the zaak eindstatus (ZGW `/statussen`) → OpenZaak → NRC → event-subscriber → projection → openbaar. ## Changes (bottom-up, each red→green TDD) - **Domain** — `RegistrationStatus.Ingeschreven` + `Registration.Approve()` (guards: opened zaak, only from INGEDIEND); `ApproveRegistration` use case (idempotent) + temp `POST /registrations/{id}/approve` endpoint; `IAclClient.ApproveZaakAsync`. - **ACL** — resolves the zaaktype's **eindstatus** from the catalogus (`isEindstatus` / highest volgnummer) and POSTs a ZGW status; exposed as `POST /statussen`. Unit + real-OpenZaak integration test. - **Event-subscriber** — binds NRC `hoofdObject`, projects a `status`/`create` as `INGESCHREVEN` keyed on the zaak (updates the existing row), **without reading OpenZaak** (§8.1). Retains the ZGW `resource` in the log (new column + EF migration) so a rebuild reproduces the status. - **e2e** — extended: submit → public INGEDIEND → approve → public INGESCHREVEN. - **Docs** — ADR-0011 (the two non-obvious decisions + the walking-skeleton assumption) + demo note. ## Key decisions (see ADR-0011) - **ACL discovers the eindstatus** (chosen over injecting a statustype URL): no new config/seed plumbing, domain stays ZGW-ignorant. - **Any post-creation status-set ⇒ INGESCHREVEN**: in the walking skeleton the only status ever set after creation is the approval, and the subscriber may not read ZGW — documented to tighten when more transitions arrive (S-12+). ## Verification - All .NET unit suites green locally (domain 47, acl 11, event-subscriber 14, bff 16, acceptance 7); Release build + `dotnet format` clean. - No new compose config (the eindstatus-discovery approach avoided it). - The real-OpenZaak integration test (ACL status-set) and the full submit→approve→visible e2e run in CI `verify-stack` (live NRC→projection + selectielijst egress, not reproducible locally). closes #75 Reviewed-on: #77
82 lines
2.8 KiB
C#
82 lines
2.8 KiB
C#
// <auto-generated />
|
|
using System;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Microsoft.EntityFrameworkCore.Infrastructure;
|
|
using Microsoft.EntityFrameworkCore.Storage.ValueConversion;
|
|
using Npgsql.EntityFrameworkCore.PostgreSQL.Metadata;
|
|
using Projection.ReadModel;
|
|
|
|
#nullable disable
|
|
|
|
namespace Projection.ReadModel.Migrations
|
|
{
|
|
[DbContext(typeof(ProjectionDbContext))]
|
|
partial class ProjectionDbContextModelSnapshot : ModelSnapshot
|
|
{
|
|
protected override void BuildModel(ModelBuilder modelBuilder)
|
|
{
|
|
#pragma warning disable 612, 618
|
|
modelBuilder
|
|
.HasAnnotation("ProductVersion", "10.0.0")
|
|
.HasAnnotation("Relational:MaxIdentifierLength", 63);
|
|
|
|
NpgsqlModelBuilderExtensions.UseIdentityByDefaultColumns(modelBuilder);
|
|
|
|
modelBuilder.Entity("Projection.ReadModel.ProcessedNotificationRow", b =>
|
|
{
|
|
b.Property<string>("Key")
|
|
.HasColumnType("text")
|
|
.HasColumnName("key");
|
|
|
|
b.Property<string>("Actie")
|
|
.IsRequired()
|
|
.HasColumnType("text")
|
|
.HasColumnName("actie");
|
|
|
|
b.Property<DateTimeOffset>("ReceivedAt")
|
|
.HasColumnType("timestamp with time zone")
|
|
.HasColumnName("received_at");
|
|
|
|
b.Property<string>("Resource")
|
|
.IsRequired()
|
|
.HasColumnType("text")
|
|
.HasColumnName("resource");
|
|
|
|
b.Property<string>("ZaakId")
|
|
.IsRequired()
|
|
.HasColumnType("text")
|
|
.HasColumnName("zaak_id");
|
|
|
|
b.HasKey("Key");
|
|
|
|
b.ToTable("processed_notifications", (string)null);
|
|
});
|
|
|
|
modelBuilder.Entity("Projection.ReadModel.RegisterEntryRow", b =>
|
|
{
|
|
b.Property<string>("Id")
|
|
.HasColumnType("text")
|
|
.HasColumnName("id");
|
|
|
|
b.Property<string>("Bsn")
|
|
.HasColumnType("text")
|
|
.HasColumnName("bsn");
|
|
|
|
b.Property<string>("NaamPlaceholder")
|
|
.HasColumnType("text")
|
|
.HasColumnName("naam_placeholder");
|
|
|
|
b.Property<string>("Status")
|
|
.IsRequired()
|
|
.HasColumnType("text")
|
|
.HasColumnName("status");
|
|
|
|
b.HasKey("Id");
|
|
|
|
b.ToTable("register_projection", (string)null);
|
|
});
|
|
#pragma warning restore 612, 618
|
|
}
|
|
}
|
|
}
|