not
ccae27b3da
## What & why S-13: a diploma's origin decides its route. A **DMN** (`diploma-eligibility`) is evaluated inline by the registratie process as a **`businessRuleTask`**; an exclusive gateway routes a **foreign** (Buitenlands) diploma through a new **CBGVAdvies** user task before `Beoordelen`, a **domestic** one straight there (PRD flow 4). The domain's only new job is carrying the diploma origin and passing it as a process start variable. Chose **Option B (DMN in the BPMN)** over the issue's literal "evaluated by the Domain Service via Workflow Client" wording — keeps the decision a first-class workflow artefact and §8.2 clean. Rationale in **ADR-0016** (proposal #100); noted on this issue. Closes #14 ## Definition of Done - [x] Linked Gitea issue (above). - [x] Failing test committed before the implementation. - [x] Implementation makes the test pass. - [x] Conventional Commits referencing the issue (`refs #14`). - [ ] CI green — all Gitea Actions jobs. - [x] `docker compose up` from a fresh clone reaches green health checks within 3 minutes (additive; DMN deployed by flowable-init). - [x] Docs updated (ADR-0016, demo note). - [x] ADR added (`docs/architecture/adr-0016-diploma-eligibility-dmn.md`). - [x] Demo note in `docs/demo-script.md`. ## How it was built (TDD) - **Domain**: `DiplomaOrigin` on the aggregate + submit command; threaded through the process-start port so the Workflow Client emits a `diplomaOrigin` start variable. Red → green. - **DMN + BPMN**: `workflows/diploma-eligibility.dmn` (origin → route); `businessRuleTask` + exclusive gateway + `CBGVAdvies` user task in `registratie.bpmn`; DMN deployed to Flowable's DMN engine by `flowable-init`. - **Both paths**: `Een diploma op herkomst routeren` acceptance scenarios (origin carried into the process) + unit tests; verify-domain drives a foreign registration through CBGVAdvies→Beoordelen and the domestic one straight to Beoordelen — exercising both DMN branches live. ## Notes for reviewers - Deviation from the issue's Option-A wording is deliberate and recorded (ADR-0016); the outcome is unchanged. - The self-service eIDAS→foreign wiring is out of scope here (this slice is area:domain + area:workflow); the domain submit accepts an optional `diplomaOrigin` so the foreign path is drivable. - Local green: domain unit 109, acceptance 15, `dotnet format`, Release build (0 errors), **domain mutation 95.39%** (break 90). The DMN/`businessRuleTask` REST wiring is CI-verified on verify-stack (no local full-stack run here). Reviewed-on: #101
42 lines
1.9 KiB
XML
42 lines
1.9 KiB
XML
<?xml version="1.0" encoding="UTF-8"?>
|
|
<definitions xmlns="https://www.omg.org/spec/DMN/20191111/MODEL/"
|
|
xmlns:flowable="http://flowable.org/dmn"
|
|
id="diplomaEligibilityDefinitions"
|
|
name="Diploma eligibility"
|
|
namespace="http://respellion.nl/big/dmn">
|
|
<!-- Diploma-eligibility decision (S-13, ADR-0016). Evaluated inline by the registratie process as a
|
|
BPMN DMN service task: given the diploma's origin, it sets the `route` the process should take.
|
|
A foreign (Buitenlands) diploma routes through the extra CBGV-advies assessment step; a domestic
|
|
one (or anything else) goes DIRECT to beoordeling. FIRST hit policy: the foreign rule wins, and
|
|
the empty-input catch-all is the default.
|
|
NB: the comment lives INSIDE <definitions> on purpose — Flowable's DMN XML converter chokes on a
|
|
comment between the XML declaration and the root element ("XMLStreamReader not in START_DOCUMENT
|
|
or START_ELEMENT state"), unlike its BPMN converter. -->
|
|
<decision id="diploma-eligibility" name="Diploma eligibility">
|
|
<decisionTable id="dt-diploma-eligibility" hitPolicy="FIRST">
|
|
<input id="in-origin" label="Diploma origin">
|
|
<inputExpression id="ie-origin" typeRef="string">
|
|
<text>diplomaOrigin</text>
|
|
</inputExpression>
|
|
</input>
|
|
<output id="out-route" label="Route" name="route" typeRef="string"/>
|
|
<rule id="rule-foreign">
|
|
<inputEntry id="rule-foreign-in">
|
|
<text>"Buitenlands"</text>
|
|
</inputEntry>
|
|
<outputEntry id="rule-foreign-out">
|
|
<text>"CBGV_ADVIES"</text>
|
|
</outputEntry>
|
|
</rule>
|
|
<rule id="rule-default">
|
|
<inputEntry id="rule-default-in">
|
|
<text></text>
|
|
</inputEntry>
|
|
<outputEntry id="rule-default-out">
|
|
<text>"DIRECT"</text>
|
|
</outputEntry>
|
|
</rule>
|
|
</decisionTable>
|
|
</decision>
|
|
</definitions>
|