eho/register-referentie
1
0
Fork 0
Code Issues 17 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

S-08b · Generated API client lib from the BFF OpenAPI spec #66

New Issue
Closed
opened 2026-07-01 09:36:27 +00:00 by not · 0 comments
not commented 2026-07-01 09:36:27 +00:00
Contributor
Copy Link

Split from #9 (CLAUDE.md §13).

Outcome: libs/api-client generated from services/bff/openapi.json (never hand-written, PRD §10), with a repeatable generation step and a unit test against a mocked BFF.

Acceptance:

  • The client types match the committed spec; nx test api-client passes.
  • Regeneration is a documented, repeatable command (drift guarded).

Touches: libs/api-client/, generation tooling, tests, docs/frontend-decisions.md.

Depends on: S-08a.
Out of scope: using it in the app (S-08c).

Definition of Done

  • Failing test committed before the implementation.
  • Implementation makes the test pass; refactor if structure improved.
  • Conventional Commits referencing this issue (refs #NN).
  • All Gitea Actions CI jobs green.
  • docker compose up reaches green health checks within 3 minutes.
  • Docs touched if behaviour/contracts/operations changed.
  • ADR added if a non-obvious decision was made.
  • Demo note appended if user-visible.
  • This issue closed by the merging PR (closes #NN).
**Split from #9 (CLAUDE.md §13).** **Outcome:** `libs/api-client` **generated** from `services/bff/openapi.json` (never hand-written, PRD §10), with a repeatable generation step and a unit test against a mocked BFF. **Acceptance:** - The client types match the committed spec; `nx test api-client` passes. - Regeneration is a documented, repeatable command (drift guarded). **Touches:** `libs/api-client/`, generation tooling, tests, `docs/frontend-decisions.md`. **Depends on:** S-08a. **Out of scope:** using it in the app (S-08c). ## Definition of Done - [ ] Failing test committed before the implementation. - [ ] Implementation makes the test pass; refactor if structure improved. - [ ] Conventional Commits referencing this issue (`refs #NN`). - [ ] All Gitea Actions CI jobs green. - [ ] `docker compose up` reaches green health checks within 3 minutes. - [ ] Docs touched if behaviour/contracts/operations changed. - [ ] ADR added if a non-obvious decision was made. - [ ] Demo note appended if user-visible. - [ ] This issue closed by the merging PR (`closes #NN`).
not added this to the Iteration 1 — Walking Skeleton milestone 2026-07-01 09:36:27 +00:00
not added the area:portal-self-servicetype:slice labels 2026-07-01 09:36:27 +00:00
not closed this issue 2026-07-01 10:51:03 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area:acl
area:bff
area:docs
area:domain
area:event-subscriber
area:infra
area:portal-behandel
area:portal-beheer
area:portal-openbaar
area:portal-self-service
area:projection
area:workflow
type:adr-proposal
type:bug
type:chore
type:slice
No Label area:portal-self-service type:slice
Milestone
No items
No Milestone Iteration 1 — Walking Skeleton
Projects
Clear projects
No project
Assignees
Clear assignees
eho
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eho/register-referentie#66
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?