From bc9831c1135f0494bae03600220570fbb7b3095b Mon Sep 17 00:00:00 2001 From: Niek Otten Date: Mon, 13 Jul 2026 14:35:34 +0000 Subject: [PATCH] =?UTF-8?q?S-09:=20Openbaar=20Register=20portal=20?= =?UTF-8?q?=E2=80=94=20public=20lookup=20(#76)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Anonymous openbaar portal completing the walking skeleton (submit → projection → public visibility). closes #10 --- BACKLOG.md | 30 +++++-- Makefile | 2 +- apps/openbaar/Dockerfile | 21 +++++ apps/openbaar/eslint.config.mjs | 34 ++++++++ apps/openbaar/nginx.conf | 23 +++++ apps/openbaar/project.json | 80 ++++++++++++++++++ apps/openbaar/public/favicon.ico | Bin 0 -> 15086 bytes apps/openbaar/src/app/app.config.ts | 19 +++++ apps/openbaar/src/app/app.css | 0 apps/openbaar/src/app/app.html | 1 + apps/openbaar/src/app/app.routes.ts | 4 + apps/openbaar/src/app/app.spec.ts | 14 +++ apps/openbaar/src/app/app.ts | 12 +++ .../src/app/register/register-page.html | 54 ++++++++++++ .../src/app/register/register-page.spec.ts | 57 +++++++++++++ .../src/app/register/register-page.ts | 45 ++++++++++ apps/openbaar/src/index.html | 13 +++ apps/openbaar/src/main.ts | 6 ++ apps/openbaar/src/styles.css | 2 + apps/openbaar/tsconfig.app.json | 9 ++ apps/openbaar/tsconfig.json | 31 +++++++ apps/openbaar/tsconfig.spec.json | 8 ++ docs/demo-script.md | 29 +++++++ docs/frontend-decisions.md | 14 +++ infra/docker-compose.yml | 21 +++++ tests/e2e/registration.spec.ts | 19 ++++- 26 files changed, 537 insertions(+), 11 deletions(-) create mode 100644 apps/openbaar/Dockerfile create mode 100644 apps/openbaar/eslint.config.mjs create mode 100644 apps/openbaar/nginx.conf create mode 100644 apps/openbaar/project.json create mode 100644 apps/openbaar/public/favicon.ico create mode 100644 apps/openbaar/src/app/app.config.ts create mode 100644 apps/openbaar/src/app/app.css create mode 100644 apps/openbaar/src/app/app.html create mode 100644 apps/openbaar/src/app/app.routes.ts create mode 100644 apps/openbaar/src/app/app.spec.ts create mode 100644 apps/openbaar/src/app/app.ts create mode 100644 apps/openbaar/src/app/register/register-page.html create mode 100644 apps/openbaar/src/app/register/register-page.spec.ts create mode 100644 apps/openbaar/src/app/register/register-page.ts create mode 100644 apps/openbaar/src/index.html create mode 100644 apps/openbaar/src/main.ts create mode 100644 apps/openbaar/src/styles.css create mode 100644 apps/openbaar/tsconfig.app.json create mode 100644 apps/openbaar/tsconfig.json create mode 100644 apps/openbaar/tsconfig.spec.json diff --git a/BACKLOG.md b/BACKLOG.md index 9f82199..41b1b38 100644 --- a/BACKLOG.md +++ b/BACKLOG.md @@ -162,20 +162,36 @@ The skeleton proves the spine end-to-end: a registration, a workflow, a zaak in **Out of scope (whole of S-08):** document upload, status tracking page. -### S-09 · Openbaar Register portal — public lookup +### S-09 · Openbaar Register portal — public lookup *(#10)* -**Outcome:** The openbaar Angular app shows a search box. Anonymous. Queries the BFF's `/openbaar/register` which reads only the projection's **public-safe** fields. Confirms the walking skeleton end-to-end. +**Outcome:** The openbaar Angular app shows a search box. Anonymous. Queries the BFF's `/openbaar/register` which reads only the projection's **public-safe** fields. Shows the public-visibility half of the walking skeleton. + +_Split from the original S-09 — scoped to the portal only; the approval flow is **S-09b (#75)**._ **Acceptance:** -- E2E test: zorgprofessional registers via self-service (S-08), behandelaar approves via a temporary admin endpoint (no behandel-portal yet), openbaar register shows the entry. -- Public-safe field whitelist enforced and tested. +- E2E test: after a zorgprofessional registers via self-service (S-08), the openbaar register shows the entry (as `INGEDIEND`). +- Public-safe field whitelist enforced and tested (already in the BFF; add a portal component test + a11y check). -**Touches:** `apps/openbaar/`, projection-api hardening, tests. +**Touches:** `apps/openbaar/`, compose serving, e2e, docs. -**Out of scope:** advanced search filters, sorting. +**Out of scope:** approval/status transition (S-09b), advanced search filters, sorting. -**End of walking skeleton.** Demo: submit → process → projection → public visibility. All CI gates green on Gitea Actions. Cut release `vYYYY.MM.0` and publish via Gitea Releases. +### S-09b · Approval flow — temp admin endpoint + status transition to projection *(#75)* + +**Outcome:** A behandelaar approves a submitted registration via a temporary admin endpoint (no behandel-portal yet — S-12). The approval transitions the zaak status through the ACL → NRC → event-subscriber → projection, and the openbaar register then shows the entry as approved. + +**Acceptance:** + +- A new terminal/approved status (e.g. `INGESCHREVEN`) exists and is projected. +- Temporary admin approve endpoint transitions a registration via a real ZGW status set (behind the ACL, §8). +- E2E: register (S-08) → approve → openbaar shows the entry as approved. + +**Touches:** `services/domain`, `services/acl`, `services/event-subscriber`, `services/projection-api`, e2e. + +**Out of scope:** behandel-portal UI (S-12), assessment logic (S-13), escalation (S-15). + +**End of walking skeleton** (S-09 + S-09b). Demo: submit → process → projection → public visibility. All CI gates green on Gitea Actions. Cut release `vYYYY.MM.0` and publish via Gitea Releases. --- diff --git a/Makefile b/Makefile index 3075548..d785565 100644 --- a/Makefile +++ b/Makefile @@ -10,7 +10,7 @@ COMPOSE := infra/docker-compose.yml # Long-running services with a healthcheck — the smoke polls these for readiness # (infra/wait-healthy.sh). One-shot init jobs (oz-init, nrc-init, flowable-init) # are not polled; they only need to have run. See docs/runbooks/gitea-actions-gotchas.md. -WAIT_SVCS := openzaak nrc-web acl bff domain event-subscriber projection-api self-service +WAIT_SVCS := openzaak nrc-web acl bff domain event-subscriber projection-api self-service openbaar # Config files (OpenZaak data.yaml, Keycloak realms, Flowable BPMN) are streamed # into external named volumes via `docker cp` (infra/seed-config.sh) instead of # bind-mounted, because bind mounts don't reach sibling containers on the diff --git a/apps/openbaar/Dockerfile b/apps/openbaar/Dockerfile new file mode 100644 index 0000000..ffeacf6 --- /dev/null +++ b/apps/openbaar/Dockerfile @@ -0,0 +1,21 @@ +# Multi-stage build for the openbaar portal (Angular → nginx). +# Build context is the repo root (the app needs the pnpm workspace + libs). See infra/docker-compose.yml. +FROM node:24-slim AS build +WORKDIR /src +RUN corepack enable && corepack prepare pnpm@11.5.2 --activate + +# Restore first (cached unless the manifests change). +COPY package.json pnpm-lock.yaml pnpm-workspace.yaml nx.json tsconfig.base.json eslint.config.mjs ./ +RUN pnpm install --frozen-lockfile + +# Sources (only what the app + its libs need). +COPY apps/openbaar apps/openbaar +COPY libs libs +RUN pnpm nx build openbaar + +FROM nginx:1.27-alpine AS runtime +COPY apps/openbaar/nginx.conf /etc/nginx/conf.d/default.conf +COPY --from=build /src/dist/apps/openbaar/browser /usr/share/nginx/html +# No runtime config: the openbaar register is anonymous (no OIDC authority to inject). + +EXPOSE 80 diff --git a/apps/openbaar/eslint.config.mjs b/apps/openbaar/eslint.config.mjs new file mode 100644 index 0000000..af5ff32 --- /dev/null +++ b/apps/openbaar/eslint.config.mjs @@ -0,0 +1,34 @@ +import nx from '@nx/eslint-plugin'; +import baseConfig from '../../eslint.config.mjs'; + +export default [ + ...nx.configs['flat/angular'], + ...nx.configs['flat/angular-template'], + ...baseConfig, + { + files: ['**/*.ts'], + rules: { + '@angular-eslint/directive-selector': [ + 'error', + { + type: 'attribute', + prefix: 'app', + style: 'camelCase', + }, + ], + '@angular-eslint/component-selector': [ + 'error', + { + type: 'element', + prefix: 'app', + style: 'kebab-case', + }, + ], + }, + }, + { + files: ['**/*.html'], + // Override or add rules here + rules: {}, + }, +]; diff --git a/apps/openbaar/nginx.conf b/apps/openbaar/nginx.conf new file mode 100644 index 0000000..aafc06b --- /dev/null +++ b/apps/openbaar/nginx.conf @@ -0,0 +1,23 @@ +server { + listen 80; + server_name _; + root /usr/share/nginx/html; + index index.html; + + # Resolve the BFF via Docker's embedded DNS at request time (variable proxy_pass), so nginx starts + # even before the BFF is up and picks up restarts — instead of failing to load the config. + resolver 127.0.0.11 ipv6=off valid=30s; + + # Same-origin API: proxy the anonymous openbaar endpoint group to the bff service. The api-client + # uses relative URLs, so the browser calls this origin and nginx forwards to the BFF — no CORS. + location /openbaar/ { + set $bff http://bff:8080; + proxy_pass $bff; + proxy_set_header Host $host; + } + + # SPA fallback — Angular client-side routing. + location / { + try_files $uri $uri/ /index.html; + } +} diff --git a/apps/openbaar/project.json b/apps/openbaar/project.json new file mode 100644 index 0000000..a85dfbd --- /dev/null +++ b/apps/openbaar/project.json @@ -0,0 +1,80 @@ +{ + "name": "openbaar", + "$schema": "../../node_modules/nx/schemas/project-schema.json", + "projectType": "application", + "prefix": "app", + "sourceRoot": "apps/openbaar/src", + "tags": [], + "targets": { + "build": { + "executor": "@angular/build:application", + "outputs": ["{options.outputPath}"], + "defaultConfiguration": "production", + "options": { + "outputPath": "dist/apps/openbaar", + "browser": "apps/openbaar/src/main.ts", + "tsConfig": "apps/openbaar/tsconfig.app.json", + "assets": [ + { + "glob": "**/*", + "input": "apps/openbaar/public" + } + ], + "styles": ["apps/openbaar/src/styles.css"] + }, + "configurations": { + "production": { + "budgets": [ + { + "type": "initial", + "maximumWarning": "1mb", + "maximumError": "2mb" + }, + { + "type": "anyComponentStyle", + "maximumWarning": "4kb", + "maximumError": "8kb" + } + ], + "outputHashing": "all" + }, + "development": { + "optimization": false, + "extractLicenses": false, + "sourceMap": true + } + } + }, + "serve": { + "continuous": true, + "executor": "@angular/build:dev-server", + "defaultConfiguration": "development", + "configurations": { + "production": { + "buildTarget": "openbaar:build:production" + }, + "development": { + "buildTarget": "openbaar:build:development" + } + } + }, + "lint": { + "executor": "@nx/eslint:lint" + }, + "test": { + "executor": "@angular/build:unit-test", + "options": { + "watch": false + } + }, + "serve-static": { + "continuous": true, + "executor": "@nx/web:file-server", + "options": { + "buildTarget": "openbaar:build", + "staticFilePath": "dist/apps/openbaar/browser", + "spa": true + } + } + } +} diff --git a/apps/openbaar/public/favicon.ico b/apps/openbaar/public/favicon.ico new file mode 100644 index 0000000000000000000000000000000000000000..317ebcb2336e0833a22dddf0ab287849f26fda57 GIT binary patch literal 15086 zcmeI332;U^%p|z7g|#(P)qFEA@4f!_@qOK2 z_lJl}!lhL!VT_U|uN7%8B2iKH??xhDa;*`g{yjTFWHvXn;2s{4R7kH|pKGdy(7z!K zgftM+Ku7~24TLlh(!g)gz|foI94G^t2^IO$uvX$3(OR0<_5L2sB)lMAMy|+`xodJ{ z_Uh_1m)~h?a;2W{dmhM;u!YGo=)OdmId_B<%^V^{ovI@y`7^g1_V9G}*f# zNzAtvou}I!W1#{M^@ROc(BZ! z+F!!_aR&Px3_reO(EW+TwlW~tv*2zr?iP7(d~a~yA|@*a89IUke+c472NXM0wiX{- zl`UrZC^1XYyf%1u)-Y)jj9;MZ!SLfd2Hl?o|80Su%Z?To_=^g_Jt0oa#CT*tjx>BI z16wec&AOWNK<#i0Qd=1O$fymLRoUR*%;h@*@v7}wApDl^w*h}!sYq%kw+DKDY)@&A z@9$ULEB3qkR#85`lb8#WZw=@})#kQig9oqy^I$dj&k4jU&^2(M3q{n1AKeGUKPFbr z1^<)aH;VsG@J|B&l>UtU#Ejv3GIqERzYgL@UOAWtW<{p#zy`WyJgpCy8$c_e%wYJL zyGHRRx38)HyjU3y{-4z6)pzb>&Q1pR)B&u01F-|&Gx4EZWK$nkUkOI|(D4UHOXg_- zw{OBf!oWQUn)Pe(=f=nt=zkmdjpO^o8ZZ9o_|4tW1ni+Un9iCW47*-ut$KQOww!;u z`0q)$s6IZO!~9$e_P9X!hqLxu`fpcL|2f^I5d4*a@Dq28;@2271v_N+5HqYZ>x;&O z05*7JT)mUe&%S0@UD)@&8SmQrMtsDfZT;fkdA!r(S=}Oz>iP)w=W508=Rc#nNn7ym z1;42c|8($ALY8#a({%1#IXbWn9-Y|0eDY$_L&j{63?{?AH{);EzcqfydD$@-B`Y3<%IIj7S7rK_N}je^=dEk%JQ4c z!tBdTPE3Tse;oYF>cnrapWq*o)m47X1`~6@(!Y29#>-#8zm&LXrXa(3=7Z)ElaQqj z-#0JJy3Fi(C#Rx(`=VXtJ63E2_bZGCz+QRa{W0e2(m3sI?LOcUBx)~^YCqZ{XEPX)C>G>U4tfqeH8L(3|pQR*zbL1 zT9e~4Tb5p9_G}$y4t`i*4t_Mr9QYvL9C&Ah*}t`q*}S+VYh0M6GxTTSXI)hMpMpIq zD1ImYqJLzbj0}~EpE-aH#VCH_udYEW#`P2zYmi&xSPs_{n6tBj=MY|-XrA;SGA_>y zGtU$?HXm$gYj*!N)_nQ59%lQdXtQZS3*#PC-{iB_sm+ytD*7j`D*k(P&IH2GHT}Eh z5697eQECVIGQAUe#eU2I!yI&%0CP#>%6MWV z@zS!p@+Y1i1b^QuuEF*13CuB zu69dve5k7&Wgb+^s|UB08Dr3u`h@yM0NTj4h7MnHo-4@xmyr7(*4$rpPwsCDZ@2be zRz9V^GnV;;?^Lk%ynzq&K(Aix`mWmW`^152Hoy$CTYVehpD-S1-W^#k#{0^L`V6CN+E z!w+xte;2vu4AmVNEFUOBmrBL>6MK@!O2*N|2=d|Y;oN&A&qv=qKn73lDD zI(+oJAdgv>Yr}8(&@ZuAZE%XUXmX(U!N+Z_sjL<1vjy1R+1IeHt`79fnYdOL{$ci7 z%3f0A*;Zt@ED&Gjm|OFTYBDe%bbo*xXAQsFz+Q`fVBH!N2)kaxN8P$c>sp~QXnv>b zwq=W3&Mtmih7xkR$YA)1Yi?avHNR6C99!u6fh=cL|KQ&PwF!n@ud^n(HNIImHD!h87!i*t?G|p0o+eelJ?B@A64_9%SBhNaJ64EvKgD&%LjLCYnNfc; znj?%*p@*?dq#NqcQFmmX($wms@CSAr9#>hUR^=I+=0B)vvGX%T&#h$kmX*s=^M2E!@N9#m?LhMvz}YB+kd zG~mbP|D(;{s_#;hsKK9lbVK&Lo734x7SIFJ9V_}2$@q?zm^7?*XH94w5Qae{7zOMUF z^?%F%)c1Y)Q?Iy?I>knw*8gYW#ok|2gdS=YYZLiD=CW|Nj;n^x!=S#iJ#`~Ld79+xXpVmUK^B(xO_vO!btA9y7w3L3-0j-y4 z?M-V{%z;JI`bk7yFDcP}OcCd*{Q9S5$iGA7*E1@tfkyjAi!;wP^O71cZ^Ep)qrQ)N z#wqw0_HS;T7x3y|`P==i3hEwK%|>fZ)c&@kgKO1~5<5xBSk?iZV?KI6&i72H6S9A* z=U(*e)EqEs?Oc04)V-~K5AUmh|62H4*`UAtItO$O(q5?6jj+K^oD!04r=6#dsxp?~}{`?&sXn#q2 zGuY~7>O2=!u@@Kfu7q=W*4egu@qPMRM>(eyYyaIE<|j%d=iWNdGsx%c!902v#ngNg z@#U-O_4xN$s_9?(`{>{>7~-6FgWpBpqXb`Ydc3OFL#&I}Irse9F_8R@4zSS*Y*o*B zXL?6*Aw!AfkNCgcr#*yj&p3ZDe2y>v$>FUdKIy_2N~}6AbHc7gA3`6$g@1o|dE>vz z4pl(j9;kyMsjaw}lO?(?Xg%4k!5%^t#@5n=WVc&JRa+XT$~#@rldvN3S1rEpU$;XgxVny7mki3 z-Hh|jUCHrUXuLr!)`w>wgO0N%KTB-1di>cj(x3Bav`7v z3G7EIbU$z>`Nad7Rk_&OT-W{;qg)-GXV-aJT#(ozdmnA~Rq3GQ_3mby(>q6Ocb-RgTUhTN)))x>m&eD;$J5Bg zo&DhY36Yg=J=$Z>t}RJ>o|@hAcwWzN#r(WJ52^g$lh^!63@hh+dR$&_dEGu&^CR*< z!oFqSqO@>xZ*nC2oiOd0eS*F^IL~W-rsrO`J`ej{=ou_q^_(<$&-3f^J z&L^MSYWIe{&pYq&9eGaArA~*kA diff --git a/apps/openbaar/src/app/app.routes.ts b/apps/openbaar/src/app/app.routes.ts new file mode 100644 index 0000000..12dc5ef --- /dev/null +++ b/apps/openbaar/src/app/app.routes.ts @@ -0,0 +1,4 @@ +import { Route } from '@angular/router'; +import { RegisterPage } from './register/register-page'; + +export const appRoutes: Route[] = [{ path: '', component: RegisterPage }]; diff --git a/apps/openbaar/src/app/app.spec.ts b/apps/openbaar/src/app/app.spec.ts new file mode 100644 index 0000000..133f47b --- /dev/null +++ b/apps/openbaar/src/app/app.spec.ts @@ -0,0 +1,14 @@ +import { provideRouter } from '@angular/router'; +import { render } from '@testing-library/angular'; +import { App } from './app'; + +describe('App', () => { + it('renders the router outlet shell', async () => { + const { container } = await render(App, { + providers: [provideRouter([])], + }); + + // The shell is a thin host for routed pages (the RegisterPage owns the heading). + expect(container.querySelector('router-outlet')).toBeTruthy(); + }); +}); diff --git a/apps/openbaar/src/app/app.ts b/apps/openbaar/src/app/app.ts new file mode 100644 index 0000000..ba60373 --- /dev/null +++ b/apps/openbaar/src/app/app.ts @@ -0,0 +1,12 @@ +import { Component } from '@angular/core'; +import { RouterModule } from '@angular/router'; + +@Component({ + imports: [RouterModule], + selector: 'app-root', + templateUrl: './app.html', + styleUrl: './app.css', +}) +export class App { + protected title = 'openbaar'; +} diff --git a/apps/openbaar/src/app/register/register-page.html b/apps/openbaar/src/app/register/register-page.html new file mode 100644 index 0000000..2051621 --- /dev/null +++ b/apps/openbaar/src/app/register/register-page.html @@ -0,0 +1,54 @@ +
+ + Openbaar BIG-register +

+ Zoek in het openbare register van BIG-registraties. Alleen publieke gegevens worden getoond. +

+ +
+ + + +
+ + @if (loading()) { +

Bezig met laden…

+ } @else if (searched() && entries().length === 0) { +

Geen inschrijvingen gevonden.

+ } @else if (entries().length > 0) { + + + + + + + + + + @for (entry of entries(); track entry.id) { + + + + + } + +
Inschrijvingen in het openbaar register
ReferentieStatus
{{ entry.id }}{{ entry.status }}
+ } + +
diff --git a/apps/openbaar/src/app/register/register-page.spec.ts b/apps/openbaar/src/app/register/register-page.spec.ts new file mode 100644 index 0000000..d9dd6c9 --- /dev/null +++ b/apps/openbaar/src/app/register/register-page.spec.ts @@ -0,0 +1,57 @@ +import { fireEvent, render, screen } from '@testing-library/angular'; +import { of } from 'rxjs'; +import { BffApiV1Service, type OpenbaarEntry } from 'api-client'; +import { axe } from 'vitest-axe'; +import { RegisterPage } from './register-page'; + +const sample: OpenbaarEntry[] = [ + { id: 'zaak-abc', status: 'INGEDIEND' }, + { id: 'zaak-def', status: 'INGESCHREVEN' }, +]; + +function providers(get = vi.fn().mockReturnValue(of(sample))) { + return { + get, + providers: [{ provide: BffApiV1Service, useValue: { getOpenbaarRegister: get } }], + }; +} + +describe('RegisterPage', () => { + it('lists the public register entries from the BFF on open', async () => { + const { get } = providers(); + await render(RegisterPage, { providers: providers(get).providers }); + + expect(get).toHaveBeenCalled(); + expect(await screen.findByText(/zaak-abc/)).toBeTruthy(); + expect(screen.getByText(/INGEDIEND/)).toBeTruthy(); + expect(screen.getByText(/zaak-def/)).toBeTruthy(); + }); + + it('searches by the entered term', async () => { + const get = vi.fn().mockReturnValue(of(sample)); + await render(RegisterPage, { providers: providers(get).providers }); + + fireEvent.input(screen.getByRole('searchbox'), { target: { value: 'zaak-abc' } }); + fireEvent.click(screen.getByRole('button', { name: /zoek/i })); + + expect(get).toHaveBeenLastCalledWith({ q: 'zaak-abc' }); + }); + + it('shows an empty-state message when the register has no matches', async () => { + const get = vi.fn().mockReturnValue(of([] as OpenbaarEntry[])); + await render(RegisterPage, { providers: providers(get).providers }); + + expect(await screen.findByText(/geen inschrijvingen gevonden/i)).toBeTruthy(); + }); + + it('has no WCAG 2.1 AA violations', async () => { + document.documentElement.lang = 'nl'; + const { container } = await render(RegisterPage, { providers: providers().providers }); + + const results = await axe(container, { + runOnly: { type: 'tag', values: ['wcag2a', 'wcag2aa', 'wcag21a', 'wcag21aa'] }, + }); + + expect(results.violations).toEqual([]); + }); +}); diff --git a/apps/openbaar/src/app/register/register-page.ts b/apps/openbaar/src/app/register/register-page.ts new file mode 100644 index 0000000..0f94d66 --- /dev/null +++ b/apps/openbaar/src/app/register/register-page.ts @@ -0,0 +1,45 @@ +import { Component, inject, signal } from '@angular/core'; +import { FormsModule } from '@angular/forms'; +import { BffApiV1Service, type OpenbaarEntry } from 'api-client'; +import { UtrechtComponentsModule } from 'ui'; + +/** + * The openbaar (public) BIG-register: an anonymous search over the read projection's public-safe + * view (id + status only — bsn/naam never leave the BFF; ADR-0010). Loads the full register on open + * and filters by the search term via the BFF's `/openbaar/register?q=` endpoint (S-09). + */ +@Component({ + selector: 'app-register-page', + imports: [FormsModule, UtrechtComponentsModule], + templateUrl: './register-page.html', +}) +export class RegisterPage { + private readonly bff = inject(BffApiV1Service); + + protected readonly query = signal(''); + protected readonly entries = signal([]); + protected readonly loading = signal(false); + protected readonly searched = signal(false); + + constructor() { + // Show the full register on open; the search box narrows it. + this.search(); + } + + search(): void { + const q = this.query().trim(); + this.loading.set(true); + this.bff.getOpenbaarRegister(q ? { q } : {}).subscribe({ + next: (rows: OpenbaarEntry[]) => { + this.entries.set(rows); + this.loading.set(false); + this.searched.set(true); + }, + error: () => { + this.entries.set([]); + this.loading.set(false); + this.searched.set(true); + }, + }); + } +} diff --git a/apps/openbaar/src/index.html b/apps/openbaar/src/index.html new file mode 100644 index 0000000..279e9b3 --- /dev/null +++ b/apps/openbaar/src/index.html @@ -0,0 +1,13 @@ + + + + + Openbaar BIG-register + + + + + + + + diff --git a/apps/openbaar/src/main.ts b/apps/openbaar/src/main.ts new file mode 100644 index 0000000..4258790 --- /dev/null +++ b/apps/openbaar/src/main.ts @@ -0,0 +1,6 @@ +import { bootstrapApplication } from '@angular/platform-browser'; +import { App } from './app/app'; +import { appConfig } from './app/app.config'; + +// The openbaar register is anonymous (no DigiD, no runtime config) — bootstrap directly. +bootstrapApplication(App, appConfig).catch((err) => console.error(err)); diff --git a/apps/openbaar/src/styles.css b/apps/openbaar/src/styles.css new file mode 100644 index 0000000..ade77c5 --- /dev/null +++ b/apps/openbaar/src/styles.css @@ -0,0 +1,2 @@ +/* NL Design System theme — Utrecht design tokens (docs/frontend-decisions.md). */ +@import '@utrecht/design-tokens/dist/index.css'; diff --git a/apps/openbaar/tsconfig.app.json b/apps/openbaar/tsconfig.app.json new file mode 100644 index 0000000..a75ddab --- /dev/null +++ b/apps/openbaar/tsconfig.app.json @@ -0,0 +1,9 @@ +{ + "extends": "./tsconfig.json", + "compilerOptions": { + "outDir": "../../dist/out-tsc", + "types": [] + }, + "include": ["src/**/*.ts"], + "exclude": ["src/**/*.spec.ts", "src/**/*.test.ts"] +} diff --git a/apps/openbaar/tsconfig.json b/apps/openbaar/tsconfig.json new file mode 100644 index 0000000..bb7614f --- /dev/null +++ b/apps/openbaar/tsconfig.json @@ -0,0 +1,31 @@ +{ + "extends": "../../tsconfig.base.json", + "compilerOptions": { + "strict": true, + "noImplicitOverride": true, + "noPropertyAccessFromIndexSignature": true, + "noImplicitReturns": true, + "noFallthroughCasesInSwitch": true, + "isolatedModules": true, + "target": "es2022", + "moduleResolution": "bundler", + "emitDecoratorMetadata": false, + "module": "preserve" + }, + "angularCompilerOptions": { + "enableI18nLegacyMessageIdFormat": false, + "strictInjectionParameters": true, + "strictInputAccessModifiers": true, + "strictTemplates": true + }, + "files": [], + "include": [], + "references": [ + { + "path": "./tsconfig.app.json" + }, + { + "path": "./tsconfig.spec.json" + } + ] +} diff --git a/apps/openbaar/tsconfig.spec.json b/apps/openbaar/tsconfig.spec.json new file mode 100644 index 0000000..2d36c49 --- /dev/null +++ b/apps/openbaar/tsconfig.spec.json @@ -0,0 +1,8 @@ +{ + "extends": "./tsconfig.json", + "compilerOptions": { + "outDir": "../../dist/out-tsc", + "types": ["vitest/globals"] + }, + "include": ["src/**/*.ts", "src/**/*.d.ts"] +} diff --git a/docs/demo-script.md b/docs/demo-script.md index b457be5..7874781 100644 --- a/docs/demo-script.md +++ b/docs/demo-script.md @@ -168,3 +168,32 @@ curl -fsS http://localhost:8120/register | jq 'length' # → unchanged > `bsn` / `naam_placeholder` are deferred (ADR-0008) — the notification doesn't carry them and > the subscriber may not read OpenZaak directly (§8.1). They surface in a later slice. + +--- + +## S-09 — Openbaar Register portal (public visibility) + +**Outcome:** the entry a zorgprofessional submits via self-service becomes publicly visible in the +anonymous openbaar register portal — closing the walking-skeleton loop (submit → process → projection +→ public visibility). + +**The path:** self-service submit → BFF → domain → (zaak) OpenZaak → NRC → Event Subscriber → +projection → openbaar portal reads the BFF's public-safe `GET /openbaar/register`. + +```bash +# 1. Bring the full stack up (self-service :8140, openbaar :8141). +make up + +# 2. Submit a registration via the self-service portal (mock DigiD: jan-burger / test123), +# or drive the whole happy path automatically (login → submit → public visibility): +make verify-e2e + +# 3. Open the public register — no login. It lists the submitted entry (id + status only). +# Only public-safe fields cross the BFF: bsn / naam never appear. +open http://localhost:8141/ # search box; searches the BFF by referentie +curl -fsS http://localhost:8140/openbaar/register | jq # same public-safe view via the BFF proxy +# → [ { "id": "", "status": "INGEDIEND" } ] +``` + +> The register shows `INGEDIEND` entries today; the approval transition to a terminal status +> (e.g. `INGESCHREVEN`) lands with the approval flow (S-09b, #75). diff --git a/docs/frontend-decisions.md b/docs/frontend-decisions.md index 88ad7fb..19c65e9 100644 --- a/docs/frontend-decisions.md +++ b/docs/frontend-decisions.md @@ -103,3 +103,17 @@ with the submit form (S-08c, #67); any deviation from NL DS will be recorded her touching the app or its production config. - `tests/e2e` is a standalone Playwright project (its own `package.json`), not an Nx project — it's a live-stack check like the other `verify-*` runners, not part of the `frontend` unit lane. + +## Openbaar Register portal (S-09, #10) + +- **Anonymous, no auth.** The openbaar register is a public read, so `apps/openbaar` has no + `angular-auth-oidc-client`, no interceptor, and no `config.json` — `main.ts` bootstraps `appConfig` + directly with just `provideHttpClient` + `provideRouter`. This is the deliberate contrast to + self-service and keeps the app trivially cacheable/CDN-able. +- **Same-origin via nginx, like self-service.** The compose `openbaar` image serves the built app and + reverse-proxies `/openbaar` to the BFF; the api-client's relative calls stay same-origin (no CORS). + Served on `:8141`, health-checked over IPv4 (`127.0.0.1`), no Keycloak dependency. +- **Public-safe by construction.** The portal only ever sees the BFF's `OpenbaarProjection.PublicView` + (id + status); `bsn`/`naam` never leave the BFF. The e2e asserts the bsn never renders. +- **Loads on open, filters on search.** `RegisterPage` fetches the full register on construction and + re-queries `/openbaar/register?q=` on search — no client-side filtering, the BFF owns the query. diff --git a/infra/docker-compose.yml b/infra/docker-compose.yml index 4dceacd..48c3853 100644 --- a/infra/docker-compose.yml +++ b/infra/docker-compose.yml @@ -458,6 +458,27 @@ services: condition: service_started networks: [cg] + # The openbaar (public) register portal: nginx serves the Angular app and reverse-proxies + # /openbaar to the BFF. Anonymous — no DigiD, no Keycloak dependency (S-09). + openbaar: + build: + context: .. + dockerfile: apps/openbaar/Dockerfile + image: register-referentie/openbaar:dev + ports: + - "8141:80" + healthcheck: + # 127.0.0.1, not localhost: nginx listens on IPv4 only, but localhost resolves to ::1 first. + test: ["CMD-SHELL", "wget -q -O /dev/null http://127.0.0.1/ || exit 1"] + interval: 5s + timeout: 3s + retries: 5 + start_period: 10s + depends_on: + bff: + condition: service_healthy + networks: [cg] + volumes: oz-db: nrc-db: diff --git a/tests/e2e/registration.spec.ts b/tests/e2e/registration.spec.ts index e446bdb..216bb0d 100644 --- a/tests/e2e/registration.spec.ts +++ b/tests/e2e/registration.spec.ts @@ -1,8 +1,9 @@ import { expect, test } from '@playwright/test'; -// Walking-skeleton happy path (S-08d): a zorgprofessional logs in via mock DigiD and submits a -// registration through the self-service portal → BFF → domain. The confirmation shows the reference. -test('DigiD login → submit → confirmation', async ({ page }) => { +// Walking-skeleton happy path (S-08d + S-09): a zorgprofessional logs in via mock DigiD and submits a +// registration through the self-service portal → BFF → domain; the projection is updated via NRC → the +// event-subscriber, and the entry becomes publicly visible in the openbaar register portal. +test('DigiD login → submit → confirmation → public visibility', async ({ page }) => { // Visiting the guarded page redirects to the Keycloak (mock DigiD) login. await page.goto('/'); @@ -18,4 +19,16 @@ test('DigiD login → submit → confirmation', async ({ page }) => { // The BFF accepted it and the page shows the confirmation. await expect(page.getByText(/ontvangen/i)).toBeVisible(); + + // The openbaar register (anonymous, its own origin) shows the submitted entry once the projection + // catches up. The projection updates asynchronously (NRC → event-subscriber), and the register loads + // on open, so reload until a submitted (INGEDIEND) row appears. + await page.goto('http://openbaar/'); + await expect(page.getByRole('heading', { name: /Openbaar BIG-register/i })).toBeVisible(); + await expect + .poll(async () => { + await page.reload(); + return page.getByRole('cell', { name: 'INGEDIEND' }).count(); + }, { timeout: 30_000, intervals: [1_000, 2_000, 3_000, 5_000] }) + .toBeGreaterThan(0); });