eho/register-referentie
1
0
Fork 0
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases 1 Wiki Activity

fix(e2e): assert the register record where a real approval happens (refs #149)
CI / build (pull_request) Successful in 1m6s
Details
CI / lint (pull_request) Successful in 1m19s
Details
CI / unit (pull_request) Successful in 1m24s
Details
CI / frontend (pull_request) Successful in 2m57s
Details
CI / mutation (pull_request) Successful in 6m7s
Details
CI / verify-stack (pull_request) Successful in 7m49s
Details

Browse Source 
verify-domain was the wrong home for the assertion, and CI was right to fail it.
That check completes the Beoordelen task straight through Flowable REST — on
purpose, it exists to exercise the Workflow Client's REST contract — which
bypasses the domain `decide` path that calls the ACL. No approval reached the
ACL there, so no record was ever written.

The Playwright happy path is the only check that drives a real approval
(behandel portal → BFF → domain → ACL), and it already knows its own reference.
Assert there instead: exactly one RegisterRecord for that reference,
INGESCHREVEN, carrying nothing outside the public-safe schema. Drops
register-record-check.py and the verify-domain block.

The helper was run under real Playwright against a live Objecten before
committing — one record found, none for an unknown reference.
This commit is contained in:
not
2026-08-14 10:43:34 +02:00
parent 10b784cc05
commit 2d783448b7
5 changed files with 67 additions and 135 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/architecture/adr-0028-objecten-holds-the-register.md
+10 -4
View File
@@ -153,10 +153,16 @@ and no service reaches Objecten's database.
## Verification
`verify-domain` (`infra/run-domain-check.sh`) drives a real approval end-to-end and then
asserts, via `infra/register-record-check.py`, that Objecten holds exactly one
`RegisterRecord` for that registration, with status `INGESCHREVEN` and no field outside
the public-safe schema.
The end-to-end assertion lives in the Playwright happy path
(`tests/e2e/registration.spec.ts`, run by `verify-e2e`): after the behandelaar approves and
the openbaar register shows `INGESCHREVEN`, it asserts Objecten holds exactly one
`RegisterRecord` for *that* reference, with status `INGESCHREVEN` and no field outside the
public-safe schema.
It belongs there and not in `verify-domain`, which looks like the obvious home: that check
completes the Beoordelen task straight through Flowable REST (deliberately — it exists to
exercise the Workflow Client's REST contract), which bypasses the domain `decide` path that
calls the ACL. The e2e is the only check that drives a real approval.
`ObjectenGatewayIntegrationTests` (`Category=Integration`, so it runs under `verify-acl`
inside the compose network) drives the real gateway against a live Objecten + Objecttypen