Edwin van den Houdt
556f2f47bf
Applications, documents (+ audit log) and the brief move off static in-memory Dictionaries onto a real SQLite file via EF Core, so demo data survives a process restart or `docker compose restart api` for the first time. The three stores (ApplicationStore/DocumentStore/BriefStore) keep their exact public signatures and static-class shape — no DI, no async ripple into Program.cs's minimal-API handlers — each method just opens a short-lived AppDbContext via Db.Create() under the same lock it already had. Opaque nested shapes (a wizard's draft snapshot, a brief's sections/placeholders/status) are stored as JSON text columns rather than redesigned into relational tables, matching the existing "don't interpret it" posture. Found two things the WP's own text got wrong, corrected in docs/backlog/WP-22-durable-persistence.md's Deviations section: SeedData never seeded these three stores (only the read-only BRP/DUO-mimicking GETs, which stay in-memory) so there's no seed step; and no new docker-compose volume is needed since the existing bind mount already covers the SQLite file — verified against this environment's real podman-backed compose stack, not just by reading the file. Also: pinned SQLitePCLRaw.bundle_e_sqlite3 to 3.0.3 (EF Core Sqlite's own transitive default bundles a pre-3.50.2 SQLite with a known high-severity memory-corruption advisory); found and fixed a real xUnit test race where concurrent test-class hosts stomped a shared static connection-string field, fixed by disabling cross-class test parallelization rather than adding DI the stores don't otherwise need. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
70 lines
2.7 KiB
C#
70 lines
2.7 KiB
C#
using System.Net.Http.Json;
|
|
using BigRegister.Api.Contracts;
|
|
using Microsoft.AspNetCore.Mvc.Testing;
|
|
|
|
namespace BigRegister.Tests;
|
|
|
|
public class IdempotencyTests(TestWebApplicationFactory factory) : IClassFixture<TestWebApplicationFactory>
|
|
{
|
|
private readonly HttpClient _client = factory.CreateClient();
|
|
|
|
private static HttpRequestMessage ChangeRequestWithKey(string key)
|
|
{
|
|
var req = new HttpRequestMessage(HttpMethod.Post, "/api/v1/change-requests")
|
|
{
|
|
Content = JsonContent.Create(new { straat = "Lange Voorhout 9", postcode = "2514 EA", woonplaats = "Den Haag" }),
|
|
};
|
|
req.Headers.Add("Idempotency-Key", key);
|
|
return req;
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Replaying_the_same_idempotency_key_returns_the_same_reference_not_a_new_one()
|
|
{
|
|
var key = Guid.NewGuid().ToString();
|
|
|
|
var first = await _client.SendAsync(ChangeRequestWithKey(key));
|
|
first.EnsureSuccessStatusCode();
|
|
var firstBody = await first.Content.ReadFromJsonAsync<ReferentieResponse>();
|
|
|
|
var replay = await _client.SendAsync(ChangeRequestWithKey(key));
|
|
replay.EnsureSuccessStatusCode();
|
|
var replayBody = await replay.Content.ReadFromJsonAsync<ReferentieResponse>();
|
|
|
|
Assert.Equal(firstBody!.Referentie, replayBody!.Referentie);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Different_idempotency_keys_are_independent_submissions()
|
|
{
|
|
var first = await _client.SendAsync(ChangeRequestWithKey(Guid.NewGuid().ToString()));
|
|
var second = await _client.SendAsync(ChangeRequestWithKey(Guid.NewGuid().ToString()));
|
|
var firstBody = await first.Content.ReadFromJsonAsync<ReferentieResponse>();
|
|
var secondBody = await second.Content.ReadFromJsonAsync<ReferentieResponse>();
|
|
|
|
Assert.NotEqual(firstBody!.Referentie, secondBody!.Referentie);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task A_rejected_submission_replays_the_same_rejection_not_a_retry()
|
|
{
|
|
var key = Guid.NewGuid().ToString();
|
|
var badRequest = new HttpRequestMessage(HttpMethod.Post, "/api/v1/change-requests")
|
|
{
|
|
Content = JsonContent.Create(new { straat = "Straat 1", postcode = "nope", woonplaats = "Den Haag" }),
|
|
};
|
|
badRequest.Headers.Add("Idempotency-Key", key);
|
|
|
|
var first = await _client.SendAsync(badRequest);
|
|
Assert.Equal(System.Net.HttpStatusCode.UnprocessableEntity, first.StatusCode);
|
|
|
|
var replayRequest = new HttpRequestMessage(HttpMethod.Post, "/api/v1/change-requests")
|
|
{
|
|
Content = JsonContent.Create(new { straat = "Straat 1", postcode = "nope", woonplaats = "Den Haag" }),
|
|
};
|
|
replayRequest.Headers.Add("Idempotency-Key", key);
|
|
var replay = await _client.SendAsync(replayRequest);
|
|
Assert.Equal(System.Net.HttpStatusCode.UnprocessableEntity, replay.StatusCode);
|
|
}
|
|
}
|