Restructures into apps/ssp + apps/behandelportal (two Angular projects) plus libs/shared + libs/beheer (cross-app libraries), replacing WP-61's separate sibling repo. That split had already produced real drift: a hand-vendored copy of the backend's OpenAPI doc, a shared/ui+layout tree forked and silently diverging (7 files), and beheer + the styles.scss token bridge duplicated byte-for-byte across both repos. - git mv the SSP's src/app/* into apps/ssp/; fold shared/, beheer/, environments/, the Storybook docs/*.mdx, and styles.scss into libs/shared + libs/beheer (all confirmed identical between the two repos before merging). auth stays deliberately duplicated per ADR-0002 (actor-specific, expected to diverge) - amended there. - One generated API client (libs/shared), no more vendored swagger.json. - .dependency-cruiser split into a base factory + one config per app, and Storybook into .storybook-ssp/.storybook-behandelportal - both forced by the @auth/* alias resolving to different directories per app. - SiteHeaderComponent/ShellComponent gained HEADER_NAV_ITEMS/ HEADER_ADMIN_LINKS/DEBUG_PANEL injection tokens so each app supplies its own nav/admin-links/dev-panel instead of one being hardcoded. - CLAUDE.md, ARCHITECTURE.md, dependencies.md, and ADR-0002 updated; WP-67 backlog entry documents the full decision trail. npm run ci green (lint, dep:check x2, 360 tests across ssp/ behandelportal/shared/beheer, both localized builds, backend tests, snippet + api-client drift); both dev servers, both Storybook instances, and docker compose verified working. The old sibling repo (/home/eho/repos/behandelportal) is left untouched, not deleted. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
97 lines
3.4 KiB
TypeScript
97 lines
3.4 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { StamTable, activeOn, changeCounts, isValid, rowErrors, toJson } from './stamdata';
|
|
|
|
const professions: StamTable = {
|
|
id: 'professions',
|
|
label: 'Opleiding → beroep',
|
|
temporal: true,
|
|
columns: [
|
|
{ name: 'program', type: 'text', isKey: true, options: [] },
|
|
{ name: 'beroep', type: 'text', isKey: false, options: [] },
|
|
{ name: 'geldigVan', type: 'date', isKey: false, options: [] },
|
|
{ name: 'geldigTot', type: 'date', isKey: false, options: [] },
|
|
],
|
|
};
|
|
|
|
const row = (program: string, beroep: string, van: string, tot = ''): Record<string, string> => ({
|
|
program,
|
|
beroep,
|
|
geldigVan: van,
|
|
geldigTot: tot,
|
|
});
|
|
|
|
describe('activeOn (valid-time, half-open [van, tot))', () => {
|
|
it('includes a row whose window covers the date', () => {
|
|
expect(activeOn(professions, row('a', 'A', '2000-01-01'), '2020-01-01')).toBe(true);
|
|
});
|
|
it('excludes a row before its geldigVan', () => {
|
|
expect(activeOn(professions, row('a', 'A', '2000-01-01'), '1999-01-01')).toBe(false);
|
|
});
|
|
it('excludes on the geldigTot boundary (half-open)', () => {
|
|
expect(activeOn(professions, row('a', 'A', '2000-01-01', '2020-01-01'), '2020-01-01')).toBe(
|
|
false,
|
|
);
|
|
expect(activeOn(professions, row('a', 'A', '2000-01-01', '2020-01-01'), '2019-12-31')).toBe(
|
|
true,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('rowErrors / isValid (format only)', () => {
|
|
it('flags a blank key', () => {
|
|
expect(rowErrors(professions, [row('', 'A', '2000-01-01')])[0]).not.toBe('');
|
|
});
|
|
it('flags a missing geldigVan on a temporal table', () => {
|
|
expect(rowErrors(professions, [row('a', 'A', '')])[0]).not.toBe('');
|
|
});
|
|
it('flags geldigTot on or before geldigVan', () => {
|
|
expect(rowErrors(professions, [row('a', 'A', '2020-01-01', '2020-01-01')])[0]).not.toBe('');
|
|
});
|
|
it('passes a well-formed row', () => {
|
|
expect(isValid(professions, [row('a', 'A', '2000-01-01')])).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe('changeCounts (diff against the loaded snapshot, by key)', () => {
|
|
const original = [row('a', 'A', '2000-01-01'), row('b', 'B', '2000-01-01')];
|
|
it('counts an added key', () => {
|
|
const draft = [...original, row('c', 'C', '2000-01-01')];
|
|
expect(changeCounts(professions, original, draft)).toEqual({ added: 1, removed: 0, edited: 0 });
|
|
});
|
|
it('counts a removed key', () => {
|
|
expect(changeCounts(professions, original, [original[0]])).toEqual({
|
|
added: 0,
|
|
removed: 1,
|
|
edited: 0,
|
|
});
|
|
});
|
|
it('counts an edited cell', () => {
|
|
const draft = [row('a', 'CHANGED', '2000-01-01'), original[1]];
|
|
expect(changeCounts(professions, original, draft)).toEqual({ added: 0, removed: 0, edited: 1 });
|
|
});
|
|
});
|
|
|
|
describe('toJson (draft → file shape)', () => {
|
|
it('reconstructs an open-ended geldigTot as null and pretty-prints', () => {
|
|
const json = toJson(professions, [row('a', 'Arts', '2000-01-01')]);
|
|
expect(JSON.parse(json)).toEqual([
|
|
{ program: 'a', beroep: 'Arts', geldigVan: '2000-01-01', geldigTot: null },
|
|
]);
|
|
expect(json.endsWith('\n')).toBe(true);
|
|
});
|
|
it('coerces a number column', () => {
|
|
const table: StamTable = {
|
|
id: 't',
|
|
label: 't',
|
|
temporal: false,
|
|
columns: [
|
|
{ name: 'code', type: 'text', isKey: true, options: [] },
|
|
{ name: 'jaar', type: 'number', isKey: false, options: [] },
|
|
],
|
|
};
|
|
expect(JSON.parse(toJson(table, [{ code: 'x', jaar: '2020' }]))).toEqual([
|
|
{ code: 'x', jaar: 2020 },
|
|
]);
|
|
});
|
|
});
|