Edwin van den Houdt
d08f3877f7
Acts on the showcase review. Four workstreams; all tests green (npm run lint, 70 FE tests, ng build, 33 backend tests). Enforcement + CI: - eslint.config.mjs bans `any` and enforces layer/context boundaries (domain ≠ Angular; herregistratie → registratie → shared, auth → shared); `npm run lint` added; ajv 6 scoped to ESLint via nested override. - .github/workflows/ci.yml: FE lint+check:tokens+test+build, backend dotnet test, and an API-client drift check. One form idiom (the headline finding): - change-request-form converged onto the wizard pattern — change-request.machine.ts (Model/Msg/reduce + value objects) + submit-change-request.ts (Result) + a real POST /api/v1/change-requests (server re-validates). Spec + story added; the detail page no longer holds an ad-hoc success signal. Resilience/observability seam: - api-client.provider.ts: request timeout, X-Correlation-Id, Idempotency-Key for writes; comments naming the retry/auth seams. - Backend logs correlation id + a no-PII submit-audit line; /api/v1 prefix + backward-compat note; client regenerated. Quick wins: - Dev tooling excluded from prod: scenario.interceptor wired only under isDevMode() (?scenario= inert in prod); debug panel @if(isDev) (tree-shaken out). - src/environments + apiBaseUrl into provideApiClient (angular.json fileReplacements). - Backend /health + /health/ready. - Debug view PII-minimised (redactProfile: name/address/DOB redacted, BIG masked). - IntakePolicyAdapter (removes inline resource in the intake wizard). - README de-staled; CLAUDE.md gains EN/NL + forms-one-idiom + lint/CI notes. - Stories: text-input, link, data-row, site-header, site-footer, change-request-form. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
33 lines
1.6 KiB
TypeScript
33 lines
1.6 KiB
TypeScript
import type { Meta, StoryObj } from '@storybook/angular';
|
|
import { applicationConfig } from '@storybook/angular';
|
|
import { provideHttpClient } from '@angular/common/http';
|
|
import { ChangeRequestFormComponent } from './change-request-form.component';
|
|
import { provideApiClient } from '@shared/infrastructure/api-client.provider';
|
|
import { Postcode } from '@registratie/domain/value-objects/postcode';
|
|
|
|
const validData = { straat: 'Lange Voorhout 9', postcode: '2514 EA' as Postcode, woonplaats: 'Den Haag' };
|
|
|
|
const meta: Meta<ChangeRequestFormComponent> = {
|
|
title: 'Organisms/Change Request Form',
|
|
component: ChangeRequestFormComponent,
|
|
// The form injects ApiClient (over HttpClient) for the submit command.
|
|
decorators: [applicationConfig({ providers: [provideHttpClient(), provideApiClient()] })],
|
|
};
|
|
export default meta;
|
|
type Story = StoryObj<ChangeRequestFormComponent>;
|
|
|
|
// One render per state of the machine.
|
|
export const Empty: Story = { args: { seed: { tag: 'Editing', draft: { straat: '', postcode: '', woonplaats: '' }, errors: {} } } };
|
|
export const WithErrors: Story = {
|
|
args: {
|
|
seed: {
|
|
tag: 'Editing',
|
|
draft: { straat: '', postcode: 'nope', woonplaats: '' },
|
|
errors: { straat: 'Vul straat en huisnummer in.', postcode: 'Voer een geldige postcode in, bijv. 1234 AB.' },
|
|
},
|
|
},
|
|
};
|
|
export const Submitting: Story = { args: { seed: { tag: 'Submitting', data: validData } } };
|
|
export const Submitted: Story = { args: { seed: { tag: 'Submitted', data: validData, referentie: 'BIG-2026-123456' } } };
|
|
export const Failed: Story = { args: { seed: { tag: 'Failed', data: validData, error: 'Netwerkfout' } } };
|