Merge RB-11 — keep the dev hatches out of production builds

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

# Conflicts:
#	libs/shared/docs/behaviour-spec.mdx

libs/shared/src/infrastructure/role.spec.ts

@@ -0,0 +1,65 @@
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import { currentRole, ROLES } from './role';
+
+const setUrl = (search: string) => history.pushState({}, '', search || '/');
+
+// isDevMode() reads the `ngDevMode` global the Angular CLI defines away in a
+// production build. There is no ambient type for it in app code, so this is
+// accessed through an untyped bag rather than a `declare const`.
+const globals = globalThis as Record<string, unknown>;
+const originalNgDevMode = globals['ngDevMode'];
+const setDevMode = (on: boolean) => {
+  globals['ngDevMode'] = on;
+};
+
+describe('currentRole (dev mechanism)', () => {
+  beforeEach(() => {
+    sessionStorage.clear();
+    setUrl('/');
+    setDevMode(true);
+  });
+  afterEach(() => {
+    globals['ngDevMode'] = originalNgDevMode;
+  });
+
+  it('lists the three roles', () => {
+    expect(ROLES).toEqual(['drafter', 'approver', 'admin']);
+  });
+
+  it('reads a valid ?role= from the URL and persists it for the tab', () => {
+    setUrl('?role=admin');
+    expect(currentRole()).toBe('admin');
+    setUrl('/'); // navigation drops the query param — value stays sticky
+    expect(currentRole()).toBe('admin');
+  });
+
+  it('falls back to drafter when nothing is set or the value is invalid', () => {
+    expect(currentRole()).toBe('drafter');
+    setUrl('?role=nonsense');
+    expect(currentRole()).toBe('drafter');
+  });
+
+  // BIO-012: the three hand-written `fetch` adapters call this function directly,
+  // bypassing `roleInterceptor`'s own isDevMode()-gated registration — so the gate
+  // has to hold here, not just at the interceptor, or `?role=` keeps working in a
+  // production build through that side door.
+  describe('outside isDevMode() (production build)', () => {
+    beforeEach(() => setDevMode(false));
+
+    it('ignores a ?role= in the URL and returns the default', () => {
+      setUrl('?role=admin');
+      expect(currentRole()).toBe('drafter');
+    });
+
+    it('never touches sessionStorage', () => {
+      setUrl('?role=admin');
+      currentRole();
+      expect(sessionStorage.getItem('dev-role')).toBeNull();
+    });
+
+    it('ignores a role already sitting in sessionStorage from a prior dev session', () => {
+      sessionStorage.setItem('dev-role', 'admin');
+      expect(currentRole()).toBe('drafter');
+    });
+  });
+});

libs/shared/src/infrastructure/role.ts

@@ -1,3 +1,4 @@
+import { isDevMode } from '@angular/core';
 import { Role } from '@shared/domain/role';
 
 /**
@@ -14,13 +15,22 @@ import { Role } from '@shared/domain/role';
  * don't carry it), which would silently revert an admin to drafter mid-session and
  * 403 the admin endpoints. So a `?role=` seen in the URL is remembered for the tab;
  * later requests use the remembered value. Set `?role=drafter` (or a fresh tab) to
- * reset. Dev-only — the interceptor itself is only wired under `isDevMode()`.
+ * reset.
+ *
+ * **Gated here, not only at the interceptor (BIO-012):** the `roleInterceptor` that
+ * consumes this for `HttpClient` traffic is only registered under `isDevMode()`
+ * (`app.config.ts`), but `brief`'s three hand-written `fetch` adapters call this
+ * function directly, bypassing that interceptor entirely. Reading `?role=` and
+ * writing it to `sessionStorage` is therefore gated in the function itself — outside
+ * `isDevMode()` the query param is never read, `sessionStorage` is never touched, and
+ * the fixed default (`drafter`, the least-privileged role) is returned every time.
  */
 const STORAGE_KEY = 'dev-role';
 export const ROLES: readonly Role[] = ['drafter', 'approver', 'admin'];
 const isRole = (v: string | null): v is Role => !!v && ROLES.includes(v as Role);
 
 export function currentRole(): Role {
+  if (!isDevMode()) return 'drafter';
   const fromUrl = new URLSearchParams(window.location.search).get('role');
   if (isRole(fromUrl)) {
     sessionStorage.setItem(STORAGE_KEY, fromUrl);

libs/shared/src/infrastructure/subject.spec.ts

@@ -0,0 +1,57 @@
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import { currentSubject } from './subject';
+
+const setUrl = (search: string) => history.pushState({}, '', search || '/');
+
+// isDevMode() reads the `ngDevMode` global the Angular CLI defines away in a
+// production build. There is no ambient type for it in app code, so this is
+// accessed through an untyped bag rather than a `declare const`.
+const globals = globalThis as Record<string, unknown>;
+const originalNgDevMode = globals['ngDevMode'];
+const setDevMode = (on: boolean) => {
+  globals['ngDevMode'] = on;
+};
+
+describe('currentSubject (dev mechanism)', () => {
+  beforeEach(() => {
+    sessionStorage.clear();
+    setUrl('/');
+    setDevMode(true);
+  });
+  afterEach(() => {
+    globals['ngDevMode'] = originalNgDevMode;
+  });
+
+  it('reads a ?subject= from the URL and persists it for the tab', () => {
+    setUrl('?subject=111222333');
+    expect(currentSubject()).toBe('111222333');
+    setUrl('/'); // navigation drops the query param — value stays sticky
+    expect(currentSubject()).toBe('111222333');
+  });
+
+  it('returns undefined when nothing has ever been set', () => {
+    expect(currentSubject()).toBeUndefined();
+  });
+
+  // BIO-012: a BSN is art. 9 GDPR special-category data. Prior to this fix this
+  // function wrote it into sessionStorage on any navigation, in any build.
+  describe('outside isDevMode() (production build)', () => {
+    beforeEach(() => setDevMode(false));
+
+    it('ignores a ?subject= (a BSN) in the URL and returns undefined', () => {
+      setUrl('?subject=111222333');
+      expect(currentSubject()).toBeUndefined();
+    });
+
+    it('never writes the BSN into sessionStorage', () => {
+      setUrl('?subject=111222333');
+      currentSubject();
+      expect(sessionStorage.getItem('dev-subject')).toBeNull();
+    });
+
+    it('ignores a subject already sitting in sessionStorage from a prior dev session', () => {
+      sessionStorage.setItem('dev-subject', '111222333');
+      expect(currentSubject()).toBeUndefined();
+    });
+  });
+});

libs/shared/src/infrastructure/subject.ts

@@ -1,3 +1,5 @@
+import { isDevMode } from '@angular/core';
+
 /**
  * Dev-only role stand-in's sibling (the reading MECHANISM for `X-Subject`; see
  * `role.ts`'s own doc comment for the twin `X-Role` mechanism this mirrors). This
@@ -13,6 +15,13 @@
  * hand-written `fetch`, which bypasses every `HttpInterceptorFn` — the same reason
  * that adapter already sets `X-Role` explicitly via `currentRole()`).
  *
+ * **Gated here, not only at the interceptor (BIO-012):** `subjectInterceptor` is only
+ * registered under `isDevMode()`, but `letter-preview.adapter.ts` calls this function
+ * directly and bypasses that interceptor. The value read here is a **BSN** — a GDPR
+ * special-category identifier — so outside `isDevMode()` the query param is never
+ * read and `sessionStorage` is never written; `undefined` is returned unconditionally,
+ * exactly as if no `?subject=` had ever been seen.
+ *
  * `undefined` (not a default BSN) when nothing has ever set `?subject=`: unlike
  * `currentRole()` (a closed enum with a sensible default), there is no "default
  * subject" to fall back to here — omitting the header entirely lets the backend's
@@ -21,6 +30,7 @@
 const STORAGE_KEY = 'dev-subject';
 
 export function currentSubject(): string | undefined {
+  if (!isDevMode()) return undefined;
   const fromUrl = new URLSearchParams(window.location.search).get('subject');
   if (fromUrl) {
     sessionStorage.setItem(STORAGE_KEY, fromUrl);