refactor: strip WP-/RB- ticket refs from backend (RD-19)

The backend half of the sweep RD-18 did for the front end. git blame
holds the provenance and stays correct when the code moves; the
comment names a closed ticket and tells the reader nothing the
sentence around it does not.

public/letter.css and LetterHtml.golden.html change together, because
the renderer inlines the CSS and the golden file snapshots the
result.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
eho
2026-09-04 21:48:08 +02:00
co-authored by Claude Sonnet 5
parent dd11eafe50
commit 8560746d15
89 changed files with 530 additions and 380 deletions
@@ -3,7 +3,7 @@ using System.Text.Json;
namespace BigRegister.Domain.Applications;
/// <summary>
/// The aanvraag lifecycle as a closed union (WP-73): <see cref="Concept"/> (the pre-submission
/// The aanvraag lifecycle as a closed union: <see cref="Concept"/> (the pre-submission
/// wizard draft) → <see cref="Submitted"/> (awaiting a behandelaar's decision, or already
/// auto-rejected at submission time — see <see cref="Submitted.Reden"/>) → <see cref="Decided"/>
/// (a behandelaar's outcome recorded). Each variant carries only the fields that make sense for
@@ -31,11 +31,11 @@ public abstract record Aanvraag
public required DateTimeOffset CreatedAt { get; init; }
public required DateTimeOffset UpdatedAt { get; init; }
/// <summary>The OpenZaak zaak's URL, set once CreateZaak (WP-50) registers one — null under
/// <summary>The OpenZaak zaak's URL, set once CreateZaak registers one — null under
/// the local source, or before a zaak has been registered at all.</summary>
public string? ZaakUrl { get; init; }
/// <summary>WP-60: non-null means the ZGW side of this aanvraag's last write did not
/// <summary>Non-null means the ZGW side of this aanvraag's last write did not
/// complete — see <c>Api.Data.ApplicationStore.SetZgwError</c>.</summary>
public string? ZgwError { get; init; }
@@ -76,7 +76,7 @@ public abstract record Aanvraag
public string? Reden { get; init; }
}
/// <summary>A behandelaar's decision (WP-65b/68) — closed by besluit: only
/// <summary>A behandelaar's decision — closed by besluit: only
/// <see cref="Afgewezen"/>/<see cref="MeerInfoGevraagd"/> require a toelichting
/// (<c>BeoordelingRules.RequiresToelichting</c>'s rule, now also a type, not just an endpoint
/// check) — omitting it is a compile error, not merely a 400 the type happens to also let