test(backend): split RuleTests.cs by aggregate, refresh DDD doc (WP-71)

RuleTests.cs held five aggregates' rules as nested classes in one file, misaligned with Domain/<Aggregate>/ and with the Acceptance/Builders/ folder convention WP-70 started. Split into Domain/<Aggregate>RuleTests.cs (pure move — same names, same bodies, same count) plus a new ApplicationRuleTests.cs (the enum invariant moved out of the WebApplicationFactory-booting ApplicationTests.cs, since it's a pure Enum.GetNames check with no business needing a web host) and OrgTemplateRuleTests.cs (RejectDraft had no direct unit test before, only endpoint coverage). libs/shared/docs/layers.mdx still taught the pre-WP-67 shape (six contexts, no apps/libs split, enforcement via ESLint) — updated to the real monorepo structure and to dependency-cruiser as the actual enforcement mechanism. Adds specs for registration.policy.ts's isStatusConsistent (untested; its backend mirror is) and both apps' auth/domain/session.ts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-18 20:25:05 +02:00
parent b937e55ad3
commit 28c0a250e7
13 changed files with 409 additions and 254 deletions
@@ -0,0 +1,51 @@
+using BigRegister.Domain.Applications;
+using BigRegister.Domain.Beoordeling;
+using BigRegister.Tests.Builders;
+
+namespace BigRegister.Tests.Domain;
+
+public class BeoordelingRuleTests
+{
+  [Theory]
+  [InlineData(AanvraagStatusTag.Ingediend, true)]
+  [InlineData(AanvraagStatusTag.InBehandeling, true)]
+  [InlineData(AanvraagStatusTag.MeerInfoGevraagd, true)]
+  [InlineData(AanvraagStatusTag.Goedgekeurd, false)]
+  [InlineData(AanvraagStatusTag.Afgewezen, false)]
+  public void Only_open_statuses_are_decidable(AanvraagStatusTag tag, bool expected) =>
+      Assert.Equal(expected, BeoordelingRules.CanDecide(tag));
+
+  // WP-68 (F6): the toelichting rule, moved here from an inline endpoint check.
+  [Theory]
+  [InlineData(Besluit.Goedkeuren, false)]
+  [InlineData(Besluit.Afwijzen, true)]
+  [InlineData(Besluit.MeerInfoOpvragen, true)]
+  public void Only_a_non_approval_requires_a_toelichting(Besluit besluit, bool expected) =>
+      Assert.Equal(expected, BeoordelingRules.RequiresToelichting(besluit));
+
+  // WP-68 (T3): the transition table at the AGGREGATE level, not just against a bare tag —
+  // an Aanvraag whose BesluitStatus already records a terminal decision computes a terminal
+  // StatusAt, and CanDecide refuses a further besluit regardless of which one. Pins the
+  // domain statement "Afgewezen/Goedgekeurd → no further besluit" independent of the
+  // endpoint's own (integration-level) Already_decided_case_rejects_a_further_besluit.
+  // WP-70: built via Given, not a hand-rolled Aanvraag literal — Decided(Besluit.Afwijzen) with
+  // no toelichting simply couldn't compile as a fixture here.
+  [Theory]
+  [InlineData(Besluit.Goedkeuren)]
+  [InlineData(Besluit.Afwijzen)]
+  public void A_terminal_decision_refuses_any_further_besluit(Besluit recorded)
+  {
+    var now = DateTimeOffset.UtcNow;
+    var toelichting = recorded == Besluit.Goedkeuren ? null : "toelichting";
+    var aanvraag = Given.Concept(owner: "test").Submitted().Decided(recorded, toelichting).Build();
+    Assert.False(BeoordelingRules.CanDecide(aanvraag.StatusAt(now).Tag!.Value));
+  }
+
+  [Fact]
+  public void MeerInfoOpvragen_is_not_terminal_a_further_besluit_is_still_legal()
+  {
+    var now = DateTimeOffset.UtcNow;
+    var aanvraag = Given.Concept(owner: "test").Submitted().Decided(Besluit.MeerInfoOpvragen, "toelichting").Build();
+    Assert.True(BeoordelingRules.CanDecide(aanvraag.StatusAt(now).Tag!.Value));
+  }
+}